From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Phillips Subject: Re: [PATCH] drop-behind fix for generic_file_write Date: Wed, 3 Jan 2001 16:21:17 +0100 Content-Type: text/plain References: In-Reply-To: MIME-Version: 1.0 Message-Id: <01010316360903.00713@gimli> Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org Return-Path: To: Rik van Riel , Linus Torvalds Cc: Alan Cox , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Wed, 03 Jan 2001, Rik van Riel wrote: > Hi Linus, Alan, > > the following (trivial) patch fixes drop-behind behaviour > in generic_file_write to only drop fully written pages. > > This increases performance in dbench by about 8% (as > measured by Daniel Phillips) and should get rid of the > logfile bottleneck Ingo Molnar found with the drop-behind > call in generic_file_write in TUX tests. Rik, I detected the speedup in -pre5 but it disappeared in -pre7 (which turned in a faster performance than pre5 or 6 anyway). I don't have an explanation for that. The idea makes sense: treat a partial page as 'in play' until completely full, then deactivate it. -- Daniel -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux.eu.org/Linux-MM/