From: Christopher Lameter <cl@linux.com>
To: Roman Gushchin <guro@fb.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Shakeel Butt <shakeelb@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Rik van Riel <riel@surriel.com>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
cgroups@vger.kernel.org
Subject: Re: [PATCH v3 4/7] mm: unify SLAB and SLUB page accounting
Date: Mon, 13 May 2019 18:01:05 +0000 [thread overview]
Message-ID: <0100016ab25aef20-4552213a-13e1-4aff-ba52-e970f3ac7fd4-000000@email.amazonses.com> (raw)
In-Reply-To: <20190508202458.550808-5-guro@fb.com>
On Wed, 8 May 2019, Roman Gushchin wrote:
> Currently the page accounting code is duplicated in SLAB and SLUB
> internals. Let's move it into new (un)charge_slab_page helpers
> in the slab_common.c file. These helpers will be responsible
> for statistics (global and memcg-aware) and memcg charging.
> So they are replacing direct memcg_(un)charge_slab() calls.
Looks good.
Acked-by: Christoph Lameter <cl@linux.com>
next prev parent reply other threads:[~2019-05-13 18:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 20:24 [PATCH v3 0/7] mm: reparent slab memory on cgroup removal Roman Gushchin
2019-05-08 20:24 ` [PATCH v3 1/7] mm: postpone kmem_cache memcg pointer initialization to memcg_link_cache() Roman Gushchin
2019-05-11 0:32 ` Shakeel Butt
2019-05-08 20:24 ` [PATCH v3 2/7] mm: generalize postponed non-root kmem_cache deactivation Roman Gushchin
2019-05-11 0:33 ` Shakeel Butt
2019-05-08 20:24 ` [PATCH v3 3/7] mm: introduce __memcg_kmem_uncharge_memcg() Roman Gushchin
2019-05-11 0:33 ` Shakeel Butt
2019-05-08 20:24 ` [PATCH v3 4/7] mm: unify SLAB and SLUB page accounting Roman Gushchin
2019-05-11 0:33 ` Shakeel Butt
2019-05-13 18:01 ` Christopher Lameter [this message]
2019-05-08 20:24 ` [PATCH v3 5/7] mm: rework non-root kmem_cache lifecycle management Roman Gushchin
2019-05-11 0:33 ` Shakeel Butt
2019-05-08 20:24 ` [PATCH v3 6/7] mm: reparent slab memory on cgroup removal Roman Gushchin
2019-05-11 0:34 ` Shakeel Butt
2019-05-08 20:24 ` [PATCH v3 7/7] mm: fix /proc/kpagecgroup interface for slab pages Roman Gushchin
2019-05-11 0:34 ` Shakeel Butt
2019-05-11 0:32 ` [PATCH v3 0/7] mm: reparent slab memory on cgroup removal Shakeel Butt
2019-05-13 20:21 ` Roman Gushchin
2019-05-14 19:22 ` Shakeel Butt
2019-05-14 20:04 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0100016ab25aef20-4552213a-13e1-4aff-ba52-e970f3ac7fd4-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=riel@surriel.com \
--cc=shakeelb@google.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox