From: Christopher Lameter <cl@linux.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: penberg@kernel.org, rientjes@google.com,
akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/3] mm, slub: not retrieve cpu_slub again in new_slab_objects()
Date: Thu, 25 Oct 2018 13:46:49 +0000 [thread overview]
Message-ID: <01000166ab7a489c-a877d05e-957c-45b1-8b62-9ede88db40a3-000000@email.amazonses.com> (raw)
In-Reply-To: <20181025094437.18951-1-richard.weiyang@gmail.com>
On Thu, 25 Oct 2018, Wei Yang wrote:
> In current code, the following context always meets:
>
> local_irq_save/disable()
> ___slab_alloc()
> new_slab_objects()
> local_irq_restore/enable()
>
> This context ensures cpu will continue running until it finish this job
> before yield its control, which means the cpu_slab retrieved in
> new_slab_objects() is the same as passed in.
Interrupts can be switched on in new_slab() since it goes to the page
allocator. See allocate_slab().
This means that the percpu slab may change.
next prev parent reply other threads:[~2018-10-25 13:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 9:44 Wei Yang
2018-10-25 9:44 ` [PATCH 2/3] mm, slub: unify access to s->cpu_slab by replacing raw_cpu_ptr() with this_cpu_ptr() Wei Yang
2018-10-25 13:53 ` Christopher Lameter
2018-10-25 14:49 ` Wei Yang
2018-10-25 9:44 ` [PATCH 3/3] mm, slub: make the comment of put_cpu_partial() complete Wei Yang
2018-10-25 13:41 ` Christopher Lameter
2018-12-30 8:25 ` Wei Yang
2018-10-25 13:46 ` Christopher Lameter [this message]
2018-10-25 14:54 ` [PATCH 1/3] mm, slub: not retrieve cpu_slub again in new_slab_objects() Wei Yang
2018-10-26 4:33 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01000166ab7a489c-a877d05e-957c-45b1-8b62-9ede88db40a3-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=richard.weiyang@gmail.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox