linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christopher Lameter <cl@linux.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Greg KH <gregkh@linux-foundation.org>,
	zhong jiang <zhongjiang@huawei.com>,
	penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
	akpm@linux-foundation.org, mhocko@kernel.org, mgorman@suse.de,
	vbabka@suse.cz, andrea@kernel.org, kirill@shutemov.name,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [STABLE PATCH] slub: make ->cpu_partial unsigned int
Date: Tue, 2 Oct 2018 14:50:22 +0000	[thread overview]
Message-ID: <01000166354231f3-1e953571-f9ec-4a73-a228-ff3692825b41-000000@email.amazonses.com> (raw)
In-Reply-To: <20180930132333.GA10872@bombadil.infradead.org>

On Sun, 30 Sep 2018, Matthew Wilcox wrote:

> > And the patch in mainline has Christoph's ack...
>
> I'm not saying there's a problem with the patch.  It's that the rationale
> for backporting doesn't make any damned sense.  There's something going
> on that nobody understands.  This patch is probably masking an underlying
> problem that will pop back up and bite us again someday.

Right. That is why I raised the issue. I do not see any harm in
backporting but I do not think it fixes the real issue which may be in
concurrent use of page struct fields that are overlapping.

  reply	other threads:[~2018-10-02 14:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-30 10:28 zhong jiang
2018-09-30 12:37 ` Greg KH
2018-09-30 12:50 ` Matthew Wilcox
2018-09-30 13:10   ` Greg KH
2018-09-30 13:23     ` Matthew Wilcox
2018-10-02 14:50       ` Christopher Lameter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-09-27 14:43 zhong jiang
2018-09-27 15:26 ` Christopher Lameter
2018-09-27 15:46 ` Greg KH
2018-09-28  8:06   ` zhong jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01000166354231f3-1e953571-f9ec-4a73-a228-ff3692825b41-000000@email.amazonses.com \
    --to=cl@linux.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrea@kernel.org \
    --cc=gregkh@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@kernel.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    --cc=zhongjiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox