From: Christopher Lameter <cl@linux.com>
To: zhong jiang <zhongjiang@huawei.com>
Cc: gregkh@linux-foundation.org, iamjoonsoo.kim@lge.com,
rientjes@google.com, penberg@kernel.org,
akpm@linux-foundation.org, mhocko@suse.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [STABLE PATCH] slub: make ->cpu_partial unsigned int
Date: Thu, 27 Sep 2018 15:26:38 +0000 [thread overview]
Message-ID: <010001661ba398a8-f7e5b6c8-b7ff-4f01-8b18-0ad582344ea7-000000@email.amazonses.com> (raw)
In-Reply-To: <1538059420-14439-1-git-send-email-zhongjiang@huawei.com>
On Thu, 27 Sep 2018, zhong jiang wrote:
> From: Alexey Dobriyan <adobriyan@gmail.com>
>
> /*
> * cpu_partial determined the maximum number of objects
> * kept in the per cpu partial lists of a processor.
> */
>
> Can't be negative.
True.
> I hit a real issue that it will result in a large number of memory leak.
> Because Freeing slabs are in interrupt context. So it can trigger this issue.
> put_cpu_partial can be interrupted more than once.
> due to a union struct of lru and pobjects in struct page, when other core handles
> page->lru list, for eaxmple, remove_partial in freeing slab code flow, It will
> result in pobjects being a negative value(0xdead0000). Therefore, a large number
> of slabs will be added to per_cpu partial list.
That sounds like it needs more investigation. Concurrent use of page
fields for other purposes can cause serious bugs.
>
> I had posted the issue to community before. The detailed issue description is as follows.
I did not see it. Please make sure to CC the maintainers.
next prev parent reply other threads:[~2018-09-27 15:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 14:43 zhong jiang
2018-09-27 15:26 ` Christopher Lameter [this message]
2018-09-27 15:46 ` Greg KH
2018-09-28 8:06 ` zhong jiang
2018-09-30 10:28 zhong jiang
2018-09-30 12:37 ` Greg KH
2018-09-30 12:50 ` Matthew Wilcox
2018-09-30 13:10 ` Greg KH
2018-09-30 13:23 ` Matthew Wilcox
2018-10-02 14:50 ` Christopher Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010001661ba398a8-f7e5b6c8-b7ff-4f01-8b18-0ad582344ea7-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=stable@vger.kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox