From: David Rientjes <rientjes@google.com>
To: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@gentwo.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Harry Yoo <harry.yoo@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slub: drop duplicate kernel-doc for ksize()
Date: Sat, 21 Feb 2026 19:47:49 -0800 (PST) [thread overview]
Message-ID: <00fc801f-6a11-4510-2b77-a683e5e37c77@google.com> (raw)
In-Reply-To: <20260220124243.3264133-1-sanjayembedded@gmail.com>
On Fri, 20 Feb 2026, Sanjay Chitroda wrote:
> From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
>
> The ksize() API is already documented in the public header, and
> Documentation/core-api/mm-api.rst pulls that canonical doc into the
> book. The kernel-doc block added to mm/slub.c by commit
> fab0694646d7 ("mm/slab: move [__]ksize and slab_ksize() to mm/slub.c")
> introduced a second definition for the same symbol in the generated
> docs, which makes Sphinx emit:
>
> WARNING: Duplicate C declaration, also defined at core-api/mm-api:521
> Declaration is '.. c:function:: size_t ksize(const void *objp)'
>
> Remove the redundant kernel-doc comment from slub.c so only the
> header-provided documentation is emitted. This keeps the user-visible
> API documentation intact while eliminating the duplicate-declaration
> warning during `make htmldocs`.
>
> No functional change.
>
> Fixes: fab0694646d7 ("mm/slab: move [__]ksize and slab_ksize() to mm/slub.c")
> Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
The header file kernel-doc looks equivalent without mentioning that it
returns bytes. Might be best to make that clear in slab.h?
prev parent reply other threads:[~2026-02-22 3:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 12:42 Sanjay Chitroda
2026-02-22 3:47 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00fc801f-6a11-4510-2b77-a683e5e37c77@google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=harry.yoo@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=roman.gushchin@linux.dev \
--cc=sanjayembeddedse@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox