From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: 'Vlastimil Babka' <vbabka@suse.cz>,
"'P. Christeas'" <xrg@linux.gr>,
'linux-kernel' <linux-kernel@vger.kernel.org>
Cc: linux-mm@kvack.org
Subject: Re: Early test: hangs in mm/compact.c w. Linus's 12d7aacab56e9ef185c
Date: Mon, 10 Nov 2014 11:23:15 +0800 [thread overview]
Message-ID: <00f301cffc95$ab4adad0$01e09070$@alibaba-inc.com> (raw)
In-Reply-To: <545F3556.5000802@suse.cz>
> >
> > I guess this one would mitigate against Vlastmil's migration scanner issue,
> > wouldn't it?
>
Nope, I wanted to see if free pages are low enough.
> Please no, that's a wrong fix. The purpose of compaction is to make the
> high-order watermark meet, not give up.
>
Yupe, have to spin.
--- a/mm/compaction.c Sun Nov 9 12:02:59 2014
+++ b/mm/compaction.c Mon Nov 10 11:12:07 2014
@@ -1074,6 +1074,8 @@ static int compact_finished(struct zone
watermark = low_wmark_pages(zone);
watermark += (1 << cc->order);
+ if (!zone_watermark_ok(zone, 0, watermark, 0, 0))
+ return COMPACT_SKIPPED;
if (!zone_watermark_ok(zone, cc->order, watermark, 0, 0))
return COMPACT_CONTINUE;
--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-11-10 3:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-09 4:47 Hillf Danton
2014-11-09 8:22 ` P. Christeas
2014-11-09 9:35 ` Vlastimil Babka
2014-11-10 3:23 ` Hillf Danton [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-04 7:26 P. Christeas
2014-11-04 8:55 ` Vlastimil Babka
2014-11-04 9:36 ` P. Christeas
2014-11-05 15:26 ` Vlastimil Babka
2014-11-05 16:02 ` P. Christeas
2014-11-06 19:23 ` P. Christeas
2014-11-06 21:38 ` Vlastimil Babka
2014-11-08 13:11 ` P. Christeas
2014-11-08 22:18 ` Vlastimil Babka
2014-11-09 8:27 ` Pavel Machek
2014-11-09 9:43 ` Vlastimil Babka
2014-11-09 22:32 ` Norbert Preining
2014-11-10 6:07 ` Joonsoo Kim
2014-11-10 7:53 ` Vlastimil Babka
2014-11-10 8:05 ` Joonsoo Kim
2014-11-10 8:14 ` P. Christeas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00f301cffc95$ab4adad0$01e09070$@alibaba-inc.com' \
--to=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=xrg@linux.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox