From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2363CC25B78 for ; Tue, 4 Jun 2024 10:43:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CDD56B00BD; Tue, 4 Jun 2024 06:43:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77C916B00BE; Tue, 4 Jun 2024 06:43:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F5D76B00BF; Tue, 4 Jun 2024 06:43:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 40B386B00BD for ; Tue, 4 Jun 2024 06:43:35 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CCA60140F1D for ; Tue, 4 Jun 2024 10:43:34 +0000 (UTC) X-FDA: 82192869948.24.A9EAD95 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 966631C0005 for ; Tue, 4 Jun 2024 10:43:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gK0BlZrU; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717497812; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ajdsOZR0w0yo30qaDX6u90Ek5kU2b88kP4PAC8KC4fo=; b=HAIvLal5sXD5KeOJeEyXmqb7no5KwS3x4Q6ozMCradOY/0ra177F+ZprNkACe1JYtJKsdc +dyCWkD3UEEcu+yJ0NoVW6G5JbMTC/ZYwPfNPkuzrpCTG2Drxb3E4Wi/LhOkEA+E5PZwCs 0Nm0eQLdgI64dIWWQkgYXAUPDHxj9kc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717497812; a=rsa-sha256; cv=none; b=WuIyhyE65cw9oGk3CsobjM0LWln8WFLOrlE5Pxz+fIMRMeA1m4gU8NGw7bdNYt/zO6O2zK wW/jqv8HNBKcwIw7GzYjQE8cU1ZTiiSCXVhAtOT45Ft6ZGoXz6v29QAA+bOU6Y0C4HJybd VTkSuaQXH4P3lAdcq+6wzCMsczNMAPg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gK0BlZrU; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717497811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ajdsOZR0w0yo30qaDX6u90Ek5kU2b88kP4PAC8KC4fo=; b=gK0BlZrU+id6hJAc3h0Goe2Tn8iQ8je0y40sauyu118nRhu9hbJyJ2PKD7nFll9UdhPAvc Ib/czdd3fgeog2dTqdVgAm8k0sbR+h5NXokC85Qc9UG8g24nrasIR7xtiwL6KcLl0dd/zH Q15n7swuEXXi7Q+kSC6X8oCcefkKMJo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-53-sGFRHcpVN22tVLjHSFjvNA-1; Tue, 04 Jun 2024 06:43:30 -0400 X-MC-Unique: sGFRHcpVN22tVLjHSFjvNA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-35dc5934390so2812519f8f.0 for ; Tue, 04 Jun 2024 03:43:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717497809; x=1718102609; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ajdsOZR0w0yo30qaDX6u90Ek5kU2b88kP4PAC8KC4fo=; b=l73zppVYgUvJ+Mq9H9CbgO06/PHqj7fgfg7ohNQVIZ09+6JmLUQ3jazb+46u3mygQs wtAde8zh5xRfVar5vLzu2EdID5cXQK3bB7zZHAaHjQzq8uRU8Z8EadbhWyjpfbleJ3Qa Im68L2QzzChclOcTIv1xgUEh5UzFclXVLxcboi9TIBDzOuqGRAEdnrhGbTJ2eEzzmOzD lGFmaW3U4BD+txLxHVIWbQKUQBiJs9K6ewrprLkvG2zRyYVmryhb2IWjbUpVNsVp0WvF auq/j9ONV0/h9hv6otVR58yzEl2S5t8GsiBweWCC4B8AOv/arz/kY3RjtrYqKp1VB72i gc5Q== X-Forwarded-Encrypted: i=1; AJvYcCW4gwgGLVxDciLr/x0+mrHSQ8dNu+uoWD+OTdjxlYFiHrFKziYzTMFoTQM3xbX1BUBWM+o5WOdcco1xq2TSgw7qHXk= X-Gm-Message-State: AOJu0YyDgYhE8z8X8ksXjSy9exzrQ4NOL6ZFhYTiQXme4Nhq+s63Nuqs B7EctF8LRNaI81AUStyhEb3KXw41cGqKS01PGngfMPANV6vWX5+l+o8EY0GSyULqLO4G8Z7+tbv Mcv+fg0SbYxQe5wFeiC0/DOofbqR0Z1OUQ19XQ2vWGy9EGxAl X-Received: by 2002:adf:e386:0:b0:354:db90:6df1 with SMTP id ffacd0b85a97d-35e0f28590emr9252330f8f.38.1717497809368; Tue, 04 Jun 2024 03:43:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjwxmPwn62C6Nq0puMDiUKK2NN+CXbdv7oUo4JOG7HJoIdbxXPJPESEIlDlqHsZo1Ec6blRA== X-Received: by 2002:adf:e386:0:b0:354:db90:6df1 with SMTP id ffacd0b85a97d-35e0f28590emr9252309f8f.38.1717497808903; Tue, 04 Jun 2024 03:43:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c73a:3a00:a025:9b06:549e:c16b? (p200300cbc73a3a00a0259b06549ec16b.dip0.t-ipconnect.de. [2003:cb:c73a:3a00:a025:9b06:549e:c16b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd062fe96sm11133331f8f.67.2024.06.04.03.43.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 03:43:28 -0700 (PDT) Message-ID: <00dcd224-6333-4f1e-9087-bdb5024ac236@redhat.com> Date: Tue, 4 Jun 2024 12:43:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/10] mm/ksm: skip subpages of compound pages To: Alex Shi , alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, izik.eidus@ravellosystems.com, willy@infradead.org, aarcange@redhat.com, chrisw@sous-sol.org, hughd@google.com References: <20240604042454.2012091-1-alexs@kernel.org> <20240604042454.2012091-3-alexs@kernel.org> <8d3a60d5-06c5-4df4-aeda-2fbec45a8ae0@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: kw7jqzehbh9yiksit9sfnbo965d5c4ff X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 966631C0005 X-HE-Tag: 1717497812-963024 X-HE-Meta: U2FsdGVkX192DGOz9rgpmB89Az69N5HhCrVT6UQw8xMKY5sdZIXuz0LCPkErRE0LVsKCuxkloD7ePCmWiqnS172t7i+1Jh4vpA13NyBJo8JHZ/SLBQlB6R9xT3nlMSMyi67r2RSqmfjsqpqEau6cKzWiQNpWOqUI1aBrfDYRDZpRkFvFdDqEVqOqGSJUPIXZcaFgt8Tz9kdkizv10eQrYVpi7N6ADBh08f/ZRAVPM7BCWu6lFcOBTC16jbsL3VDaRrctFBuO/ewarKGYqX6YpYK/P37Nz0WZdjTKsB+/hvlPPsdjaCmVtMEId5CrEaoJWcq/49wyy7LDMM9F4cRBnoNu5Y9Qb3eS8MFTrGBMudyO7iJm4CcoRXKg4hdBW1ZgldYuo2plJxKXxYqlOIDPsP4trVwXbAVcviPrxqTAHnYGAde1n2SEPwKimhVm8ikgMEvDTvahXcFemz79r7kVMkB6T551i+Qj8uW7vZ5KdNAQMU2j4sT9/fpb+AjpDovvX8zxDpqhM8zINmu4xDmX3XOtVCPvtQ2K+c91iYkf88f1Awq+dxcO+Ip6hoCf3BqyFNFFqyeChArIP5KFk6rrLxGBhwvziJii7jNF229tU3s0eGAvLsQCZN2FFofTTQOkt9XSBa9/c4/rQDjHxBO8rTqZwDyY2jdLSUGgY7B5FH/hiH7co5np95pc1Wjyg5PfS5Jw4AuXemh5io89u1hkxATwYLm6qQTnTC5kyu4otkiDF79vV1LonnV+ZJRORE6LvIDGr37L36VC9n7bkQwUXGnXLAL0hC9mcLDQG7L1UGMZvJHvbCcHbTWtnzZHnYOjDOwRrFkeRpQBPLSCygGBjDd672WdaZfxUjXWXrTJlmIuUFFXXmsJyQ7YxPnrY1rp5OU3ZJaPRaTqimJy/EOpAAbEhCbEgsZxCTqQq9l2OieeOcQ0ujs436EWFoMtNV3WrviyeG1NVryh0i/6gV+ D011ycDm hxWhXaK3PFrFo0GtTvlpkaA9oniXBZoWpNGbEAqMq9aapQtSgU88Et30nrEALM9yOUrihFFNq1ufNEtIkcOatbcgn6aXE4kfkuhU8dwnt8cCFdJi1soTYs2defzgudt9DdA4mkARBee8ASbC0PQPUYCcivJBnexyXwnb8ERtZeXA4PtcqeczHzgH4gT6uyeC2Vc4CMyA25fxGQFGY32LxyTJ+2IBr7AkTsnpY32B3Be7jp53f9s7HSRR2JrV6H6QFyhB+tIEtgNA9oD8J4MmPBc3mlfbn+azREgkLOKkH1+XRkmJfQkwWJosaGLyPtoeLHpxiCZVLMZXr5F8DvTS9bOcqFbNtaDScpinqEKiskEcnOgtBXHpmCFOsAYtbGTmER38yn5fwv5dwFmwi3QaXOIaDbP1TPfpe4mFjsbyVRFIpQ7w3/GpF/DfO4Op7y25zDCX4y3xomPe9BGGFp0tW510rLwwzs97tynNH67w63kxho9zEY4D4msHwOEkv1tDdJuOMJlcgCLk3OW+zoxI7BMza1grU0phNjlf1rFtzEqFKqIs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.24 12:31, Alex Shi wrote: > > > On 6/4/24 4:12 PM, David Hildenbrand wrote: >> On 04.06.24 06:24, alexs@kernel.org wrote: >>> From: "Alex Shi (tencent)" >>> >>> When a folio isn't fit for KSM, the subpages are unlikely to be good, >>> So let's skip the rest page checking to save some actions. >>> >>> Signed-off-by: Alex Shi (tencent) >>> --- >>>   mm/ksm.c | 9 +++++++-- >>>   1 file changed, 7 insertions(+), 2 deletions(-) >>> >>> diff --git a/mm/ksm.c b/mm/ksm.c >>> index 97e5b41f8c4b..e2fdb9dd98e2 100644 >>> --- a/mm/ksm.c >>> +++ b/mm/ksm.c >>> @@ -2644,6 +2644,8 @@ static struct ksm_rmap_item *scan_get_next_rmap_item(struct page **page) >>>           goto no_vmas; >>>         for_each_vma(vmi, vma) { >>> +        int nr = 1; >>> + >>>           if (!(vma->vm_flags & VM_MERGEABLE)) >>>               continue; >>>           if (ksm_scan.address < vma->vm_start) >>> @@ -2660,6 +2662,9 @@ static struct ksm_rmap_item *scan_get_next_rmap_item(struct page **page) >>>                   cond_resched(); >>>                   continue; >>>               } >>> + >>> +            VM_WARN_ON(PageTail(*page)); >>> +            nr = compound_nr(*page); >>>               if (is_zone_device_page(*page)) >>>                   goto next_page; >>>               if (PageAnon(*page)) { >>> @@ -2672,7 +2677,7 @@ static struct ksm_rmap_item *scan_get_next_rmap_item(struct page **page) >>>                       if (should_skip_rmap_item(*page, rmap_item)) >>>                           goto next_page; >>>   -                    ksm_scan.address += PAGE_SIZE; >>> +                    ksm_scan.address += nr * PAGE_SIZE; >>>                   } else >>>                       put_page(*page); >>>                   mmap_read_unlock(mm); >>> @@ -2680,7 +2685,7 @@ static struct ksm_rmap_item *scan_get_next_rmap_item(struct page **page) >>>               } >>>   next_page: >>>               put_page(*page); >>> -            ksm_scan.address += PAGE_SIZE; >>> +            ksm_scan.address += nr * PAGE_SIZE; >>>               cond_resched(); >>>           } >>>       } >> >> You might be jumping over pages that don't belong to that folio. What you would actually want to do is somehow use folio_pte_batch() to really know the PTEs point at the same folio, so you can skip them. But that's not that easy when using follow_page() ... >> >> So I suggest dropping this change for now. >> > > Hi David, > > Forgive my stupidity, where I jump over normal page that not to belong to the folio? IIUC, you assume that the folio is fully mapped by all PTEs that could span it, and that follow_page() would give you the head page, correct? As a simple example, assume only a single page of a large folio is still mapped, which could be any tail page. You couldn't jump over any PTEs. Or am I missing something? -- Cheers, David / dhildenb