From: Ben Greear <greearb@candelatech.com>
To: Suren Baghdasaryan <surenb@google.com>, Hao Ge <hao.ge@linux.dev>
Cc: kent.overstreet@linux.dev, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Hao Ge <gehao@kylinos.cn>
Subject: Re: [PATCH v2] mm/alloc_tag: Add kasan_alloc_module_shadow when CONFIS_KASAN_VMALLOC disabled
Date: Tue, 10 Dec 2024 10:56:59 -0800 [thread overview]
Message-ID: <00d8ba74-7661-e6ac-8a67-7af1df0f2f0a@candelatech.com> (raw)
In-Reply-To: <CAJuCfpGVTyKJ5yMQUqvNXRfBnBYj+dhUEqq0YAddtrqcWP27yw@mail.gmail.com>
On 12/10/24 09:55, Suren Baghdasaryan wrote:
> On Mon, Dec 9, 2024 at 10:53 PM Hao Ge <hao.ge@linux.dev> wrote:
>>
>> From: Hao Ge <gehao@kylinos.cn>
>>
>> When CONFIG_KASAN is enabled but CONFIG_KASAN_VMALLOC
>> is not enabled, we may encounter a panic during system boot.
>>
>> Because we haven't allocated pages and created mappings
>> for the shadow memory corresponding to module_tags region,
>> similar to how it is done for execmem_vmalloc.
>>
>> The difference is that our module_tags are allocated on demand,
>> so similarly,we also need to allocate shadow memory regions on demand.
>> However, we still need to adhere to the MODULE_ALIGN principle.
Hello,
I applied this patch:
https://lore.kernel.org/all/20241130001423.1114965-1-surenb@google.com/raw
as well as the v2 patch in this email thread, on top of today's Linus
kernel (plus local patches that should be un-related to this particular
issue) and now my system boots when my current mix of kernel debugging is enabled.
Thanks for the fix!
--Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2024-12-10 18:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 4:15 [PATCH] " Hao Ge
2024-12-10 6:53 ` [PATCH v2] " Hao Ge
2024-12-10 17:55 ` Suren Baghdasaryan
2024-12-10 18:45 ` Hao Ge
2024-12-10 19:20 ` Suren Baghdasaryan
2024-12-10 19:36 ` Hao Ge
2024-12-10 20:04 ` Suren Baghdasaryan
2024-12-11 1:10 ` Hao Ge
2024-12-11 2:57 ` [PATCH v3] mm/alloc_tag: Fix panic when CONFIG_KASAN enabled and CONFIG_KASAN_VMALLOC not enabled Hao Ge
2024-12-11 16:32 ` Suren Baghdasaryan
2024-12-12 1:07 ` Hao Ge
2024-12-12 1:37 ` [PATCH v4] " Hao Ge
2024-12-12 6:48 ` Suren Baghdasaryan
2024-12-12 7:03 ` [PATCH v5] " Hao Ge
2024-12-12 7:21 ` [PATCH v6] " Hao Ge
2024-12-12 14:07 ` Adrian Huang12
2024-12-11 17:18 ` [PATCH v3] " kernel test robot
2024-12-12 2:23 ` Hao Ge
2024-12-10 18:56 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00d8ba74-7661-e6ac-8a67-7af1df0f2f0a@candelatech.com \
--to=greearb@candelatech.com \
--cc=akpm@linux-foundation.org \
--cc=gehao@kylinos.cn \
--cc=hao.ge@linux.dev \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox