From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0032D43352 for ; Thu, 7 Nov 2024 12:53:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DBE46B0096; Thu, 7 Nov 2024 07:53:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 48C4F6B0098; Thu, 7 Nov 2024 07:53:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3054D6B0099; Thu, 7 Nov 2024 07:53:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 143006B0096 for ; Thu, 7 Nov 2024 07:53:35 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8B5E91601C1 for ; Thu, 7 Nov 2024 12:53:34 +0000 (UTC) X-FDA: 82759289298.23.10BE630 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 41AF1140016 for ; Thu, 7 Nov 2024 12:53:05 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ezbzd4Oo; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730983927; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4xZlnmGLbCcDQ6CocWnkklikB6SFfbo+Xp/psLT4134=; b=1PK2ATVJyCLhNoi8fv6gwrRbNFNZPeIlD9bvR1qTIC/yVdyLPOWKJOEAxSiTfF43+8Qf5Z Qx2NEQQ3Os/1Ojp/Ng9A3pri01s91tsPxuIGXxcKld/tNvJVNyL2YuCHHwgoBSP9r4FDGW 15ZS+jk/YI/7bmiX/GgqQxG/qZMZM0g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730983927; a=rsa-sha256; cv=none; b=6h5ss0v1DwzPbS9P+avqzhZokUYsy312RxTh2vhi3fj658ZtDV+XXuSiWLaxc6bDPoiSuG XBBVQcBnhBoFQGhvn/q77hkTJMpqSIiSKVApta+7cD9AcJXcFDQs9WB+zu1GOj7m9+MBrp BjaFeyI2TKbqwemdGf8IVokf8HxY8oM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ezbzd4Oo; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730984011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4xZlnmGLbCcDQ6CocWnkklikB6SFfbo+Xp/psLT4134=; b=Ezbzd4OoPVgHz7KHVEycpZSpM3RXMQOn/V7DgSzqWd/0BmsQvLR63PqVGTx8BRroTujzUX Dc55sihGtQT7uXLywK9jpc+43oc1miOT80oBcgbTKQiOJ8sMbannTyBLuEh3D7QMCkb50f UHTN29KPuOWVJ5NaM1CcfQJtUd2izy8= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-87q5jB9KM-CY1l9oUcc7JQ-1; Thu, 07 Nov 2024 07:53:30 -0500 X-MC-Unique: 87q5jB9KM-CY1l9oUcc7JQ-1 X-Mimecast-MFC-AGG-ID: 87q5jB9KM-CY1l9oUcc7JQ Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-53b1eddcf4aso690652e87.3 for ; Thu, 07 Nov 2024 04:53:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730984008; x=1731588808; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4xZlnmGLbCcDQ6CocWnkklikB6SFfbo+Xp/psLT4134=; b=s5hoGiSADqAmx4epBx4tU+Q4Ne1pzFI/wjRa6+3pQJaRExP15LVuoEUtlbeKwepghw NXo9edYlJ1UW1JBlpcxaICLIqUrEFw9/YUj7bcSkBotJqcpmV4AkBD6w4QIeUyXQH4Lv k+rZETIpSAisyDorTFZ3rvbESIfUsFPHbsas2LeGXSgzytb4R5SzbG+CHAFib2QZRdmQ W+I9ihQz5PAMCIeyIootddZ8itqxv8TTFwsj4f5eDo4JRKfeXjPsbJZflUbwe7jEPA8k OyXNxyPZC8EH5foaujx4x9TnGiPTJFj5tMpsvMoaoPZQRDzj/vBhN9MtmTMVlTbmFL/m 2TOA== X-Gm-Message-State: AOJu0YyOgwAXwwpwUQ/s4YpZMu+4JAVzlwWQv56BXrSJwX3+K1tAJgst Te6jaumfuKl32G+dRxxwqBWCjtTlNQd5UH/i0pc8d5nz7EXTbUoLLYxbU0GbFX2Pyn3REeZvQI3 /AqcLJtULa/345VyyxiAQOQaryLgeZe/F7IFBtCSGOFgvn2C9 X-Received: by 2002:a05:6512:3d09:b0:536:9f02:17b4 with SMTP id 2adb3069b0e04-53d65e1abb3mr12338927e87.40.1730984008587; Thu, 07 Nov 2024 04:53:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IH9gmuDqgRTc9sMlboo7K/7iSaqGblN8sir2R0TWjctrF4ERVZHkAD+82IUmNT3lixi28Ii5A== X-Received: by 2002:a05:6512:3d09:b0:536:9f02:17b4 with SMTP id 2adb3069b0e04-53d65e1abb3mr12338902e87.40.1730984008117; Thu, 07 Nov 2024 04:53:28 -0800 (PST) Received: from ?IPV6:2003:cb:c708:7900:b88e:c72a:abbd:d3d9? (p200300cbc7087900b88ec72aabbdd3d9.dip0.t-ipconnect.de. [2003:cb:c708:7900:b88e:c72a:abbd:d3d9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432b053069fsm23640725e9.4.2024.11.07.04.53.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Nov 2024 04:53:27 -0800 (PST) Message-ID: <00d84e12-4c14-4a6b-a5cd-83d81ac90855@redhat.com> Date: Thu, 7 Nov 2024 13:53:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: fix a possible null pointer dereference in setup_zone_pageset() To: Qiu-ji Chen , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, stable@vger.kernel.org References: <20241107124116.579108-1-chenqiuji666@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241107124116.579108-1-chenqiuji666@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: M2XsBVrEXruyb7x5VfvUbsHGkpBgs2rDGt-VAPptgeU_1730984009 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Stat-Signature: r4a9sc7dmbofin5kom3a8mms3twgr4bh X-Rspamd-Queue-Id: 41AF1140016 X-Rspam-User: X-HE-Tag: 1730983985-562485 X-HE-Meta: U2FsdGVkX182INt0SOWML2UwZMozguKd6Oye7KDUHhS8Ee2AWo4RYEQwkhUXyiF3vsXOeXkD2A3WqrED/BJE3PtJjot5trcwNYGcg/XkJVBUBgw24frSwKz+HewWXeEuP0rnAcTrEVWvrsFGvHBmo97Zpz41GfWr0FhxFO/+yWwn94K1TRhmRmPSVup5RuQ3nILNSj91qlpGVKUFPcBGYwoz5RnZ+jlIeJGEEqT0OLZO5dhr53us0rO7d1d3+x0ogmn3JO9ORvtAhBV/No7gXIQBpBXtgYzgKwR8U/GWqH6chC/7OYKBRgY9MP3HZacFmad2pV+Lv5830fXQKrLhV+Kjm7wIqRP74gRSE5XWU6nIBjyr9cufXVF7K6Uuol5Ilb+NeBbI6wOWB7AHtoSVZXdf4kqUrXuoXCoJLErdGivG8gXPqb6WrCoMuItI3OozcQL/fv9qQ5+OlfCGhJ0cUj7uSiLxegOGFpzyGyvnPil0qiovHXr7PPSqVVyk2AoUHF8SG8OgWLT8xjF2jg8HYOCLLT3eEQ3mY/ywpNEaPqro2o8SfnWVaXEaYSZ0z+I06wDyRNPGyetI/udnvfM9DXSb7POSNxDr5cb5LvrUDGNT2JG4EraeNWMaNraxDY/53OFU+M+dZySsTDecSZB/XoN5WWThy38JDgHHOzwHa/Muk3yWFbNYrL9sffkXh/+Y0HV8gfIlD63XuqYRGDkC/xH/R8miiknth0W0rubES+Ay+s7aXvRnsmMwb7tClB2hu4g4aMEIN/VOXA7C+kNARznoZaeCtbeZrNqMsK4FOXbZUg/M7jC4j6Nq1WTKfGVn6uVaRVcj8m3ip7sOUi83oSuAeZ8vzsz4YxockOwc//x/mM1OsGmUnzwfRG6Ftxpq6kfNWEwKJPecPNry9+0LCX58p3xbYC0GWliBpm2xdYNLPdZm4eHUHVmcyU+66q5QHsHo6TNa+g8yAfJ/6xG elqlwawT RWF0lOmrL42ftQ9v6cTr95oaCCSFyCLV9KziojbFkqp/CEgi6Nz991w8w5e2U7TlJlEHRS9j8QGygg8gC3R/nn09/dw6JVuLpN2Nqk0iNVeCY+AHzKRt+HUvfoOlzglin6tl4TFxOqyx9phII7QFLJr2h3suY39H0VyyV87YOLXdDyFlsVyE+z0TLvgHoUQR+IjJjD3T/sw0gnJ7SRgMT5XkhzLT2FIibiLNBCEnwPSLllGLljOfksPdK3bF4oIhIGF+LbaNm1K58SMR979bGu/HFA9tMEoqvP9H/uQSjxV85nVLpCFSam/YBj8mBxYFWr9RAlamMauiJTnWmVUrNm644WdSs5UlhPc2L5hWQ+AfWzexme1q9kGEbeb1DrcsnIJ8JsUeKDexIdy4IlUUG1B4xpqnAc6pJSV4dAGqK86HbJWix7Gqrz+G1cNNL2LRLc0mKTUzaegg69MAm/bqTuwEBfMmJRoBhvCFi+eWsoN6nsnw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.11.24 13:41, Qiu-ji Chen wrote: > The function call alloc_percpu() returns a pointer to the memory address, > but it hasn't been checked. Our static analysis tool indicates that null > pointer dereference may exist in pointer zone->per_cpu_pageset. It is > always safe to judge the null pointer before use. > > Signed-off-by: Qiu-ji Chen > Cc: stable@vger.kernel.org > Fixes: 9420f89db2dd ("mm: move most of core MM initialization to mm/mm_init.c") > --- > V2: > Fixed the incorrect code logic. > Thanks David Hildenbrand for helpful suggestion. > --- > mm/page_alloc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 8afab64814dc..7c8a74fd02d6 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5703,8 +5703,14 @@ void __meminit setup_zone_pageset(struct zone *zone) > /* Size may be 0 on !SMP && !NUMA */ > if (sizeof(struct per_cpu_zonestat) > 0) > zone->per_cpu_zonestats = alloc_percpu(struct per_cpu_zonestat); > + if (!zone->per_cpu_zonestats) > + return; > > zone->per_cpu_pageset = alloc_percpu(struct per_cpu_pages); > + if (!zone->per_cpu_pageset) { > + free_percpu(zone->per_cpu_zonestats); > + return; > + } > for_each_possible_cpu(cpu) { > struct per_cpu_pages *pcp; > struct per_cpu_zonestat *pzstats; Unmodified patch, likely not what you wanted to send? -- Cheers, David / dhildenb