From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3734DC0218D for ; Tue, 28 Jan 2025 06:48:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8745280208; Tue, 28 Jan 2025 01:48:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A3734280202; Tue, 28 Jan 2025 01:48:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88974280208; Tue, 28 Jan 2025 01:48:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 63F39280202 for ; Tue, 28 Jan 2025 01:48:17 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 14758120C04 for ; Tue, 28 Jan 2025 06:48:17 +0000 (UTC) X-FDA: 83055931434.11.1979ADB Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf25.hostedemail.com (Postfix) with ESMTP id BF213A000E for ; Tue, 28 Jan 2025 06:48:12 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=MrDvLZFu; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=MLOqSw2T; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf25.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1738046892; a=rsa-sha256; cv=pass; b=G4Ps13w1D4NAOW4DY+7LUnFWA1LmC2IxbVg4nmMje9VgzFRv/IJ8f2GZ3IQWmQFcRenf4R W6wpy3RTFYgx6lnWMh2pPXaBcjwDU2G0LAUeK2J52Zd/W81Jav1/qtcHj4I388HIdQi+6K GoBGHTSimQ9pYDWv6gSnenJ3dHUfjoA= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=MrDvLZFu; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=MLOqSw2T; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf25.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738046892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AWIEHtGGZ4u9xHdS6nzBP1hStN7y4CJCMsxYjGkVgZg=; b=AR0RiIX6tD3UNUvOzdabmSxeX7uYVudgPFp0jIsuOu7tGrkaH3GlC3pm/KzFuhsXbF8yhy QzBYUfpRlwHnKC8sIazQM2qgthIiaBVfESDeKywC5/miGX69kb7LIP6xEpgvcJGrc8bYyV NGpMXkVfk2kvjy4q0z3nEj6zoN5fbNs= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50S6H4pD029835; Tue, 28 Jan 2025 06:48:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=AWIEHtGGZ4u9xHdS6n zBP1hStN7y4CJCMsxYjGkVgZg=; b=MrDvLZFu1jTbQfjxrLmLBUIkgR8JP0ZQgb Tg3EM9Ocn9FLDepp0hODpryVU18PI+glpBkbWL4GRKu6fF7+qOWat1kQ7+BmrbKo qXsevg81ltCLd9yoz4esCPCUxO0U+DuhDTXHcUEupBp5bz1WsE/K498HcLMjlHfX 6VAhd4SXdslHfBxjCAaKMEkEoYne1tGQm72QM5dqBYPq2KO96aeOK4iYrGR3YtDF fRojFQ2yB+52d+I+MGxSQzUr8HmpfKvpcCXbp3YIwclChbeNMaYacgj/8gTV3QLx QBJcRApFlYpMEA4KWhRjWzpWSj3lAwSrjc5px3RbJywZoezZHD6w== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44esu00145-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Jan 2025 06:48:10 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50S581Wx035852; Tue, 28 Jan 2025 06:38:40 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2040.outbound.protection.outlook.com [104.47.70.40]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 44cpde0ekw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Jan 2025 06:38:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=A7fDYwWmpvFxqTCyfAbA/74bFdQyqOKVX9+0JOxY69ZtXM18PusaDBzwGbCgAg9/s0sC9ucK2Itf6Po0XlGmD/MWylv6dj4ykoZi7tOvK8ZWAWzRR4w5CNGWDYNdeyAdW6rotniPil4/r/6kStPU0XpSTySpnJ0zQnwNEsXyIPau5CX/paqNFlV3rOi9scWeAHsnrmdcrMAEXjmP+15RHKmNKfiFVhF6t56uL0l41+R1iSdg4lQjtlBbNPof2LzahROgK2ZVvKYc6SXnBCM/dfb5+sYrDLmUAC4pIDHQeJzr0q4LlW+gNmYCNOl0uv02/oQEoVrV56C9S2DsO756XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AWIEHtGGZ4u9xHdS6nzBP1hStN7y4CJCMsxYjGkVgZg=; b=raqF0O4uJe96zrAANes1G77MW0UnwUQXNvcgXGK76ZvYMxP5jqbzCt0UMISDK33faKgHjIJsK6mvzMIliAmIIdFlRsCl6wgHzrqYj73nGz6TbHk8ZYNB2qvVsOMtrAHtYWRbnyAs+0rL9O2Ud27xoMGst8KHQsyGhlGI0lP6BoCqYkV/XzMFRl3t0P3HulMxzENNDAEmxNohEppI9gvK0XczzWC5HZzz8XP+9X4X87hEDL+aXKogRmBg2PjygkyW3JZLkFF7NK/Q6WrISO3PCdBuwsTxxe4+Qo55TbxVw1imZi4EOS6DRW5vXs23qkVI96tGFi7TBqopcQBzt0OK4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AWIEHtGGZ4u9xHdS6nzBP1hStN7y4CJCMsxYjGkVgZg=; b=MLOqSw2T7uWDUycRf2cl1eKYnMXM/ONTBVAl9DJ0CKIoVu8qClXxGdkaLb6LmERmLPAvnA0Bvg445L0TJ+CLdyAcxsXongW6pWMske+vo9prvk+jvwVXvIJ75dYiOFxcFgTw6lV7el/ARBRWd0IpSAm4NXSNMNxpE+mO1p3rQqM= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by DS0PR10MB7343.namprd10.prod.outlook.com (2603:10b6:8:fd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.22; Tue, 28 Jan 2025 06:38:26 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8377.021; Tue, 28 Jan 2025 06:38:26 +0000 Date: Tue, 28 Jan 2025 06:38:23 +0000 From: Lorenzo Stoakes To: Wei Yang Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH 0/2] vma: fix unmapped_area() Message-ID: <00ce9f77-1c02-4b28-8007-fe34efab7db4@lucifer.local> References: <20250127075527.16614-1-richard.weiyang@gmail.com> <2b7d4b72-5628-44d7-8e6c-2c8945b805d6@lucifer.local> <20250128015619.w3rl2dcbdg2f43xd@master> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250128015619.w3rl2dcbdg2f43xd@master> X-ClientProxiedBy: LO4P123CA0321.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::20) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|DS0PR10MB7343:EE_ X-MS-Office365-Filtering-Correlation-Id: bb0b468c-e899-4a0d-bdf6-08dd3f665eae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?EtHUzbmFyIdRx4RiBwjTlbVM7eVNJlG56Fkct2SmKXTpBpD4q4BukhcXi47y?= =?us-ascii?Q?H0vBdyJE5v9cwOkT2TndBlXst72VQFaiiABiunWSS6u3+zToCutnc06Pd0yQ?= =?us-ascii?Q?Saa0Nl0mUbUmMWevdFO9o0CyMKDc/bKfQq2Yosw8ZdRxYG1p/do3BJDDzDSW?= =?us-ascii?Q?9y7+AZoRP6LkDTvC6gcX+wV3lBO8Zi04X97ExqaTjMhCundB4pXEz/IJUg9t?= =?us-ascii?Q?0w5WEw/CMrm2Japid0slEj7C8heOOkFKIl5ZbDPh2xtkamGMOeCZbKQUWZqu?= =?us-ascii?Q?fjRLlURk0QUU4Twmh4W99UzPvE/TYdja2V6xA05HL+MzKz5e7ocWMbqZAYSt?= =?us-ascii?Q?XKk8c9WfD6U2h//AXspw3keMP8CaSHAnBPaJqsv4ViWiWg3UDVzp2BHGnbCi?= =?us-ascii?Q?0kf4TH2DFQ1ysMzTMOrkbKuul7U+UPffb5MvQMi0MotBgwhrsj1HttEyfTHZ?= =?us-ascii?Q?MjgoEgIJh+8BJr7s1MYGGuttLjAkR71QFv156dLHseVf2JoeEoU05bokFDHm?= =?us-ascii?Q?U0UEcg+NyxbsvFMfGYBZOJXGrney+0gMXZwuUYsC0FsMF5liCY70AjSFhmY+?= =?us-ascii?Q?kQKdZLJb9rgz0YIZuyuyg62KnvczFTyZukz91ZuRJD/PInXTusWFM00pDAwZ?= =?us-ascii?Q?GFwg1CFGsD0kNeKwBoTi7z51Md1PAzd3oI1C1FQDrmW2M2/Hl0YW4T7WmknI?= =?us-ascii?Q?3lM9BT1t7U/e5VRtMWdQsDVn2bdsFfXEHLYcOFKp41MKdRDw4Kf5bpRK+tu4?= =?us-ascii?Q?cnmfwdrrtVX9XUGs/+SjQ/OxDiTBvaO2cyVyLF7/wZt8BIrY8QwdITcwf+/t?= =?us-ascii?Q?QL3YG9fQ5zcuwscZ2J7ToztUexMsq4WicrNbxC9q+yWGzHGJCC7MibQFjQLf?= =?us-ascii?Q?AOs6lQD98saCsn+9KeyblAbEacWpnY3Qguar8iWIEonkMZMSnkugIAesvi7W?= =?us-ascii?Q?317rnoUrZ0MXgSlHwerFXyCzZlsNijCzgxupuZA0XFGK527dlAKIxH+gRM6C?= =?us-ascii?Q?1sF5EnjxW8l0wWmZN+jpM7IH4RXuBP8UnZsGBVZzLRWqSgwm95tIGyKYVTZW?= =?us-ascii?Q?Iq6f+Od7wGxOxa+9MjiYRgr01HhPcg2cCI1E030+hZ6hPRq+D9pLqXRRmGOX?= =?us-ascii?Q?2mz2QxvmdjYEeNrEfBOud6T45GLOa3v5IVFu5CqWDQkT1L9PcCxAXj+76omC?= =?us-ascii?Q?OQnSODsESsp7bMZrZcOHOCIMlHp4fLVCB1wya/55RIUJ0xfAuW97ZdipPly5?= =?us-ascii?Q?bshveKGWMyvV2nFWl5IdfQSs+KeRLm+nfHCgaJT3rG97QVQE/leTTydjaKFG?= =?us-ascii?Q?uzKgK/1RTuE/MX4AAmEwplxqbELuzEbcnz9h0i/jGk/l1ueQTejdaqiQqlT0?= =?us-ascii?Q?vuLir9ipYSu6kT8/brlT7+QuFgqe?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7+UUmPjrg+7sWuaQh0wMQt75sxwFWtE0/syV7iTF/aaJXzPS1dkr4372CPNF?= =?us-ascii?Q?95k1/6he+euco/2TyBfQiCw/uuXO2LhccfJ9DySOHB7ulAv9+nHT6IYRD+m5?= =?us-ascii?Q?Gb8MDdHan1iU6iCA3yCykgtdss973cHnhN+NA/36/HQ88713eaSqCsD9jeG0?= =?us-ascii?Q?doagUnHCBjjsk5A9w4IXFzBtXNHjr5DCG37+i26HyN6jpyK/61U66rluILYW?= =?us-ascii?Q?nOha8Hm1TZ4MMfRAAwEwXw42gCpmA9PwUGCg0sh9GHjKlL+jyBzzNWAfI/FL?= =?us-ascii?Q?eoAjrDhSLF3M7nRBi0dAbOGajsZMvWaVzb/YwXrYVnYlvOYAApBD/9jo3aLc?= =?us-ascii?Q?cxcnOcYfxNwkSoOB6vZCU3m0PkmGsFVljoLV/8LVL6/rD6yczkoxB8gITXRp?= =?us-ascii?Q?5DsHC5wQiff72KFol6czUrAwpTEI8LXDyFrf2OciAhfamURNrfjLyF9gCvei?= =?us-ascii?Q?GgwXXUJN/WPFy17xCGbEYjlmr2NRtl1S4wxX/2MRijue1lhpz5kXj3c36mhl?= =?us-ascii?Q?IjmBQVIaWMRm2Up0PzxEFitcv9Z0iRH+haf+2fokMCof4c+aSz1mY5lnDFHW?= =?us-ascii?Q?yLkmPpvcwJOic4bm33pV6zcA7QtscnLeLrBLsLLZpWInQc30t+HnA6HEFqHT?= =?us-ascii?Q?HVx2lqUQmezTxZySL8/8j9heHDGLMq2KJ5gT8YxwhSFAPOdFhuYcHuSV1MXB?= =?us-ascii?Q?auVqPHWINB+mKAljhYXAF7gtv58eDegA4+Znlztfa1PMYDyg/cD4oHtYXVS/?= =?us-ascii?Q?wyf9L0HbcXv3dCPGWcE4ugbad6Q63utR582L8ks4Ynq3YZkZCmk0V6C8O+Xh?= =?us-ascii?Q?mP7KNNt6qmyuu1vIdCPvG1mVEYLpfV+n9L2C5wMz5rQiJa9XO4bkUU7a9aJ8?= =?us-ascii?Q?xGLNecZq379+nTvC+4G9ZuRlOYyMr0060JEIZ8/uEHaeLNP5XPZEuMx8wGUG?= =?us-ascii?Q?Sv7kxNczqHfOCyrQugT3P7DLs5bpdJ6c9sziEuZFDGCMdMMCG1drzxesvMcJ?= =?us-ascii?Q?LPcqZ4F1+539iur3T7KOjQ50NaIZp8a9ZaA7oadqVgBIjy33BZww7EacZ5Sw?= =?us-ascii?Q?NZVA4P5yUO0mGo+MjNjwT5nnW4A9SzIu2D9L1DqydvfdSiKrj45gr3D9E/WG?= =?us-ascii?Q?8BPDm3SDxx5uefRaroNEz2X1uWu8TocdD/4ZPbVx072eQOly4HmKzrBOMDwX?= =?us-ascii?Q?FsOhncGVPshAM928ou2rqEXcmtU6Hr4nQH5/A0sA4A7p7XZori0E9eq+LBGZ?= =?us-ascii?Q?s+kSsd0i9V/LyJXN42VGG5SP5Rsr6Wz6RW0Y4Jh+9GJ0PS135DWhs7pa/b8m?= =?us-ascii?Q?LDI+bhWO2Z+rYmnDAHidCNVyM5WQzBPvGMRJuaeB/bVtFpe08DGZ3yMOJYeZ?= =?us-ascii?Q?lTU9t+Mo51YgX63VrPcaub4ehn+YqysOz8a+L6ISAzAPooL3ujP9GGc2y6mC?= =?us-ascii?Q?wToUE3w5KvN1Pqrx6rM8gsSyFRF87S87iEAmFKPYy1X1dWmhlrMQcsJ2BjJs?= =?us-ascii?Q?V5rwRYFj5uA9SUdMhNA+tkmP0rZ8Qtjrt1zAL+3C9lO1DF9aYG2wmTeXRdY8?= =?us-ascii?Q?ipQQmLRQ5VhfUElngtnS2lzt09w2Fhr/xE7Mwnhmwri/dVnC2jSPCxQSDruU?= =?us-ascii?Q?aw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 9/mRDvDMa8RQrkBsaYgK5xGG7QGQ/ubU4Rm3Kd/IojCKy/pGQ5PD0Frk2gY8ABu7HO/cdqVOrhbmT7J6UHLsFgQIASxCkbXPrYsuCG9DiLiA9LYxB0ACCI9sgYoZnNoPyJyTn8MIRm7SVCBh4nQiCo5bbteSynNZMaALpvnpRu0F0EaaNp+HelLXOODF2NzKdROV323LUipfDVrGksA/KSrwDARaTrIx9DNb2XGK5uQWGqijtj0sNRHLJDPbwCMWGorfw77AI5RboEfbSpezQ0ofjsdncsPmrIaJHUbSGIIQOkKoj21EjQ1kmJX0Dvy23ruvS1eqDvXlpYL5/zJ9y2fy4qMnmPHREgYVGxXpCd46QQX7e+mb3PdTV0XUQrSIaCoANQZfiVt9vNJrWAMrln0ieMBXxc2ns+cBxQ/peFoucAY9eNqiJSFIZv7zcyNPADYprTom7bh3hYIFNUPd2Wd2w3d2QY88KEQRklBGuyw+Gk4m6mcb1sOWmES1qNpR9JHcHmxSb1qIKipQ7i4dYMsU531UGbEnNUkM5WEu7N9f0OfKtqn+zhiD2KQpe0uSsEmQZJpv053apwhtK1TWfjLIO0DEDZxaVzHJAhfXRbk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb0b468c-e899-4a0d-bdf6-08dd3f665eae X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2025 06:38:26.6253 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PckgMyNjpk4Ow+6hts/60BW02zdS6m2yCD1zZKvP+ac3e5tzEWfyze5N08yPphfHae4Q7bOxBgeBaaoJpViag6qT7Z2e2EHbLfoUXMg83Xk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7343 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-28_02,2025-01-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0 phishscore=0 suspectscore=0 adultscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501280049 X-Proofpoint-GUID: i5xMbTl-UUaQxc8vyPwuAjlUeDG3ljYB X-Proofpoint-ORIG-GUID: i5xMbTl-UUaQxc8vyPwuAjlUeDG3ljYB X-Rspam-User: X-Rspamd-Queue-Id: BF213A000E X-Rspamd-Server: rspam10 X-Stat-Signature: ubxt5yrshohgcm3xk35xxof7niwbj38o X-HE-Tag: 1738046892-778674 X-HE-Meta: U2FsdGVkX18aXV8Og0QlIVujxWS/uRpnRztV8e8e96ZhFP5cwsdK2MDrYDPiPDgRFOKPWGLiwEVBU7FP723C9oJjqK6Jvvl5KSycSYN9TmFjTCPRJbR9Mn3dyE+IHscrteq7H66K36Vk4NJh2xwavNIB0+WxKhbgpG9tMvOiCcHgs+hrtPcro07QJLOQdS8vzW1VgxdMYzBpUc4nWCQYps0svd+zuJnsrsoueseo1AbcbnNDZfxh8FfsglRtcqB8BBL3t7KQwKJ98nAnfEB3GoFXMZUmHPbzKs/nJmdic6gKSdQW7Jgc5hphijXBxE2G6bhQdX/0SaWwJ756Uv0e0Uu6Q/NS2qZ646GDK/feAyKTI0/Emvl1U0GZU+sBKBcKai2HMbKcnTMGcAp321RIMrz7IxJcXqpJ9HyZVOGZ17QuWF4RRt5wJ0fXvSwn4cq2m23Jj2MeQdA/JgmHkp8Rhpq/kRk6ocyX9DyH6fITJLucSr3/W63Pp/ghS//4F0LA7Vy4+TMuYIbCQiquMuXsI8Z+v+PypQIKPZK0vj1dwC8LbA+Myzq9PJcXbHPF1k0czjSTMPgsaC9NNRwMerbbV9TIg2A9etwfjh+LukMJ1cQUCs/z2qYIxH0lgGFirzbZawWvYxTHoMiwKmauhK6y39O0O9UyEUxI322BHa0zOx7g4HfMcDP9sIXUPLpnEaYTBb/C/OVCVJ5rv/JGG7XWOV0yC1jYeYN3V+NxnCzIi8sv2G1fPd86iSEXv/ZUlI8nHj9yZk4srZUeJLUuUFOeOBnqzTtb5NZumQ3TDcm8PfiQo4W0ffEzS9MYpZYbdVsf4nnRo4kG1mPZ7fIu+5FMFXB3TdGXlHWo/Ct1VeXOLBOv0oyAThwe1NrXZy3YxfvqMsCbzaeV+axVlAVDyo9tBO67oDxLggxxCE3B9d1r5gAiLLXs/Vyoc2O7aICXPInRxx+TlG9bQ/7gR9JA+H0 kQDUVTbz ZOl0SbKwtLhuWMA+l29lrXqZ7OI0F9AIGOolOucuGvKvwz2RBmY5Q8CqXMCwTaM51hhX8cgRmbf7fTPtiFwYkXeVq0GNxOoBqHkr8sncWOuyT/eLksyRarDfX7YD5d528HOR/ZeYvwSr51z7/ozq5sCU4/60ov+ZWRHU/z4jZ2OEvOzJTnNxO7tsuo6BluGuIrkz6JHFeVFcYrSGYO5cXzlM2FzEs0b66jqTBVdxP3l6mrlpGDKS+OnVQ8fOFGCR9j+9cbcgFVvLlSSWjlv0gRuOTt+BHqj07mQg+6CVvV67VxQyM7SOSYaejQQ9ZSAIcuh/H3k2HL98cBDinTi9aAIrY0SLITkO1jQiJXmxI/z2BuuCncNF8vtvCEM30Rfi85ZL0K6ZPvWiJppSLl2hCCMv65jdbhQRveGDgmowCzbSprn4sp+lUtbWlbAJ8ISQ50mAv9u2qv4sx259Zpr/BJ1ipW/oEWxKfpgOnQB5OFFNxCLZqwj0vGAGOSuUFSqWyKzcQDOgDWLVFaGbH7W+/Hcn/KfwPwYbGszPPF9fOOP/IqH6nC6EV10URiMnCyiHpl3GYf3vdQ5EEEJTL3BdOHMmfTLK0pvi3P+7GAuHTVbb+grcNiSqxKBzC3KdKmSyTIoIKSO7qv8mVGqsKYOBbpujawLB+eBGXSr9C X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 28, 2025 at 01:56:19AM +0000, Wei Yang wrote: > On Mon, Jan 27, 2025 at 10:50:17AM +0000, Lorenzo Stoakes wrote: > >Hi Wei, > > > >I seem to recall us having a very recent converation about holding off on > >patches like these for a little while to which you agreed, and then you > >sent this pretty much the very next day? And during the merge window? > >Honestly not _hugely_ impressed with that. > > > > Yes I remember your suggestion. I send this because it is a bug fix to me. > Per my understanding on your word, it is ok to send a fix. This is not a bug. A bug is something that breaks the kernel. Having to use a different gap in the vastness of virtual address space is not a bug. This is you misunderstanding unmapped_area() as a function that for some reason in your view must function identically in being minimally conservative whether top-down or bottom-up including scenarios in which start_gap is an impossible value. As far as I can tell the function is behaving completely correctly, it is just conservative in accounting for worst-case alignment and front and rear gaps of appropriate size. You could have more civilly tested out this theory, rather than wasting presumably a LOT of your time on this (meanwhile taking -no- time to write commit messages), simply asking Liam about it on-list. Communication is key. > > If I misunderstand, I apologize. > > >In my view this patch should have instead started as a query to Liam about > >the gap calculation, this would have been far more civil and would have > >allowed us to determine for sure if the approach you've taken here is > >valid. > > > > You are right. I will try to be better next time. > > As you mentioned a query before sending a patch, this is preferred, right? > Hope I don't mess this again. > > >Given your history of sending entirely trivial patches which we keep asking > >you not to send (mixed in with the occasional actually useful patch) it is > >KEY to communicate to ensure we're on the same page. > > > >If you send meaningful commits, we want to merge them. Arbitrarily sending > >something like this, at this point in time, when you've been asked not to - > >does not help achieve this aim. > > > > Thanks, I would be more considerate next time. > > >On Mon, Jan 27, 2025 at 07:55:25AM +0000, Wei Yang wrote: > >> The gap check in unmapped_area() seems not correct. > >> > >> Add test cases to verify the behavior. > > > >This is an -entirely- unacceptable cover letter. It's two lines dude. Give > >some details. You're actually tackling a very, very specific aspect and > >scenario in some of the most sensitive code in all of mm. > > > >You really, really need to be clear on what it is you're doing, why, what > >workload you were doing to hit this, what testing you've done, what real > >life things this interacts with etc. etc. > > > >It makes our lives easier as maintainers. Right now I see this as 'another > >trivial Wei patch', you need to provide details to prove otherwise, if that > >is indeed, not the case. > > > >Also your subject line here is horrible - 'fix unmapped_area()' - actually > >you seem to be (in your view) correcting the calculation with respect to > >upward-growing stacks. Correct me if I'm wrong. I mean even your patch 1/2 > >has a better message... It needs to be more specific to what you're doing. > > > > Thanks to you and Liam. I will try to do better to not waste your time. > > >> > >> Wei Yang (2): > >> mm/vma: fix gap check for unmapped_area with VM_GROWSDOWN > >> tools: testing: add unmapped_area() tests > >> > >> mm/vma.c | 2 +- > >> tools/testing/vma/vma.c | 177 +++++++++++++++++++++++++++++++ > >> tools/testing/vma/vma_internal.h | 2 +- > >> 3 files changed, 179 insertions(+), 2 deletions(-) > >> > >> -- > >> 2.34.1 > >> > >> > > -- > Wei Yang > Help you, Help me >