From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50CC3C28B2E for ; Tue, 11 Mar 2025 09:51:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA3DF280002; Tue, 11 Mar 2025 05:51:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2C9E280001; Tue, 11 Mar 2025 05:51:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA6C6280002; Tue, 11 Mar 2025 05:51:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A876D280001 for ; Tue, 11 Mar 2025 05:51:39 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 04971BA4A0 for ; Tue, 11 Mar 2025 09:51:40 +0000 (UTC) X-FDA: 83208803202.03.E0916B4 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf28.hostedemail.com (Postfix) with ESMTP id 466ACC0013 for ; Tue, 11 Mar 2025 09:51:38 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741686698; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TXe9cbUYFeC65CpiPW8ygfFJBJxG9GIKJZYmsp9BJvQ=; b=lLLuZ+bJ37BW3A0k0FSH8316g1rCMYB7KlftXmVJdnVBxvf0N+JsKdSCsz+SHPN9gBARey nKDuyEGfdLcXhTU+tNzzAXL9WNshL84D3QGIlrpXgvrqs5Y+x2OK0LmggnyzBFU4u5xFug 8cjrh2GB8FbFYYqGt6cjw1oVpmsezew= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741686698; a=rsa-sha256; cv=none; b=j4Ij3Rt2tVQzWzp3yEIkE0hm7RSNtiVnEWWKML4EwmggqMq4R6WF1wuc8iRV2ET+5naDNE 6UkW5rEj8FuGmLEyngG2grQH4Bl55od7Ce/2JpFttLdpphhcSxRhlaKazWymvzDfbrelzR s2qcK9aHZaqjDvHnqLORReR843blarg= Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ZBpqJ0FnGz6H8Y6; Tue, 11 Mar 2025 17:48:28 +0800 (CST) Received: from frapeml500005.china.huawei.com (unknown [7.182.85.13]) by mail.maildlp.com (Postfix) with ESMTPS id 985221404FC; Tue, 11 Mar 2025 17:51:34 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml500005.china.huawei.com (7.182.85.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 11 Mar 2025 10:51:34 +0100 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Tue, 11 Mar 2025 10:51:34 +0100 From: Shiju Jose To: Alison Schofield CC: "linux-cxl@vger.kernel.org" , "dan.j.williams@intel.com" , "dave@stgolabs.net" , Jonathan Cameron , "dave.jiang@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "linux-edac@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "bp@alien8.de" , "tony.luck@intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , "wbs@os.amperecomputing.com" , "nifan.cxl@gmail.com" , tanxiaofei , "Zengtao (B)" , Roberto Sassu , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm Subject: RE: [PATCH 1/8] cxl: Add helper function to retrieve a feature entry Thread-Topic: [PATCH 1/8] cxl: Add helper function to retrieve a feature entry Thread-Index: AQHbiWhwo9sEMJAQkEWXFE66V5STnbNoCC6AgASyHwCAABgagIAA7UaA Date: Tue, 11 Mar 2025 09:51:34 +0000 Message-ID: <00c0910dab404d8ab72db1e8a6e1b190@huawei.com> References: <20250227223816.2036-1-shiju.jose@huawei.com> <20250227223816.2036-2-shiju.jose@huawei.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.195.245.214] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 466ACC0013 X-Rspamd-Server: rspam03 X-Stat-Signature: r95cfy3ufbt3inwj6tww6hw5fc9fwb4i X-HE-Tag: 1741686698-377930 X-HE-Meta: U2FsdGVkX19xEnpLamWTICWI7cS/aEfrkZy4yhdBYkIAsIeo6U4Ik4VWmI17pDd31+fK8MUoqW4DUYijuQ+iWOf95dQhtsyvfMiX1MLKT5b8QSRW4zJ+Iqmol0SXl8XjDIcCKPgCg2FNKds87wp5xuz5YYmgGQebUqjHNbFRsVzkqh/vQ4mrjKLLGZAFrzK0DY8/jfPUcjSTv0vBaXzqXMnOiXN4XAIVQWIV1sJrzDbB3viEa1c3iCxeYHBfqffZU5ddDMJ3EJwIkS/1u1kNH7MkM4PB77QIiWRKVZJ6K8TEDcJgOW8K0uo7+kzbra1oiZPH0sOljBv/lbOGOc5tmXKMiROWv58X7jcT6QKcKk/qIAvjBmsaAKXOqa1BbN0EOW/ogfriNg/DjxhRTVJef+tIBZYmIelfDccNtWkWaduuydgurqtqGXEk7Qv6wiRj9dpb7GFmGw1Iy149rAMZGf1eAmhjXRI3IimdLDw1nHYtavkeVtOLatfZ5/gisLEmi9g4phK0gnboxsvovb1VH0NNla5fW+7W++qtnre1Ar/cy738ArSMD21FJmGmJz+uGEp9HDXcQLjnleRCJPvIMB0MJ5oFScMccCUkoiUgoYZ8dDbVybYdzqXM7uFtEQIVxXUnnc7SndfluLrpvI/PZ+HtUbMAwclwzGwFWKMyhW9PNM/6wewSb0JNmAKJ/msySvUkD8EmFGMDGlmL8pPvf+0fkISIdtlcV53mbkEry4uOr7D9tPX/WY6LXTNaY8vwk9lezAuMQsgziJsOpuOxcQBam4V2L4oPjkiGP+0uyVQiLXylRBe9XK3DBdlxEzJ4vWj7NlZA7nzHCt3B4/6gyJVSasYfeCbqA9A9GjvjnPzD5hbkyICE7QF+j6RC+MO041AibC0lKxdLt1yAWIneoEiI2n83n9lLndIb7mpHzZISsYIyWNya79GRsW8jFCCSjJ/KSh7VtriY4i3GLmz XSVRsoMl WfvBjjrAtltUabIkmBK7Bdvqp1u4xPzO+pcq/j/+sVsP5LDWyV0wG0uuGntF5LOgbQS8JAZEuuQLbd/mwurdeXySexrQ1GzL1IM0Vtiwqpt3GK+WHdqOzxRYN1BOmOCV7eMqoKRyWQgLVTHGrPLv9TaferHbVJvw9ROUg1aSEsMn8ZKnkJLZ1PTgsIn2p51U1imecpkxvAnjppfqtmOV450YiAvJMBlR4v0xlsx7wDW06qE/TUMq/dbqbckGggnN5UsrGWntcIc6O14TxGYjxUnJwxHh4bEvl+pEH0wfcqwcxHH4ZTwDG3oD4j+VXInGOvIIyPgXRS8MrAh7gHw2RoiTO2R7HAWOQEOfkbHmwtrN+khRT1++6N10mJlNpkZ8f4zf0CL5OtpKncfYQFbaBJOITDh1hVmovzRhvdlWc2d+SC2Nu50bNlITKYx+LZZ6jkEZcCVbPDUJIm/D5pYsybNQ4RxjxMHHPeJOcC4VzpNKrmUy3fHIdcj/VziPdZLVLGypkR4FPO7sc8K4gI2mfDgWq4SfO1mxxWSqpe1Mwx7KgCaPMbLSXrSWPSa13XFDxD1RISKPtpX6qesKeNKPUBQkYMz+kVgMhwjjWbWLgRXBto68tvNBjkFEQtvdnecJgX95VEFOx8yzBYJwZDMGm2kgvA4Z0IrswXZvSp8Kc3HeJwa20AEKE0kdyWSgfziNjrQ2w0ygkPAgIs0m50epWCnk4eYrB+jcqVqMcadfYr7ZL8eDHj5aStj8ONBRgJ4XVBe3HHSqa1hVkWDUi/DGe868khuQd8xVMODxDNSfq2/K2sAJNUNkbkPS9ZSu2wdpolYS7+uHqAtgOqawrLA48T+h7nLIHUeTqgc6RsBHAG8wHKHXHb08Qyta/S13L8prPTV2Z4u/OwIYpiHU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >-----Original Message----- >From: Alison Schofield >Sent: 10 March 2025 20:29 >To: Shiju Jose >Cc: linux-cxl@vger.kernel.org; dan.j.williams@intel.com; dave@stgolabs.net= ; >Jonathan Cameron ; dave.jiang@intel.com; >vishal.l.verma@intel.com; ira.weiny@intel.com; david@redhat.com; >Vilas.Sridharan@amd.com; linux-edac@vger.kernel.org; linux- >acpi@vger.kernel.org; linux-mm@kvack.org; linux-kernel@vger.kernel.org; >bp@alien8.de; tony.luck@intel.com; rafael@kernel.org; lenb@kernel.org; >mchehab@kernel.org; leo.duran@amd.com; Yazen.Ghannam@amd.com; >rientjes@google.com; jiaqiyan@google.com; Jon.Grimm@amd.com; >dave.hansen@linux.intel.com; naoya.horiguchi@nec.com; >james.morse@arm.com; jthoughton@google.com; somasundaram.a@hpe.com; >erdemaktas@google.com; pgonda@google.com; duenwen@google.com; >gthelen@google.com; wschwartz@amperecomputing.com; >dferguson@amperecomputing.com; wbs@os.amperecomputing.com; >nifan.cxl@gmail.com; tanxiaofei ; Zengtao (B) >; Roberto Sassu ; >kangkang.shen@futurewei.com; wanghuiqiang ; >Linuxarm >Subject: Re: [PATCH 1/8] cxl: Add helper function to retrieve a feature en= try > >On Mon, Mar 10, 2025 at 06:15:38PM +0000, Shiju Jose wrote: >> >-----Original Message----- >> >From: Alison Schofield >> >Sent: 07 March 2025 19:20 >> >To: Shiju Jose >> [...] >> >> +struct cxl_feat_entry *cxl_get_feature_entry(struct cxl_dev_state *c= xlds, >> >> + const uuid_t *feat_uuid) { >> >> + struct cxl_features_state *cxlfs =3D to_cxlfs(cxlds); >> >> + struct cxl_feat_entry *feat_entry; >> >> + int count; >> >> + >> >> + /* >> >> + * Retrieve the feature entry from the supported features list, >> >> + * if the feature is supported. >> >> + */ >> >> + feat_entry =3D cxlfs->entries->ent; >> > >> >Do we need some NULL checking here on cxlfs, entries >> >> Hi Alison, >> >> Thanks for the feedbacks. >> We had check on cxlfs before >> https://lore.kernel.org/all/20250122235159.2716036-5-dave.jiang@intel. >> com/ but removed because of the following comment. >> https://lore.kernel.org/all/20250124150150.GZ5556@nvidia.com/ > >Hi Shiju, Hi Alison, > >I have not followed all along, so yeah my questions may be a bit pesky at = this >point. I did see the comment linked above about how the driver must be bou= nd >at this point. I think my question is a bit different. The feedback was added to remove defensive checks present in this function. > >Are each of these guaranteed not to be NULL here: > >to_cxlfs(cxlds) to_cxlfs(cxlds) cannot be NULL if cxl_get_feature_entry() is called after devm_cxl_setup_features(), otherwise will be NULL. =20 >cxlfs->entries >cxlfs->entries->ent Both fields will be NULL if the firmware does not support any features. > >If these cannot be NULL, then all good. > >--Alison > [...] >> Thanks, Shiju