From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40474C36002 for ; Wed, 9 Apr 2025 09:52:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3316128005B; Wed, 9 Apr 2025 05:52:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DE8528005A; Wed, 9 Apr 2025 05:52:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 180A228005B; Wed, 9 Apr 2025 05:52:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EA67528005A for ; Wed, 9 Apr 2025 05:52:51 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0C4301A0325 for ; Wed, 9 Apr 2025 09:52:52 +0000 (UTC) X-FDA: 83314041384.08.EAB29E8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 88DB4A000D for ; Wed, 9 Apr 2025 09:52:49 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ba+CkM54; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744192369; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AgOPvhz1Bm1GCeL39ng6pkGLakXCK+cbKOAvDwFeABA=; b=wRypeTsUt/3TL0chqPIxlnRhSCCcXnnuttUvXlNU1EarN6Kp2Al3/VynaJYaxfVjX9ChWX JTpOnPfuNEWaAbtRbpFXXCDqPWCWfHrOJYvRAKe/vVrU+NzTWSkANKmK1yPm5m+x+ODH9O SIwU0GsEzBv7grX2rKACLol5M1OsHX8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ba+CkM54; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744192369; a=rsa-sha256; cv=none; b=donMS/dUNeBAi/hbw4pGlXRBeDBRJYsozkmMmN3/QPrFCRBsXLjGg7dMr8oKV8SxprVcPr kp70jL90dgS3pUva6L3C4iQUm/PjPS9c9/2hojUOjd7slEupZZa0nCGulE+wjeyIOExKW6 RtDnktzBWb3AvH1XryELde6oyFYLA9s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744192368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AgOPvhz1Bm1GCeL39ng6pkGLakXCK+cbKOAvDwFeABA=; b=Ba+CkM54DNWQS+v5UB6HxHqhrH9RBROZMMjgPZ5PB3f1/kmDDH+2DFwDDnrt9ULBLJOy0O 1A5tJkquzYiwf+GzJjkanHq9z9zQBLX+NSvxphBa33PAGZVVXPuUlVRfdQv6+/6UxL/2tN 0bthhqbxWUtabeP04QSAzQqy4DMksyA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-306-CK0kVMyTN5SFuUZKVxWBKw-1; Wed, 09 Apr 2025 05:52:47 -0400 X-MC-Unique: CK0kVMyTN5SFuUZKVxWBKw-1 X-Mimecast-MFC-AGG-ID: CK0kVMyTN5SFuUZKVxWBKw_1744192366 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-39143311936so2766598f8f.0 for ; Wed, 09 Apr 2025 02:52:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744192366; x=1744797166; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=AgOPvhz1Bm1GCeL39ng6pkGLakXCK+cbKOAvDwFeABA=; b=b/9FZiMOvSghIWF4hsL3DrmSBCpdqdf3rmzjD4LXUskSgFJIdwyEOz9jdxhrqvTuzE yCt1++RO41jLhvjBvrjcoTNeaiBtsKEBqitNyQYc2Z6QKTPo2L+heOWyn5ZeGVnqCK7h KF9vm2k1t6YPOXAf+EZznyU7ICuXblu8/Jjfb/PZFqpjip9Yeb/uKYZN+Yz/usFXiBB+ AM8YvLB+1wOfWCIQPhBYMrfVhY74Yc/Ha7euSjhOZKmSc06BYOjuCr5aWre9t/H+9Ko6 X28dS/2c9TxgUjdpX9LAn2Goj75hnlK0bFANQoi6CEjWf2lH2Mg8NPrk1TfeNdLYEuWH 2VAg== X-Forwarded-Encrypted: i=1; AJvYcCWOU5JrBdcJMBW46QSs0wifFde8Y7LCH02tnGSQ/TK/eZZqYsBpwgi9bLWt+QFxDZ3wZ2q0UehvBg==@kvack.org X-Gm-Message-State: AOJu0Yz0Af4Zu88jBuB9NST07Rdz/MeTUlAGU035SKKlPWEm54smqFpd 3YxIQE3/NcJ59QA1HmQf2X+2/Si24oCt8UX1n51sIbVFQZnQ0kBePjnQXBiiFAWl6Mej1ECxWTI CcX54wK0vJxtNbFz7yxEgFBlSBCMsfD9OkomV8qWqGCtqrgcN X-Gm-Gg: ASbGncsyLlPggaNJxMJxlMns4nO2nUKwLMSiQitSirjCSwgdbiwajtpR84IvxuyyG/3 pJv2d1PIyOWSgfKBHXlIDaFf3niOBvs0If0mwbWNT3hKFQpDIYRYJt4iaaomPtuqxVEO0ZurHlq fUVT1TqMbYUA5k6uxJtxrbQjB3uN5uqX3mN8j8gorRQDrRqMREYH8TnUDGQWwLnAN6r797gKMN4 WSqPQuqT5O/tYCY/rD7qhzHMkW9BLNIG1B4PbObsgnPwTpeuZo3xfnkmOya59Hhm8iWAlpxoKOS obY4CCObhll4U7XAP5bUrQ/JsFjqAB9A/D9mK78EoQ8ZG7Xl7EugobH8fH9LGN7EK8s05uUiVuo jqHc8mFQ/PSS7ipS8iJkQX6vOPirCAVGY3g== X-Received: by 2002:a05:6000:1883:b0:391:13ef:1b1b with SMTP id ffacd0b85a97d-39d87acf243mr2008555f8f.30.1744192365737; Wed, 09 Apr 2025 02:52:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHx9GrICGi81uP1xDkomZUSWBX9fsD54soYQUm/gxbsAhKoxt9FjFNAo72hvshuK7hA7PCmDQ== X-Received: by 2002:a05:6000:1883:b0:391:13ef:1b1b with SMTP id ffacd0b85a97d-39d87acf243mr2008536f8f.30.1744192365381; Wed, 09 Apr 2025 02:52:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:8400:ed9b:a3a:88e5:c6a? (p200300cbc70d8400ed9b0a3a88e50c6a.dip0.t-ipconnect.de. [2003:cb:c70d:8400:ed9b:a3a:88e5:c6a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39d893fdf9asm1112253f8f.84.2025.04.09.02.52.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Apr 2025 02:52:44 -0700 (PDT) Message-ID: <00a37819-b2ae-4399-b21d-86339059c46a@redhat.com> Date: Wed, 9 Apr 2025 11:52:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: fix apply_to_existing_page_range() To: "Kirill A. Shutemov" , Andrew Morton Cc: Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Daniel Axtens References: <20250409094043.1629234-1-kirill.shutemov@linux.intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250409094043.1629234-1-kirill.shutemov@linux.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Q4vbco5ujZRkkiSjSXyhMf4iw1V9avD-wwvezBAe0T4_1744192366 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 88DB4A000D X-Stat-Signature: qgjcyfjt5botofa3ijknfw49kdofziae X-HE-Tag: 1744192369-298996 X-HE-Meta: U2FsdGVkX19ZZIMbayF1ZZZOdL4ky5iMMJ1PHtooNnwth5VNYRhvxxTD1QhbSfDYsBh0b2B8s77Veh/0+k4mKlbK+YObi41VuUiHViW0pUoznXuJoP+xP98oF8mf8htiEEol6nzq8oH+u8exdUYr5MkOHV99YGuGVuYcMJiDSG6DFD5FOlYu31lx35FTk7uwJQg/Xds5CIAYDvuoGs1ukCKVI0R/wadObGXsCWndEsCTwgTmqugJ+1jfpkYoDOhpNbm11NOqr9xhyLPCxaamJWTv4hI25mzgs5GneEVK/Dmoav7ziP/FWCFSNovgXsPFH9x+QdweWTWJavzXFwHIRgdKP9lTKog7xWuM91mgJcsHsngHvGBThwCyK3gmqSTtxgKpUwH7DLo0/rCp6FxYzhNSpZoBlR3+S+/6vc9yEil2aSNWB9SDsXDFGWIAXC4TgtZfEu97+aAv41z3XbLqD8JCas0wOLSSUnDiMsNsQL6DJeQQBBbb+P7YR0L9dsjOXx5vnHmd+c0qrktBvgrsB5Ut4Fdr001n3ktGqMaOJ9ID+OBZtu4/nWDYimYFj+TYE+5XK5pDgcunXZoNFeyuCrboGZBC2J76UGlVybtSleW+lQqdyRwwJR9PNVc6aKfWvaqU+kr+qVIcgV8pBpkjQowAog8L2va3JR4+t++6je58NQ8Dsha/Joq1WUMBtnMi2ayYu9klOAMOM7GT+QL4NB4qxKEEFBWj9wLqBja3HW5xHyVCW5/fdE1lThWus5mSSpOJ63nHRdp/fuo/DxAvCszEgmE9dkirfDYGca6LeQSTGW5HaGySNX86jdJJBn5Nysoa9flCBbLXTL2z+7G5MNHeA2blpCScdzPnMl5m9KvcOGwEXt9lKEmm+GKifBqGghoMk+liwN3frLY06/5lkGM53A82lIiMKpua/V0z6DnwE9Qx3F6jZwlZHwRo7mE4MPfhd2iLupQb1uq1G3B dbYrbP+8 fkKe0axG9nW4LHWoZ8/RExxjOEXvMK/5zSLe2aUybotLPG8acK8R4A4KYwM1lz+70+CCna6XRG166gVp+lBzujc3aMgPJgal7db8K7YBbZHifvT04iXL4WCalK89E3p1mzoUgzkHKEe/LScBeEuMDRy7VXjTfOBtRQWLLXXT6WGr3jdSZlQhgb47sIlZJEMfZX7JabUXZozzHukmo4fj+S+8ZB9POrYdA1M2o4C63bWMI5Q4HzQKkyGcf5JUdB2nJNLtzN/FIrlkAphNA5lBBeoIg+rl6cQBbYxa2MLXPYA8RppH1ZpFYJ7l9g+UBHxHe5ICB18Ya1NZMXZONTsrwQrWd32sjhEVIuAkQJiaPrduXWZJWZWB917ehdUdW2nxrC2iVl0pGEH9amFPy9Ily5d/i8xRFc2tqf3JclZnloWXApIUawLflak2cfhmESEJGD0xCBEHOtw+jHxSAGE73vCsjsrCfdVrOxFmBKP05pD7wzXujQWuL/kjWZwciNCyevAn1G10Dh0iQjr+3nnLt5v91pQdORsRGui6lQikpHva1Izc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.04.25 11:40, Kirill A. Shutemov wrote: > In the case of apply_to_existing_page_range(), apply_to_pte_range() is > reached with 'create' set to false. When !create, the loop over the PTE > page table is broken. > > apply_to_pte_range() will only move to the next PTE entry if 'create' is > true or if the current entry is not pte_none(). > > This means that the user of apply_to_existing_page_range() will not have > 'fn' called for any entries after the first pte_none() in the PTE page > table. > > Fix the loop logic in apply_to_pte_range(). > > Signed-off-by: Kirill A. Shutemov > Fixes: be1db4753ee6 ("mm/memory.c: add apply_to_existing_page_range() helper") > Cc: Daniel Axtens > --- > mm/memory.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index fb7b8dc75167..2094564f4dfb 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -2907,11 +2907,11 @@ static int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd, > if (fn) { > do { > if (create || !pte_none(ptep_get(pte))) { > - err = fn(pte++, addr, data); > + err = fn(pte, addr, data); > if (err) > break; > } > - } while (addr += PAGE_SIZE, addr != end); > + } while (pte++, addr += PAGE_SIZE, addr != end); > } > *mask |= PGTBL_PTE_MODIFIED; > LGTM. just curious, did you run into any actual issues that are worth describing? It should affect apply_to_existing_page_range() users where create==false. There are not many, and likely most PTEs in the range they are passing are all non-none. Acked-by: David Hildenbrand -- Cheers, David / dhildenb