From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A865FC433EF for ; Thu, 6 Jan 2022 21:57:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 388916B0072; Thu, 6 Jan 2022 16:57:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 337AC6B0073; Thu, 6 Jan 2022 16:57:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 189B96B0074; Thu, 6 Jan 2022 16:57:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id 09D3C6B0072 for ; Thu, 6 Jan 2022 16:57:35 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B6C8281904FD for ; Thu, 6 Jan 2022 21:57:34 +0000 (UTC) X-FDA: 79001224428.23.3D41CC9 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf19.hostedemail.com (Postfix) with ESMTP id 0EF881A0005 for ; Thu, 6 Jan 2022 21:57:33 +0000 (UTC) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 206Kr9Ll009272; Thu, 6 Jan 2022 21:57:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=GP40SE2we4SdMSqt2VuUMfPzL7g1FxwhY9NSMqWdJGs=; b=n9VlN54asxS+OPHvh0S49epl2RFR9fopCOMOOKFNEIuEPGHzc1HQRIU/Nav1D/LWdWSy bhLNofd6jkWdZ4fS0v6fd4gBE26WzTZcT/7rBdZwGpLTOFQIbkZc2zX0BHkyoin9sJKA 20zXbpw66ZZSdCPHLXcoattUgJFTlsFAfmhNXHvh9M9wiSR5LMyGjJ2nNkNUsor3uCKw bk6U9HrLPMBtNhzLTzTEqDbJw9OAQxlLXjACdNmQZHqx1vx9hWG+6eTrT3ESw/Z2mOrQ cLBopdK20NwnviSrPYU7YLTlOJwdI11VPc8rKLmTNbF8liHGOCOLAhz7XGUfK06YH6oV +Q== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3de4vh8kan-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Jan 2022 21:57:17 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 206LtL6V077111; Thu, 6 Jan 2022 21:57:16 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1anam02lp2042.outbound.protection.outlook.com [104.47.57.42]) by userp3020.oracle.com with ESMTP id 3de4vmdpv6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Jan 2022 21:57:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jg6tPvRV6n93CLQBA0CyPqJwexSerY7S82XoR+lXH3MmF/uwsO2MKap8xGejMcrWplzH4pUya7KdoS9yWayC7MmrVHjWVDYZjWdfHXA0ACRECpSMOaNSvRXQioP8V/CSyeDEqLjmVpvarjX4zdXoXt9iMscneDFzJZXHEz0LSCew5M/Qo/Ps/B+cdN4RMlBDxKpeWzBFmHRQRNCW+wWUpB3dliCqBZDb7CoAf7vyoets0Q1HGEV6uoseYn6G5Vp4LNVADhRGcL82h4Qxdf3RZSVlYycACbnCQ6QsJsRUSkKpGVp8hMC9M2rgFoZjEZQtePZBupFSxg8T3PPDLRuFpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GP40SE2we4SdMSqt2VuUMfPzL7g1FxwhY9NSMqWdJGs=; b=LGVMCao6QfuD+vglqeffS61Dq7eVRCj21ZFNfGx/1pxNcC8GWzQEhhfDsUP8s0iHeVe0IGZIFpW6opQ88QTurtl1i77w+X7nQCLIpzNJKSNnZQAxKmJkj/U5TXmdwBZqU4GGnblI5FGMs5na5S0v4M8WVVG671lR1d+GB48PMzJtYWaMf5R0WYgVxymLR/JGvnuu5vaMW48F0glBocCcxu7BgUY1S9p3L6+6niLIatxnaCqA2NMkOplitY22DCMtyaNLQidcu6SfWDdmrXAjL3cNDloJPd1v3UbqWDc7uzX7h170s529UqKLNwCmkpRM21qgVE/24FAhx5JvYayQoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GP40SE2we4SdMSqt2VuUMfPzL7g1FxwhY9NSMqWdJGs=; b=NfHZ1EYN4wXzVov0+/k771BSnNFJMiLWxGLzQJrMAV/ZVAHkxB+StSDBEjf0j0MWFN8XFOHVsmj3BxxkY8rLy0dY05OdhEFEeZV9KRnbWs4apaxwiWK+binRDjNXlWWpuUSmI87L/SFizeVIcesN0g7wrXhOnZHGuY1jS0ikMzA= Received: from SN4PR10MB5559.namprd10.prod.outlook.com (2603:10b6:806:202::16) by SN6PR10MB2448.namprd10.prod.outlook.com (2603:10b6:805:41::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.9; Thu, 6 Jan 2022 21:57:13 +0000 Received: from SN4PR10MB5559.namprd10.prod.outlook.com ([fe80::dcd7:5a68:adf7:5609]) by SN4PR10MB5559.namprd10.prod.outlook.com ([fe80::dcd7:5a68:adf7:5609%4]) with mapi id 15.20.4867.010; Thu, 6 Jan 2022 21:57:13 +0000 From: William Kucharski To: "Matthew Wilcox (Oracle)" CC: "linux-mm@kvack.org" , John Hubbard , Andrew Morton Subject: Re: [PATCH 03/17] mm: Add folio_pincount_ptr() Thread-Topic: [PATCH 03/17] mm: Add folio_pincount_ptr() Thread-Index: AQHYACPLqgrGllQGP0mGeJM0hVXQ+axWkHAA Date: Thu, 6 Jan 2022 21:57:13 +0000 Message-ID: <00ACCE31-1734-4087-AB4A-F42D5905C19C@oracle.com> References: <20220102215729.2943705-1-willy@infradead.org> <20220102215729.2943705-4-willy@infradead.org> In-Reply-To: <20220102215729.2943705-4-willy@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3693.40.0.1.81) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ade18aae-f779-4b77-d335-08d9d15f7f19 x-ms-traffictypediagnostic: SN6PR10MB2448:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1360; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9zyNYtqS3UGyFjXvQAJn08Dg5F6f9fzYKEomg8domk7I3b0gv4mcZNDStZ3buQGNLoyfF2alJ0holDCmi+mYL8gYfD66XsAQhoKNs+TDDwVHVQjdhc4XC5nsq1lpNDlNBbTZlPedvCDRWPNpxvnnDUbeYilZh0x1H9UtzMMVqCDInUs32FjwPrZ+bT12eT9UeIjBCl316BKPqNCBTMTrX5pwowj1YQgyOy+yAcsybMatGzERWB4WxChdCX3rWHFB19+qaXOxSkNMU0ILL1vedunLxNa/x7vdDNmQVeSHlRFCZgRI2gp+ZMiqPHIF3GvROiY4lZDHUoOaQ++itaxlejNvezdX5RWB8WLj3YnX7IEXqQocbwslsQcvMf2B7v1JH+gPIRrvOVFrdabN9Y/+L7M59bjlskKWOYDiRvWUxc8i//j9JAy6SdvQLiMUy2wAGvCb1pH33VLOXQ/utAQsgdnWok3auUThn3Ol0Y06lRY0Hvk8Z1QaDjVfl0tj15WG/2o89uFEIiCv+Vbh6KF2JBReltWyDLuA7QTr3Gsu0As9/NlRlzh18aZ9ZSStk1mZnrQSB3PcTROlcMjJCPh6O1WUNSiOrdmY+HH9wUzx6MWghc2lo8k9n8CjWVYRVdCCbiCRWINfBxy+Lc/ErXlLvrNU2opdbD+Xp9YU28JqnCb5/WoqFbGRRDFdmYXvFfNUnEgYLPfiiduBF8sFi0gkYf255Ov+MD+ETKlz/9zP4ehxi2LvjW9YgV60ZXSIKPRx x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN4PR10MB5559.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(66446008)(64756008)(66476007)(6506007)(86362001)(76116006)(122000001)(71200400001)(91956017)(8936002)(66556008)(316002)(5660300002)(53546011)(44832011)(6512007)(4744005)(36756003)(6916009)(508600001)(66946007)(33656002)(54906003)(6486002)(38070700005)(186003)(38100700002)(4326008)(8676002)(2906002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lLpzn/fJZXSe0zxQ4B28UmFSNV/FKEr/Yt7PL8gbPt07EkTImFPHLGQEvhMW?= =?us-ascii?Q?jzOJKP7F4ie/vN4JTAUUdmbNFnICaSo2s+8m6LgTeRdTZq3xuAh5ByBqkfeM?= =?us-ascii?Q?jnvlerXtSgs5YQ/MtIil/EInhnIBjIdKZTqqwv9JAdlCkFcyAEaHFpGMzh+q?= =?us-ascii?Q?84QXXkYXuha/FQYe4FLivpz8zjOyFdQjvhTHwVbpL4DTVpkKa1W8rkRD+E/i?= =?us-ascii?Q?6Yzf6PsVg59fe85zs60XFoaLPGJYcWXB11wzYBEdtUW5IBpbeniKnzWevJH3?= =?us-ascii?Q?jVhjYQgZYUWX9Dw4o1FrvFoEzG7x7d2Y8GMzgocXPJGWw4hfoQCCzJ2r0Dse?= =?us-ascii?Q?YR9sJmnvg14HkdZjFkxb508yJDjT56XJ4lh5UzTfnMBfNKIjGZ8yDYcEJ2+v?= =?us-ascii?Q?gii2JOMPNIG/od/iHYDsAE3LpMw5CbVwWBXQeKXPjcNwiiMwVK7XemDk1Ylr?= =?us-ascii?Q?2TgMs5XjeI7bd9CkKUC625SnctWC03tJtXGpYc272QqZ1hMlhKtB99Q7xw6m?= =?us-ascii?Q?Aq6XDEQZcv65j+vPTtUlTt4NOXQhv6gEvH/DMO731uEZRiE1W7EC50l7NwgI?= =?us-ascii?Q?V1PuDUkdgnxws3zu3RnYNUmpjyhFXeV76hDB5GFG49o6isBfwQu9qiowbzKH?= =?us-ascii?Q?MysstZllfh8IAhSvcLRFXA97UthZckoRX+6pgEF6l80LQQ1baYxjUn/+hDik?= =?us-ascii?Q?vW4R0vTJVuBzcp6aLoIXvudYgnJdxJi3ruTfK9O5sYOQvdZXf3oslVSTuMYZ?= =?us-ascii?Q?YovurHlpdCV8nWG2F7jS4XDG7k0lwCOHe++qb55WbSgkbj6vnLNTuAbMDN6I?= =?us-ascii?Q?RU4YfBVR04su+ANRbhpbrS6/d+BtbX7dOVvZNi6N+el0+u1/HKyPT0yExyjP?= =?us-ascii?Q?7cLnMtK1bpp5YWaUkt9eHqzfzNRzkpLr9M8daJ5AAlSUm/S4ZjPrFx1mLXDr?= =?us-ascii?Q?RAvqxfakKw2C90EADp31Wf5J7ew//eP4iU+0HelXeltzmPa1h8mQGSpQzyD0?= =?us-ascii?Q?lmbU2xNUj+LaK5gKgZ8wiWON68iqTJP27tRJLXpawQuMHfih0LSxNeFuh9y/?= =?us-ascii?Q?9mgxEk5zern2iSmB3H5sXpsBs3hz9c/fEN9t4MVGvhgwAzfLlRtRustH+o+y?= =?us-ascii?Q?HkziYF0NHUliaFk3oCfxqFMDr/ET7ThcmR83lRj6vJ8GNSLH9iBwWhAdloSk?= =?us-ascii?Q?IZNHPQ+sZqHdIGOeLjMjmEbDN9huqd5UexuBzQjmvk6Seb6RKuQU01VJtlwV?= =?us-ascii?Q?ISipBwr0YPQf1306mMVRKIQFXgS894B/0WKXT+RDvAtqEas9H0GjMe6x0za8?= =?us-ascii?Q?PC1TGGuZOhlSIuHfj/1+M2eWti4m22+MJIGLBwZLiA6GCO82LfKnNMl+3dAR?= =?us-ascii?Q?OknPTbO5nNC8kWYkMU7/BhmhFuZbgoXq9MjZf3AgDi5iCvBdDN8eF0YTek2E?= =?us-ascii?Q?5hp7XfzLz5BNnSMp7mm25extADnAY+zYNI1NgwqxUaisT5wNiqAgg2JMelZq?= =?us-ascii?Q?ituyG3m0ByDD02zer3pxCoT1g/8ITtEnFgt6v3TBSiM2Xo+2E5qLMnqHxyuN?= =?us-ascii?Q?VGGnfrBrifxYUB5lukVThrJ/fp1CucqNZKZJkI6EQujDcab37ZiZDgWpKiMT?= =?us-ascii?Q?jukdJxDBA9DKsgi6Su0LWFR5an/94DOSICOIQfaYkgiT64UCraBeY1O2Z8av?= =?us-ascii?Q?1s3ZDXfYQGlt3HE527M9rxWzfYuOW2dBVCBg2nMc7Jh+rrROp/gguV7IMaei?= =?us-ascii?Q?cIkEhqCwlLCxFwEzadXKx2sgJJVaKAs=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <920369CB766F034FB98D231226D44A82@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN4PR10MB5559.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ade18aae-f779-4b77-d335-08d9d15f7f19 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2022 21:57:13.3195 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AGY+icAKMzdEqlo/prVva8YtK0fkFpRbK/DznDOGBrkB1waQ/SDOzuyy6uXWCLHzeU3pX9UAQGB6Pz8DTHVt43YIspjS4gpG+4x1xx2kODo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2448 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10219 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 suspectscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2201060136 X-Proofpoint-ORIG-GUID: JfjRnkoPzuaZ4GyNhATsseBDHSKsQURY X-Proofpoint-GUID: JfjRnkoPzuaZ4GyNhATsseBDHSKsQURY X-Stat-Signature: 3bmh154pjrq7yu7iphiho5j17mgaf33x X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 0EF881A0005 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=n9VlN54a; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=NfHZ1EYN; spf=none (imf19.hostedemail.com: domain of william.kucharski@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=william.kucharski@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-HE-Tag: 1641506253-723372 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Comment inline. > On Jan 2, 2022, at 2:57 PM, Matthew Wilcox (Oracle) = wrote: >=20 > This is the folio equivalent of compound_pincount_ptr(). >=20 > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/mm_types.h | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index c3a6e6209600..09d9e2c4a2c5 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -309,6 +309,12 @@ static inline atomic_t *compound_mapcount_ptr(struct= page *page) > return &page[1].compound_mapcount; > } >=20 > +static inline atomic_t *folio_pincount_ptr(struct folio *folio) > +{ > + struct page *tail =3D &folio->page + 2; Please add a comment explaining why this is "2." > + return &tail->hpage_pinned_refcount; > +} > + > static inline atomic_t *compound_pincount_ptr(struct page *page) > { > return &page[2].hpage_pinned_refcount; > --=20 > 2.33.0 >=20