From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D14B9C433FE for ; Tue, 10 May 2022 15:51:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 539CE8D0001; Tue, 10 May 2022 11:51:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E5F16B0074; Tue, 10 May 2022 11:51:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 388018D0001; Tue, 10 May 2022 11:51:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2B0EC6B0073 for ; Tue, 10 May 2022 11:51:04 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 089AE321AE for ; Tue, 10 May 2022 15:51:04 +0000 (UTC) X-FDA: 79450272048.31.E65B21E Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by imf12.hostedemail.com (Postfix) with ESMTP id F150D40091 for ; Tue, 10 May 2022 15:50:41 +0000 (UTC) Received: by mail-io1-f41.google.com with SMTP id i20so18992867ion.0 for ; Tue, 10 May 2022 08:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WOUz2WsmdgX6LeN+LrF3txVAnT8hFkZ8ulMV7CFBOqM=; b=XTCkuhyrI12mXoibtavSh6cqwdk4FerubUN/RyfF6NFULIGnuGEkqPOOM8I2zwQ+o0 Q6t7+QE88n3MP1KIW2iOswY+eCBI2ZUBLChS/bwADArGE4WFf2CAE10R0h7xDZu1KZTV gm2knkXa/E9lbuTqeJjwbg1h+Du01PqftXDYQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WOUz2WsmdgX6LeN+LrF3txVAnT8hFkZ8ulMV7CFBOqM=; b=OwhA26seKxh8PNqp6oWSL6z7tZ3dU1OultgNlhCnpLTMmosReQA2UCBWoeVxc8Rj1M W35gm/HHsjGWeF7NRvCPu77e/DgwTgN8tOOzDV9bML8U99rOLKdV8Db/YomOf+TF6WUt gsTWMAIQZ2rfLeK+FVKu9IIlmdQgoKwT66geVAIzNBYCrl5lMv+ZhrmKufy7F9YFvhPm p+UsgDOlDU4bt3n5Qv8O4kfQHgRdDx3FAilJUlf6iHKl6l23oq0Mu6mncg2BVVZMB0o5 BcGO6DOO09SuqvkYkqhdwVbWdo+LqhbhNjZfWxS1KMAp2jpn6l7f7NAgIF2AW22sHQz7 SAeA== X-Gm-Message-State: AOAM532v5ilWoBg1lPS9a19txnfmFnxID69Y5ggEUZAdZoF9MfFtGl+f dqwWvSbzED8abc0QLCfBowyHWA== X-Google-Smtp-Source: ABdhPJyKMFN44LVscpOAtyLyGGeKIRdp+9zY59CqwUYms2hhDMiEHT2+QMZC1z4qTekEb3cR4IgqdQ== X-Received: by 2002:a02:aa94:0:b0:32a:e769:af1 with SMTP id u20-20020a02aa94000000b0032ae7690af1mr9721447jai.0.1652197862793; Tue, 10 May 2022 08:51:02 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id cp20-20020a056638481400b0032b75b98013sm4455954jab.148.2022.05.10.08.51.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 May 2022 08:51:02 -0700 (PDT) Subject: Re: [PATCH 3/3] mm: delete unused MMF_OOM_VICTIM flag To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: mhocko@suse.com, rientjes@google.com, willy@infradead.org, hannes@cmpxchg.org, guro@fb.com, minchan@kernel.org, kirill@shutemov.name, aarcange@redhat.com, brauner@kernel.org, hch@infradead.org, oleg@redhat.com, david@redhat.com, jannh@google.com, shakeelb@google.com, peterx@redhat.com, jhubbard@nvidia.com, shuah@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, Shuah Khan References: <20220510030014.3842475-1-surenb@google.com> <20220510030014.3842475-3-surenb@google.com> From: Shuah Khan Message-ID: <008de890-7fe1-aeae-345e-0cd3fcd32352@linuxfoundation.org> Date: Tue, 10 May 2022 09:51:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220510030014.3842475-3-surenb@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F150D40091 X-Stat-Signature: 8seskyi1gne881f9rmrrhmjogr3r8uc8 X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=XTCkuhyr; spf=pass (imf12.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.41 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-HE-Tag: 1652197841-311507 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/9/22 9:00 PM, Suren Baghdasaryan wrote: > With the last usage of MMF_OOM_VICTIM in exit_mmap gone, this flag is > now unused and can be removed. > > Signed-off-by: Suren Baghdasaryan > --- > include/linux/oom.h | 9 --------- > include/linux/sched/coredump.h | 1 - > mm/oom_kill.c | 4 +--- > 3 files changed, 1 insertion(+), 13 deletions(-) > > diff --git a/include/linux/oom.h b/include/linux/oom.h > index 6cdf0772dbae..25990e9d9e15 100644 > --- a/include/linux/oom.h > +++ b/include/linux/oom.h > @@ -77,15 +77,6 @@ static inline bool tsk_is_oom_victim(struct task_struct * tsk) > return tsk->signal->oom_mm; > } > > -/* > - * Use this helper if tsk->mm != mm and the victim mm needs a special > - * handling. This is guaranteed to stay true after once set. > - */ > -static inline bool mm_is_oom_victim(struct mm_struct *mm) > -{ > - return test_bit(MMF_OOM_VICTIM, &mm->flags); > -} > - > /* > * Checks whether a page fault on the given mm is still reliable. > * This is no longer true if the oom reaper started to reap the > diff --git a/include/linux/sched/coredump.h b/include/linux/sched/coredump.h > index 4d9e3a656875..746f6cb07a20 100644 > --- a/include/linux/sched/coredump.h > +++ b/include/linux/sched/coredump.h > @@ -70,7 +70,6 @@ static inline int get_dumpable(struct mm_struct *mm) > #define MMF_UNSTABLE 22 /* mm is unstable for copy_from_user */ > #define MMF_HUGE_ZERO_PAGE 23 /* mm has ever used the global huge zero page */ > #define MMF_DISABLE_THP 24 /* disable THP for all VMAs */ > -#define MMF_OOM_VICTIM 25 /* mm is the oom victim */ > #define MMF_OOM_REAP_QUEUED 26 /* mm was queued for oom_reaper */ > #define MMF_MULTIPROCESS 27 /* mm is shared between processes */ > /* > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 36355b162727..11291b99599f 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -732,10 +732,8 @@ static void mark_oom_victim(struct task_struct *tsk) > return; > > /* oom_mm is bound to the signal struct life time. */ > - if (!cmpxchg(&tsk->signal->oom_mm, NULL, mm)) { > + if (!cmpxchg(&tsk->signal->oom_mm, NULL, mm)) > mmgrab(tsk->signal->oom_mm); > - set_bit(MMF_OOM_VICTIM, &mm->flags); > - } > > /* > * Make sure that the task is woken up from uninterruptible sleep > Thank you for working on the new tests and cleanups. This series needs a cover-letter that explains why this series is needed that includes the information from this last patch. Please send v2 with a proper cover letter starting with why this series is necessary. If you did that, it would have reviewers job is lot easier. Also it appears you are combining new tests with cleanup patches. I think patches 2/3 and 3/3 can be a separate series and the new test can be a separate patch. thanks, -- Shuah