From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E25DC61D85 for ; Tue, 21 Nov 2023 01:02:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1F3A6B03AF; Mon, 20 Nov 2023 20:02:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DCEFA6B03B3; Mon, 20 Nov 2023 20:02:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6EF16B03B5; Mon, 20 Nov 2023 20:02:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B08006B03AF for ; Mon, 20 Nov 2023 20:02:20 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9213F160ACF for ; Tue, 21 Nov 2023 01:02:20 +0000 (UTC) X-FDA: 81480160440.24.10C2235 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf15.hostedemail.com (Postfix) with ESMTP id 372C8A0028 for ; Tue, 21 Nov 2023 01:02:17 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rer8SQ05; spf=pass (imf15.hostedemail.com: domain of "SRS0=TAUs=HC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=TAUs=HC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org"; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700528538; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9WFhisBl32Xn5xDqU7/4zR0KhHEuXKBQ6CZM11zranY=; b=uvpgjjHsyTGlkDQO0jgSHdOF4NpTyTLY+9dhVLkuS1Z0xCgnp/ZU2hFqT35NylzQxNBXpF MxYpOKlCgl9CZWB/o97J+BOAtUODr2B8tIjmyoAFDAvXm8cG5/OMOBoqHu8BeCac1Ac5ie OhOj4HYs2Pm8xDhxryEdxONMBGagiKw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rer8SQ05; spf=pass (imf15.hostedemail.com: domain of "SRS0=TAUs=HC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=TAUs=HC=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org"; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700528538; a=rsa-sha256; cv=none; b=BEJkyenJCjE23LaH1jq38EY+5/gVrV3KAvhas8g7qIfjlFYvW3ien0ocaWPU6hxL0WDfl5 qHRSgNL+SKmtTpRqudXrl0z2G7g2pzBlA932WSCsUN7onmKhygqRp4QoZ0XNp8fzaoLee8 sd6r3jrZ2yVVBHRLDNNERJ4UEhdd770= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4B070CE181B; Tue, 21 Nov 2023 01:02:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77BE6C433C7; Tue, 21 Nov 2023 01:02:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700528534; bh=c2p1c9h9OLXIW1qdxiQJ1cJW79ojVa/E+hgB2/Q4MzY=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=rer8SQ05mg8xsK7UmAxkNIh1pnEOutDGdhg4EixbY39byivelsT7ourpejf41dpRj uNNdy3GfAq+IraJZ81zwuNFm5ADgscdzreRrTwMh9DtWqPI1jHxyNXp8qfK7wQFd/O f+xBFwTTnR5NP1Wmst5HZz7IKfd9Yp3qmB18oKAwRV1Q7pROwpXbLFouaXbtM6guzO sOppS6Sd4g4+G5I1qOk44T5Nr+7mmyD3XqTDomyUFl8Ey4H4luxWuQdXzLC12cuJVB 5l6bAG5TYis16QdHnGaw6qoP15jdhNOEzYnoukWn3aQa18TSmhFJGBV2VCU+APMeq1 cFjln8kTEA0uw== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 25580CE1390; Mon, 20 Nov 2023 17:02:14 -0800 (PST) Date: Mon, 20 Nov 2023 17:02:14 -0800 From: "Paul E. McKenney" To: Ankur Arora Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, rostedt@goodmis.org, David.Laight@aculab.com, richard@nod.at, mjguzik@gmail.com, Davidlohr Bueso , Josh Triplett , Frederic Weisbecker Subject: Re: [RFC PATCH 60/86] treewide: torture: remove cond_resched() Message-ID: <00803d57-b012-4c30-8ea2-0605cf68ddee@paulmck-laptop> Reply-To: paulmck@kernel.org References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107230822.371443-1-ankur.a.arora@oracle.com> <20231107230822.371443-4-ankur.a.arora@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231107230822.371443-4-ankur.a.arora@oracle.com> X-Rspamd-Queue-Id: 372C8A0028 X-Rspam-User: X-Stat-Signature: bf61d1feemajag1ggjc8h7tcz7pggjwz X-Rspamd-Server: rspam01 X-HE-Tag: 1700528537-746497 X-HE-Meta: U2FsdGVkX1/4CBV40pYu6aTSwBu47x1C/AMilva9C4aVjkabQFwyMIID9ZuuDtgUJ7Vrz4qVf6QhclUKJ+4PcSA8a8+WmZ4Jehv+ZsQ42UWEBpZlhNkgmc8RkTCsl3pPJPVkLJxm9FZtGKt72/LzV6qDdPm40TiXkU4hjMFkCmf67hS3l53S6Lo5TZMMNfqYlUMtf2YIEo8kx2TPdgZ7TxfXdKv2Srn8JJl/0vgx58uwspuCobCUtrGKhqLqbeDQfr1G6ZXtYd+JK92nRbRFUBeQG9Lm2WVrxIe1/iPnpH+L+BpfIrFCwXFU5xoyJNvhxDOC0Z4/59pll5uGvv3cD3/wV7m/Z9VUNXlZjybB5aPJxYrFjnPSRX41pWCFY0C1kutDgZjBMxesDvjaxSTRtpeTtG2sahFNs/AqKdbBPx3Bat0P2N77Zdld+twX+4AKtaWq3VYzb10/SKfcZo5r5n5VwCDFeIs4KbLYt6ve17qgm9nQAasHaApUGlDc2Wh618ldROfGRgz79Fr/eqsq73yOYJ/uH/19d/BhfvQcY2jLfArp6Ik9fErwtGpSgYitOJTvL+HdSuecX+nOdUESOue+bDnBsixEA+L5c37Fnu1iXvKhIadRlD9WnHdCymp/25c10PyocrkYzFrQBgbfhlYe8MSq3wPEVmiWaTjkmb7M9mkQI0ZHBwdoGuiHj/JsgUS/t8xbJrNRm7V4+AvgDdj/xOoQ+0xvs1xFmcHnlsYjUjS5Buq/4YcH/28HhrzeAxiiAFucaFxaG+z5SCLJnLhp2yEeE4bXef8JGWPQ7ZF6u7jOfgkswMPxcGdbtnWHs/n608Fmzk5e/cQQ3rTcHLVuJ8+nZWQsPTiTi7S2QdS4/uInrmN87gvHroY/5oeF8J+6wL0U4O0iN7/pSio+H8F9BtJGlacFhjon4BiqROAuKahf6EZLzQKSTfS9n3nCcqeA11CmC+5F6DUkj6Y j12GgKME 3SObXp5YR0CgQDCGr6G0ZVvuEs5R2l/m54IrMCXGdTvVGan8QCmeJobgkFKETOkxUpPMyvqPF1dGXRqF1uMqh1wAKs25sbI5FlDh1oneNf01LTXiWVQV7TtkiIqmVPzihz8xpfI4aH0+9nu0iRa7hh8qrTskNgyUdiZ2KQC8dy1+pyv8sNPZK7xYC8BoQow8WtwBJZIMRSaFadoGylIz+5UKX0M2YyIvCP55NRZOqRkEesLwQNowZ5V4QFkfhfHPn7ThNGFsvbMqgKyWlybuo2ecNypI/6zP7MOVtHQu5+xCeoUDhWdAqW+1IUnGTTut9xjHZW3Gbs1LzdRGtotUBw2QXfBlNYCi8D+9lDV7feW5FsLsdjivXvHnSxgPd3F0ZKdPZI1PvIglNJPQgVHBzlp0p4JUyy6j7E3T7O4nWwOtpqI4RCZbFNbHcelKbOkZpeCY+roRvDCab5IhXzBLPWf93oINQDCGy8MMNypa14o472g2yl01XxoKOy1F+/bUQl3pbvCEUayJytROTrb38szRqYhk6ULBkj8/2gXiIDuU3z2ld6a2Ph3hcxMPC8FGWAdmOpud94Et4Hq3w8jcT0GHWLdhMC4tV+ABfsdRNTBVzu3/LM/WyT45j6BZDsUTNnSzVcbi5PMES776p+asHMdj6uYNjc7/0/o3yf7irCDQQAcWyKhnf/O5EQQRL9ELRoZ8xKUlDv9oNEJNa3a14werFZX1rBo7AsXD7ukJUiqLIk6j7kZ/a18mChMm/T5cikBE0lT714eDa0k7ORX6Ro2mVOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 07, 2023 at 03:07:56PM -0800, Ankur Arora wrote: > Some cases changed to cond_resched_stall() to avoid changing > the behaviour of the test too drastically. > > Cc: Davidlohr Bueso > Cc: "Paul E. McKenney" > Cc: Josh Triplett > Cc: Frederic Weisbecker > Signed-off-by: Ankur Arora Given lazy preemption, I am OK with dropping the cond_resched() invocations from the various torture tests. Reviewed-by: Paul E. McKenney > --- > kernel/rcu/rcuscale.c | 2 -- > kernel/rcu/rcutorture.c | 8 ++++---- > kernel/scftorture.c | 1 - > kernel/torture.c | 1 - > 4 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c > index ffdb30495e3c..737620bbec83 100644 > --- a/kernel/rcu/rcuscale.c > +++ b/kernel/rcu/rcuscale.c > @@ -672,8 +672,6 @@ kfree_scale_thread(void *arg) > else > kfree_rcu(alloc_ptr, rh); > } > - > - cond_resched(); > } while (!torture_must_stop() && ++loop < kfree_loops); > > if (atomic_inc_return(&n_kfree_scale_thread_ended) >= kfree_nrealthreads) { > diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c > index ade42d6a9d9b..158d58710b51 100644 > --- a/kernel/rcu/rcutorture.c > +++ b/kernel/rcu/rcutorture.c > @@ -81,7 +81,7 @@ torture_param(int, fqs_stutter, 3, "Wait time between fqs bursts (s)"); > torture_param(int, fwd_progress, 1, "Number of grace-period forward progress tasks (0 to disable)"); > torture_param(int, fwd_progress_div, 4, "Fraction of CPU stall to wait"); > torture_param(int, fwd_progress_holdoff, 60, "Time between forward-progress tests (s)"); > -torture_param(bool, fwd_progress_need_resched, 1, "Hide cond_resched() behind need_resched()"); > +torture_param(bool, fwd_progress_need_resched, 1, "Hide cond_resched_stall() behind need_resched()"); > torture_param(bool, gp_cond, false, "Use conditional/async GP wait primitives"); > torture_param(bool, gp_cond_exp, false, "Use conditional/async expedited GP wait primitives"); > torture_param(bool, gp_cond_full, false, "Use conditional/async full-state GP wait primitives"); > @@ -2611,7 +2611,7 @@ static void rcu_torture_fwd_prog_cond_resched(unsigned long iter) > return; > } > // No userspace emulation: CB invocation throttles call_rcu() > - cond_resched(); > + cond_resched_stall(); > } > > /* > @@ -2691,7 +2691,7 @@ static void rcu_torture_fwd_prog_nr(struct rcu_fwd *rfp, > udelay(10); > cur_ops->readunlock(idx); > if (!fwd_progress_need_resched || need_resched()) > - cond_resched(); > + cond_resched_stall(); > } > (*tested_tries)++; > if (!time_before(jiffies, stopat) && > @@ -3232,7 +3232,7 @@ static int rcu_torture_read_exit(void *unused) > errexit = true; > break; > } > - cond_resched(); > + cond_resched_stall(); > kthread_stop(tsp); > n_read_exits++; > } > diff --git a/kernel/scftorture.c b/kernel/scftorture.c > index 59032aaccd18..24192fe01125 100644 > --- a/kernel/scftorture.c > +++ b/kernel/scftorture.c > @@ -487,7 +487,6 @@ static int scftorture_invoker(void *arg) > set_cpus_allowed_ptr(current, cpumask_of(cpu)); > was_offline = false; > } > - cond_resched(); > stutter_wait("scftorture_invoker"); > } while (!torture_must_stop()); > > diff --git a/kernel/torture.c b/kernel/torture.c > index b28b05bbef02..0c0224c76275 100644 > --- a/kernel/torture.c > +++ b/kernel/torture.c > @@ -747,7 +747,6 @@ bool stutter_wait(const char *title) > while (READ_ONCE(stutter_pause_test)) { > if (!(i++ & 0xffff)) > torture_hrtimeout_us(10, 0, NULL); > - cond_resched(); > } > } else { > torture_hrtimeout_jiffies(round_jiffies_relative(HZ), NULL); > -- > 2.31.1 >