From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBF15C47DD9 for ; Mon, 22 Jan 2024 17:02:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48EBF8D0003; Mon, 22 Jan 2024 12:02:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 43F1D8D0001; Mon, 22 Jan 2024 12:02:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 291BB8D0003; Mon, 22 Jan 2024 12:02:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 196108D0001 for ; Mon, 22 Jan 2024 12:02:07 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DDED2409E7 for ; Mon, 22 Jan 2024 17:02:06 +0000 (UTC) X-FDA: 81707564652.03.368C918 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 7BFA41C0007 for ; Mon, 22 Jan 2024 17:02:04 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=czGe+r6o; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705942924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dOr3M/UPrLub/x/c3PZ8Lu+PQBMgphrZEZ1ZGLkQwfE=; b=ib6ZZFlaO0ifIrZaLuJyiRqXEPCEHmVoSSeM9BLKsH3o2qZP+Mspi4JALQBp39nDwKQWrb KYNmGoVp0+RwuXmnZKQKz5inoZR8m0I92I8M297OGD3DI/hAWrTjZj62G5JqhfxAEHufY1 PofpLrRtZXUQdFQux4vLaCRVmAslX44= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=czGe+r6o; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705942924; a=rsa-sha256; cv=none; b=ylEC8PivYCoMNCBfYuWbApY7Em8f0GXOK5Suhcy5xYBcdvtaijSqukEjWdF8yHu+QaJl2t rE156pNw8vE/Naut5EAPj+CnfttRz0J5F7yWVHSyMmi9GASrTPU3eEhpRmAQz7tLSAN17r HyG0EQDGgrCt+2RgvzPfKvcEh6tO/EQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705942923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dOr3M/UPrLub/x/c3PZ8Lu+PQBMgphrZEZ1ZGLkQwfE=; b=czGe+r6oUQVSTvgrKZ5V1tDVW6ky4C/qYFXmvA5oJavzBvGFvKuSpCabBr7qXupg01gHYV C97Zm9PfcVMrnd5KBy64ckBv2YlGaMzWwuzWISeSsw/3nwq/Fu7dHaQlxMPQHgwvdbFoPi 51OuEGgQjVc0RzDuXxNP4A8fsNv1VlA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-19-IJNndWjCO7WmKq-KkiccnQ-1; Mon, 22 Jan 2024 12:02:01 -0500 X-MC-Unique: IJNndWjCO7WmKq-KkiccnQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-339222e46a0so1960767f8f.2 for ; Mon, 22 Jan 2024 09:02:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705942920; x=1706547720; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dOr3M/UPrLub/x/c3PZ8Lu+PQBMgphrZEZ1ZGLkQwfE=; b=j8TaQ6HhwgZhPQZKwRDlxXK4jf/4RuxOoNfIy2YySz3gwO+iTuyrAYEnzMozgY6yYT IamVpZk1y5Pcw45Ao1Qj8nWn83HfaY7rG6c3NEkfIU/zGPXs+anw+fxGSDAAV3C+HhHt 3249udM5St1KONpW4OpR4Ri71WeghQ1iSqTYIEE5WbD4BlW/UJwOCNsA6cO9OWPSXO8U PGmlF1+6PtOxSYgnaPlc7KELgiIDnjaPtIzYkJs8Dd67NlKinZKI0SMPiBcxy86y+cF3 /8TN9jIK9fi8ZzhhB5PK0V0DOeK0IZBOTyPTk/LOWvyQBlXVyeprN7PYJ6KoTNQR83Zb 9mmw== X-Gm-Message-State: AOJu0Ywo7JhKc+LwuFSVd9KyIVqwvHcQWbAU/9ov/Fwup7IOxT9vdizJ qTtHD6g5lzNqZlQgVMP4zSgN1IUcfSl9yM+6OrJUYLLnsCOhA+yzjD1AaxkD8RdGfnsyNpx9sfV PhPJN1XFTflBDaO37cAxLy5tHLGJcpgspZ9b9BI/SLKIJ4qH6 X-Received: by 2002:a5d:4a0c:0:b0:337:c4e2:a1de with SMTP id m12-20020a5d4a0c000000b00337c4e2a1demr2194589wrq.105.1705942920327; Mon, 22 Jan 2024 09:02:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IEUOIF5rkWUUJ+hLGMup5NPgQg8SO8qlc9p87ZfoF44SznQROhwbW8uQS+KYAmTt4Ct+qf6TA== X-Received: by 2002:a5d:4a0c:0:b0:337:c4e2:a1de with SMTP id m12-20020a5d4a0c000000b00337c4e2a1demr2194575wrq.105.1705942919863; Mon, 22 Jan 2024 09:01:59 -0800 (PST) Received: from ?IPV6:2003:cb:c737:f400:b194:1841:c4a5:75f5? (p200300cbc737f400b1941841c4a575f5.dip0.t-ipconnect.de. [2003:cb:c737:f400:b194:1841:c4a5:75f5]) by smtp.gmail.com with ESMTPSA id x7-20020a5d6507000000b003392940f749sm6660821wru.77.2024.01.22.09.01.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jan 2024 09:01:59 -0800 (PST) Message-ID: <007e83fa-16c7-4700-b326-ee8cb7809f9f@redhat.com> Date: Mon, 22 Jan 2024 18:01:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 28/40] mm/memory: page_remove_rmap() -> folio_remove_rmap_pte() To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu References: <20231220224504.646757-1-david@redhat.com> <20231220224504.646757-29-david@redhat.com> <2445cedb-61fb-422c-8bfb-caf0a2beed62@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <2445cedb-61fb-422c-8bfb-caf0a2beed62@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: ntn96uippts48tswnipkn7s79romc85j X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7BFA41C0007 X-HE-Tag: 1705942924-32219 X-HE-Meta: U2FsdGVkX1+P3EmYp/ZH8DXLQPNcfSyJkCVEbxM3g6RuroOL22bYHCXZk1eNRdTdwbTFFD6j+J+yw2uOp5F1NtB+HeOpkQJup2xk9p8VkwbnzzvgRkNTk+BT2Rly2EOsdH6fCVGGVxo13DADQ6x/M0L6eBEV1SGorQaaSm+Bbv8X6OdvfgR+p80+fWtjXjHlKJKLpbV6XqorWNHrLEECRlwluoiAultG0Fypdc3JtT3J+Gy1MC4BoxhEarndNtDGEp+qSeOZlOXN97fbeWHkWi7iFaBBSTy7jD2W3xU4ARSFk3+mFauhU/b4p/sYZL9/nnchdioiBMGQ4jrR2VXyU0z55WyDy/JYRTbfZt+Lomn3DSGyjiKWDL57ZLu4ICAAc5SwY7kzpbLXAD1rpyilogcRhH/yZpxcpUs6MBtlqALuxEButSorgBtE54LV+g7RUbmJQUXZC0v1yzRffFtv6ncQPswo8LYCOnNDwmMKkTmfsxDlq/GSK9FjOvi5eKfTqdw/pAc1UCV11MlJ0q4SOTkinVvHrpd34W+LU/wyn3LDfWho67vtsjLLubozw5rfWJ0faaaiQGVqdykdr8Tbs+schpzCb9i8W0R1UQiDE3bjjOdggW1gRERDSXy2D1TT82EedpgTpihIDzr7MKdJ+wHpXAcNd1EEUX/fsCzyDKOjjVbdVW+i5wNhpBm07smh0niu2W4W8iieRb1egJPUCjWBpr+Q7+ugEHx74KfC0UkEmeCF8OkMxwzcOxvQR2bawGHOjBglWz3wjqNz1FISMAIvmzW1VdPz+Dlxq+zImK+f2tHn1plMGVu+f+IzVAHu89skOZ2SnuwB0muoK6WtNJZfSbn9yEH9brjXBGXofy9yjjjv8knyWwhNd4zOZJf9slzmmkmwT50Jgre3eRPkb82EwiYXnVLU9e7cDg+6B+AmbL85GEeNDBxqQxOjC0TH24HxKlfuyOU7JYKpVts vqqWAY+4 xRq1h+Qf2G74OgQFPlyOKbpKF+pNUOSgrukMP361yWx/+PKljijufnsStzOv/+xyKBzGzCF3dANRmtkpsVJY3gtxpAhnvknI1ylFFHNnI0BJS6m8fp/zq5al4Uw9vYpHqkuRcHVPcZtykpIXyrYU+TyTPLu5miv1YGdWH7v0XvJVGBg73Foly/sS6gGNat5ICV2+BnyCqywdgP4cAyK9rXIZ69yKJ74KqRooOxWEQ//6qRy3rmzjRVsuTg7WlioFZ3MJO0U70DDKblHh/6625Yf2KnU5q5Cr2XACaH4b+63xCO2RgfOo8+5s0CBmXCvHxsP7DVmFTdoKKox1zTomHVdoVqUHzQ9CHuKYyz22/mtGXUIC1lWNUtkt6j5wbwjpyfMYJFEUKGr52I54yceBSxuH8JaTGqA03yXTeW3vMAbpoHzkSXIbGbWxOywm4OS4WV4FtgLE/rOq7JbySF4XiLPPskdcQ4ZJsZ0fTI7DSm1xx5x+NP8wgUUDYKA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.01.24 17:58, Ryan Roberts wrote: > On 20/12/2023 22:44, David Hildenbrand wrote: >> Let's convert zap_pte_range() and closely-related >> tlb_flush_rmap_batch(). While at it, perform some more folio conversion >> in zap_pte_range(). >> >> Signed-off-by: David Hildenbrand >> --- >> mm/memory.c | 23 +++++++++++++---------- >> mm/mmu_gather.c | 2 +- >> 2 files changed, 14 insertions(+), 11 deletions(-) >> >> diff --git a/mm/memory.c b/mm/memory.c >> index 6552ea27b0bfa..eda2181275d9b 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -1434,6 +1434,7 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb, >> arch_enter_lazy_mmu_mode(); >> do { >> pte_t ptent = ptep_get(pte); >> + struct folio *folio; >> struct page *page; >> >> if (pte_none(ptent)) >> @@ -1459,21 +1460,22 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb, >> continue; >> } >> >> + folio = page_folio(page); >> delay_rmap = 0; >> - if (!PageAnon(page)) { >> + if (!folio_test_anon(folio)) { >> if (pte_dirty(ptent)) { >> - set_page_dirty(page); >> + folio_set_dirty(folio); > > Is this foliation change definitely correct? I note that set_page_dirty() is > defined as this: > > bool set_page_dirty(struct page *page) > { > return folio_mark_dirty(page_folio(page)); > } > > And folio_mark_dirty() is doing more than just setting teh PG_dirty bit. In my > equivalent change, as part of the contpte series, I've swapped set_page_dirty() > for folio_mark_dirty(). Good catch, that should be folio_mark_dirty(). Let me send a fixup. (the difference in naming for both functions really is bad) -- Cheers, David / dhildenb