From: David Laight <David.Laight@ACULAB.COM>
To: 'Guillaume Tucker' <guillaume.tucker@collabora.com>,
Shuah Khan <shuah@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Borislav Petkov <bp@suse.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"kernel@collabora.com" <kernel@collabora.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] selftests, x86: fix how check_cc.sh is being invoked
Date: Fri, 25 Feb 2022 21:38:01 +0000 [thread overview]
Message-ID: <006c160c1e0240df8a86cc679b2a6678@AcuMS.aculab.com> (raw)
In-Reply-To: <8e88488b-1666-ce1b-6d79-7c6758672ac0@collabora.com>
From: Guillaume Tucker
> Sent: 25 February 2022 18:50
...
> > -if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
> > +if $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
> > echo 1
> > else
> > echo 0
>
> I see the change in check_cc.sh is already covered by Usama's patch:
>
> selftests/x86: Add validity check and allow field splitting
>
> -if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
> +if [ -n "$CC" ] && $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
Or:
if ${CC:-false} -o /dev/null ....
There's always one more way...
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-02-25 21:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 13:15 Guillaume Tucker
2022-02-25 18:49 ` Guillaume Tucker
2022-02-25 21:38 ` David Laight [this message]
2022-02-26 1:03 ` Andrew Morton
2022-03-11 10:15 ` Guillaume Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=006c160c1e0240df8a86cc679b2a6678@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=guillaume.tucker@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox