From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by kanga.kvack.org (Postfix) with ESMTP id 8DA6D6B0031 for ; Fri, 27 Jun 2014 07:39:12 -0400 (EDT) Received: by mail-pa0-f42.google.com with SMTP id lj1so4507264pab.15 for ; Fri, 27 Jun 2014 04:39:12 -0700 (PDT) Received: from mailout3.samsung.com (mailout3.samsung.com. [203.254.224.33]) by mx.google.com with ESMTPS id nr2si13641404pbc.145.2014.06.27.04.39.11 for (version=TLSv1 cipher=RC4-MD5 bits=128/128); Fri, 27 Jun 2014 04:39:11 -0700 (PDT) Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N7T00GMGSCQO580@mailout3.samsung.com> for linux-mm@kvack.org; Fri, 27 Jun 2014 20:38:50 +0900 (KST) From: Namjae Jeon Subject: [PATCH] msync: fix incorrect fstart calculation Date: Fri, 27 Jun 2014 20:38:49 +0900 Message-id: <006a01cf91fc$5d225170$1766f450$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-2 Content-transfer-encoding: quoted-printable Content-language: ko Sender: owner-linux-mm@kvack.org List-ID: To: 'Andrew Morton' Cc: linux-mm@kvack.org, linux-ext4 , =?iso-8859-2?Q?Luk=E1=B9_Czerner?= , 'Matthew Wilcox' , 'Eric Whitney' , Ashish Sangwan Fix a regression caused by Commit 7fc34a62ca mm/msync.c: sync only the requested range in msync(). xfstests generic/075 fail occured on ext4 data=3Djournal mode because the intended range was not syncing due to wrong fstart calculation. Cc: Matthew Wilcox Cc: Luk=E1=B9 Czerner Reported-by: Eric Whitney Signed-off-by: Namjae Jeon Signed-off-by: Ashish Sangwan --- mm/msync.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/msync.c b/mm/msync.c index a5c6736..ad97dce 100644 --- a/mm/msync.c +++ b/mm/msync.c @@ -78,7 +78,8 @@ SYSCALL_DEFINE3(msync, unsigned long, start, size_t, = len, int, flags) goto out_unlock; } file =3D vma->vm_file; - fstart =3D start + ((loff_t)vma->vm_pgoff << PAGE_SHIFT); + fstart =3D (start - vma->vm_start) + + ((loff_t)vma->vm_pgoff << PAGE_SHIFT); fend =3D fstart + (min(end, vma->vm_end) - start) - 1; start =3D vma->vm_end; if ((flags & MS_SYNC) && file && --=20 1.7.11-rc0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org