From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F26F7C369BA for ; Wed, 16 Apr 2025 07:38:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E43C82800C8; Wed, 16 Apr 2025 03:37:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEFD92800BD; Wed, 16 Apr 2025 03:37:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE0D92800C8; Wed, 16 Apr 2025 03:37:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B029A2800BD for ; Wed, 16 Apr 2025 03:37:58 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id ABB1814026C for ; Wed, 16 Apr 2025 07:37:59 +0000 (UTC) X-FDA: 83339103078.21.6478779 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf01.hostedemail.com (Postfix) with ESMTP id 3407640003 for ; Wed, 16 Apr 2025 07:37:56 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744789077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H3iR43ATtWyewznE2kB93dIxsyBpkLUt5iOPA+HIRLk=; b=n/QltUGnyBA+gZIhYKvcBPVVIwgcVeBWbrYRrK0T+026AlZg0ABSQgztVYK87Lixzc7uZe C/k2OXjZ3bf1l2Usrk915UuObuDQpgRbfDJMpmwPF+9kRxfl/6HH2KPNQfLzrujzcK2K17 sCZPbITCdBcAZGjVRWIeXUOzISJ8Fhc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744789078; a=rsa-sha256; cv=none; b=jHTXPmDpTTz9NGUIKRPhnIwhKOyb/1T1JKIO/GO3v5E1vzKoD0lNseNoceJ0hpNt8xJmPs 9spF04nnaHZG5POks89LxfGLU9+rmhpVPvDAVcQvSf5z/ByrjfcsV8Cf3G05spI51luqSf cm+MkRSlCAkCAO9o+C4gsx6GYdpcslk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com; dmarc=none X-AuditID: a67dfc5b-669ff7000002311f-42-67ff5e51dff5 Message-ID: <00619904-9111-4e75-9ff7-1494ed299f9b@sk.com> Date: Wed, 16 Apr 2025 16:37:52 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: kernel_team@skhynix.com, akpm@linux-foundation.org, gourry@gourry.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, osalvador@suse.de, yunjeong.mun@sk.com Subject: Re: [PATCH v7 3/3] mm/mempolicy: Support memory hotplug in weighted interleave Content-Language: ko From: Honggyu Kim To: Jonathan Cameron , Rakie Kim References: <20250408073243.488-1-rakie.kim@sk.com> <20250408073243.488-4-rakie.kim@sk.com> <20250415170031.0000372b@huawei.com> <6a651c16-7ffc-42a5-8c98-95949073c804@sk.com> In-Reply-To: <6a651c16-7ffc-42a5-8c98-95949073c804@sk.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsXC9ZZnoW5g3P90g5UtUhZz1q9hs5g+9QKj xdf1v5gtft49zm6xauE1NovjW+exW5yfdYrF4vKuOWwW99b8Z7U4M63IYvWaDAduj52z7rJ7 dLddZvdoOfKW1WPxnpdMHps+TWL3ODHjN4vHzoeWHu/3XWXz2Hy62uPzJrkArigum5TUnMyy 1CJ9uwSujK87trAVvOeoWHDgGXMD4z+2LkZODgkBE4m/r5exw9jbZi1hAbF5BSwl/iy4CxZn EVCV2He7FyouKHFy5hMwW1RAXuL+rRlANVwczAIrmSQ+3P8H5HBwCAtESvzsdwapYRYQkZjd 2cYMYrMJqElceTmJCcQWEQiSeDrjKTNIr5DAJkaJn5MOgx3EKWAlMfXpJTaIZjOJrq1djBC2 vETz1tlgDRIC/ewSnf23GSGulpQ4uOIGywRGwVlIDpyFZPksJLNmIZm1gJFlFaNQZl5ZbmJm joleRmVeZoVecn7uJkZgjC2r/RO9g/HTheBDjAIcjEo8vBHx/9KFWBPLiitzDzFKcDArifCe MwcK8aYkVlalFuXHF5XmpBYfYpTmYFES5zX6Vp4iJJCeWJKanZpakFoEk2Xi4JRqYBR9l/hl jufqmU8mm3fWfVjvIxZ9f1Jck983L3FFv0nL2Of63Ih7e+T7tdj67GbPsiWWLBJXor92Nqvp 2Tu77SzivfR/UWGOw4el2qHfzQQTaudpsc2udJrDvuwFw0wbF0EThhde7FvWx3BO2eX/luPY ebODXyW4RWM02Jfc2nflYtufeaeY2ZVYijMSDbWYi4oTAfM9NQqtAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnkeLIzCtJLcpLzFFi42LhmqGlpxsY9z/dYNNvbos569ewWUyfeoHR 4uv6X8wWP+8eZ7dYtfAam8XxrfPYLQ7PPclqcX7WKRaLy7vmsFncW/Of1eLMtCKLQ9ees1qs XpNh8XvbCjYHPo+ds+6ye3S3XWb3aDnyltVj8Z6XTB6bPk1i9zgx4zeLx86Hlh7v911l8/h2 28Nj8YsPTB6bT1d7fN4kF8ATxWWTkpqTWZZapG+XwJXxdccWtoL3HBULDjxjbmD8x9bFyMkh IWAisW3WEhYQm1fAUuLPgrvsIDaLgKrEvtu9UHFBiZMzn4DZogLyEvdvzQCq4eJgFljJJPHh /j8gh4NDWCBS4me/M0gNs4CIxOzONmYQm01ATeLKy0lMILaIQJDE0xlPmUF6hQQ2MUr8nHQY 7AhOASuJqU8vsUE0m0l0be1ihLDlJZq3zmaewMg3C8kds5DsmIWkZRaSlgWMLKsYRTLzynIT M3NM9YqzMyrzMiv0kvNzNzECo2lZ7Z+JOxi/XHY/xCjAwajEwxsR/y9diDWxrLgy9xCjBAez kgjvOXOgEG9KYmVValF+fFFpTmrxIUZpDhYlcV6v8NQEIYH0xJLU7NTUgtQimCwTB6dUA2NE s82F/w1Nv2fYSJzK/iGeYvA/Wez3vHw7gx+iuzmWL5pbIvr8q2jwgsJ9paFvHGUs5KYaBSVc 0np4+rqiuuuOKTK1zWZPP79L0f/JGL/2regTiXl5u+xMP5qmpOU3FgjLr595O3bx5JmqL8oM M5a1Pjteuat49kPrX9NidG0s9K6yijM4VCuxFGckGmoxFxUnAgAA0KX2ogIAAA== X-CFilter-Loop: Reflected X-Stat-Signature: u1py176jbjzqchtynfpjtfuy8ky3ckfh X-Rspam-User: X-Rspamd-Queue-Id: 3407640003 X-Rspamd-Server: rspam08 X-HE-Tag: 1744789076-320216 X-HE-Meta: U2FsdGVkX1+8YtMlc5JG0VKPXu0DFUZiZDBKixyQzQkA+5+abLTsDEqeErzDoVr9CfNCY2Q3JYcUK7GYF1sFppyZYVwhFp50A0g9S+O6mXwID30Dx2jr0akwy/Sj5goNbdRvufDtdCK9aFVUKcSuc7cWXbH/jSnYlFji0aXHCBf9ROhvT2bdiyNJPHJmA2etAgp4ELiMX5MhrZNAinDfnfRCkP8gqj437ixJMvukhoLTCabfW/4T1ntTQbPcUlJfCQH8zl45GIu0urOYCDGVUh3p0N0PWkmD1MMgplehWV/pdSh/KxPQYceP4dV7wX7fFVpLxoR8lctTUJnKtk6Pk25dJQLHpghhpozMKLTHSdJGZ55xSMmVbP+p/bHDU3U6NSE/74KFv+8o/bwpEw5bKD2pTxB7xgN3u2KqMtSut3WETA4wIm8qxnPy1bUksDDGHSVPr3G5VnGM+NjbqC6jlQzJeEVabVVMZV5XXmv3jRuPG59BcECzc7HNWOtaoE2S9ym246iHjucLb0ohpJMKSbMYwCAdezUnCmPIgNyc2B60hXBuPuYOwGqGJYxTiLbJ6c64e0y3cnd2j13YWcVtmFh7WewA/jmZwcFiHBpLtcARmFTzIPDnm+VbFRx8YAfPjlSlKJo8PXN22eJV2G0oN/Qb/0kvRfnkPDWpAr4W48s9Yz+rAoQy/0iWiK3EVO8LyhoKVEAvz7iMwu4/Bt3tVDkSHu+Hc6K/n16/drlMi7rvUpsYKAJI99fab6RrrBMh5QAm/7+e3u74uLuBgJq1aSxIq3zYxDfZYcmY1Bl3Izp8L3j8AxMEzIA0i8JyB/yX+g0QOc0g8PRoBLR/oO87u1+l9sSwTDAQ6bqxNeAwKlz+rKXO84WJLPTlyuy08/b8SZHNkV2bWv7Dn/tx+1bztxnaAhmph2IsmwN3TVrlzQbMRP3BuwQ5TfuWjm599g5Ip7cx/NlMwqGIYr9VWTU X3vpiByH ahY+W/3rdSfLQzzTYQxFzxV6aGxkceKT3KYor8d1CIKqckuCJ1J05+pW4xm9sO2hTmgcMvNpomcNC9V0ta+BQLqMdz+C7LO74T2262T0q7kqC0PRUDnnfBx8Wamg5Ug/3eMmsXx5phYsY0ByHz4YX6tTQCbPErIhnnOlXvUqU/60MALTcbn/8xaO12Fn8xbGbxYo2OB+PGpV+9OA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/16/2025 1:04 PM, Honggyu Kim wrote: > Hi Jonathan, > > Thanks for reviewing our patches. > > I have a few comments and the rest will be addressed by Rakie. > > On 4/16/2025 1:00 AM, Jonathan Cameron wrote: >> On Tue, 8 Apr 2025 16:32:42 +0900 >> Rakie Kim wrote: [...snip...] >>> @@ -3495,35 +3508,77 @@ static const struct kobj_type wi_ktype = { >>>   static int sysfs_wi_node_add(int nid) >>>   { >>> -    struct iw_node_attr *node_attr; >>> +    int ret = 0; >> >> Trivial but isn't ret always set when it is used? So no need to initialize >> here. > > If we don't initialize it, then this kind of trivial fixup might be needed later > so I think there is no reason not to initialize it. > https://lore.kernel.org/mm-commits/20240705010631.46743C4AF07@smtp.kernel.org Ah. This is a different case. Please ignore this. > >> >>>       char *name; >>> +    struct iw_node_attr *new_attr = NULL; >> >> This is also always set before use so I'm not seeing a >> reason to initialize it to NULL. > > Ditto. Please ignore this too. Thanks, Honggyu