From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E99DC54E67 for ; Fri, 15 Mar 2024 21:33:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7A3B8014E; Fri, 15 Mar 2024 17:33:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A27E6800B4; Fri, 15 Mar 2024 17:33:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EFA18014E; Fri, 15 Mar 2024 17:33:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7B4ED800B4 for ; Fri, 15 Mar 2024 17:33:58 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1BCC080943 for ; Fri, 15 Mar 2024 21:33:58 +0000 (UTC) X-FDA: 81900576156.12.94626F0 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf27.hostedemail.com (Postfix) with ESMTP id 5115F40018 for ; Fri, 15 Mar 2024 21:33:56 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kvYKeuYd; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of rientjes@google.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710538436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H0fR8S5zvFKWxYVHlf5dgazwtBnwp1HgnsQ4yUvybtw=; b=z8Wj4L3QCXTa3RFHK2eug74yBAHdBOvx1X8wz9gH4T+fUzq8iWQ6jBRhtPlcpSJvyhx2+L eXA4CrLOpwMk671vPxkVRvIqoBkDHVGwSgJu3deSZr45O7fMbK4Nz9Kkxw3IvElV2Bmb6C 0ZhHHbwzV0tP0lkGCW32CfKpIqszOJ8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kvYKeuYd; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of rientjes@google.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710538436; a=rsa-sha256; cv=none; b=qG+ka0p15bIkhjxecMSHIi39qn6Gua0zm0upsvOgHTfxf9yf5z4UU3SEUKWS7LJsXCsGRk 6RUyLEUpms+DkWE6E9FXaXTIoMDe7LrLcGsHG12t4boJjAZ3ymCCRrDu8SR5lBUb8RO0MW wx4xRGn00UC54ACCHtEPnlZup5c64zw= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1dee917abd5so18945ad.1 for ; Fri, 15 Mar 2024 14:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710538435; x=1711143235; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=H0fR8S5zvFKWxYVHlf5dgazwtBnwp1HgnsQ4yUvybtw=; b=kvYKeuYd2q8CDEVRxG0tgLdZSlFUkM5PEK1bt3HZXlIwsESWBCWfLjoJaQSyQ+ZUts HPDyfFBmthH21rkQP47ZYusYouY+R1Qt77e9phJhUS4j1LsKYxJKnNNtsn6FSPuxU+l0 31BRFDL8EQyrI3JwGmeHT/1HbaS47+c6KnzwVS7woGm+Jfxq+7r0ci1CHVINKnMdTZy3 WKWMkhbE4zDN8Un26UwPDRM7rtNsEYW8A1mK/QDFjGBYVTDG/EhiOecHpRMAKcKCQlXD 6onHGZV0u4s/st8YRW4Ngg4/NNOQ01OnyZ8ofkXNpKtLtfQve31qEJ9i6Metfv/Bn5UJ 8C8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710538435; x=1711143235; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H0fR8S5zvFKWxYVHlf5dgazwtBnwp1HgnsQ4yUvybtw=; b=fl+6pkY7aHU6qcDKG4ogNdeXQ7HLTYKnOUKtcSAq9K75IFeMDsrgDn/kpSwVPi2jjN lukoCs6YzLKl/Dlo00Nd63KlfxnpB9NS6apxNpggTXvvngNb9Lp4GaIl1ySFuF/OJIWR AI+FgUZbi+aNapV6jrxDqi7vnJjkhVeogooJyRazq4fyqA+rRlVyC1Vt8LvqDnTupcqc 0QC3EFSkLkJqQ4+eG1zCjisM0HA3H3R5ddX84jLDtPt9gP16OZ7fNupfMyPXYL3SOtKu u9Ff5phaF8gHXdYYh+R1jhb3v32ayVFQrWSjQ+Mt4oppOfm0UfdAAgbv++bR+WTGlpg8 lKeg== X-Forwarded-Encrypted: i=1; AJvYcCUImlTMphrrLeCjHmuLprKOntPFxPkPnoTxOcO1lpX/Lz/Z3j+CEy0DZ0DUMLWwlfjP+MpiR7QYDkT6J64kCrBf3tY= X-Gm-Message-State: AOJu0Yy/U5KOhr4r5dKzrh+sT8/diB2YEWiz/nO+ia+dfWWi4XUmfz6E Gkb1CnRWbXvMjhLdD1sFmb1xyLVVL/iLhJ6qYoHX0DFeKONCgMZwQfzlDhWXJw== X-Google-Smtp-Source: AGHT+IGXgrCyapbX6lCjIYimjaGV/xGhnyUP0IGlJg+FRlRNpmX3AgagAydyQ+EpK396sF48foPkSw== X-Received: by 2002:a17:902:cec9:b0:1dd:e26f:1363 with SMTP id d9-20020a170902cec900b001dde26f1363mr534470plg.15.1710538434920; Fri, 15 Mar 2024 14:33:54 -0700 (PDT) Received: from [2620:0:1008:15:59e5:b9a4:a826:c419] ([2620:0:1008:15:59e5:b9a4:a826:c419]) by smtp.gmail.com with ESMTPSA id hq16-20020a056a00681000b006e6c8ed17bdsm3829728pfb.100.2024.03.15.14.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 14:33:54 -0700 (PDT) Date: Fri, 15 Mar 2024 14:33:53 -0700 (PDT) From: David Rientjes To: Pasha Tatashin , joro@8bytes.org cc: Andrew Morton , alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jernej.skrabec@gmail.com, jonathanh@nvidia.com, krzysztof.kozlowski@linaro.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, m.szyprowski@samsung.com, paulmck@kernel.org, rdunlap@infradead.org, robin.murphy@arm.com, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com, bagasdotme@gmail.com, mkoutny@suse.com Subject: Re: [PATCH v5 00/11] IOMMU memory observability In-Reply-To: <20240222173942.1481394-1-pasha.tatashin@soleen.com> Message-ID: <00555af4-8786-b772-7897-aef1e912b368@google.com> References: <20240222173942.1481394-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 5115F40018 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: wnu98w6a5wmpumu4cjqzx8i9ka7o37zm X-HE-Tag: 1710538436-983639 X-HE-Meta: U2FsdGVkX19lhQfUkhcbn3jXkQBzhjd+hkTYFeI6W4UG1o9ucqRgbwmXoZB+KkxhrpRm5qgfVFPHjzmapYg5nC4HaA1+8SHA57LI3VXDP1+dKq47tV5bsCe4f7bzzBBcq3QwRy+bFqUAarNUqsY7sYXHmLeSRgNyK9yWtPKnudo00bhpSZO6UZocyFx/p7zG7GN1ZTecGPRTgN723qnJnkNgw4Db+5TekpmaXNz23TFCwGOoFKf/wbx9n8y+wrlJVJUm1t59LqTqiYrasVHVIjAgy6Jv6bqCnVF7ZK2y5Br9UL92HPoqdAVsX4h8lSZ7vUGE+cGVEVP1rqAG1B3lzt7zLF1umQkLGngu35WSeZ5j1MLdetheWojiBHnLSOj5TPq2YwWrcnm8/aLU26OtZRIltbX+g1nsHvC8WgDFPBylyoV87rzUbJrWhoA15smC0kWPkPoCAbSeAgWdsIunPT5CARpPUazhv9hHC+uobmg4DZPtQYvW9X9u5/OQvNflLHasqTc9Y7F6b6N49Bu2kJ+beprObJFePKKUIe5PBafVixAH3gQHKEhTLTsMlW+y8O5k37sr6EbdYaF1VPOzJ1H2SK8783QSzUtoqZMcQ7/bBlP+Wb2kQ4ixfUPTnBAV4lbyjL+QMKI0Hwa/chTf2Oshd9OZSKz5ozNu1SN6erUL3oiv6SuXpDdZNQtwu9OiDle7sfG9dahFi+uDUvgRREo+DdbgD4jdCyrpqxhvtJmE0LVKC1RCHmvUsYnCnLm8airptsvvSLYAJjnwcGpa2K33G4KN6aiiq5/Axzx1rscjVqV1BUseph8FdN1yTBr5bmUo7LvqijvHNpmTUlNP0y91r2HDPS2mW5fCnkGRlw+qFfcAium3FkZkpfKFuFMTgUOFmeneUE6pATVpUmklLlJ4+hUJ9qCOcfdoVXRRsmWj03W3fl8yeyJKVqCi8TmZ8N59AD4BMP9k3/e9euK k92gJzLm 6bYtYE/kw2LXoSMbrbawy28zOkbYXONBeOnzDHfrtEb2oCnuLwjYM+JyFN12DxbMAYAX4clWRpaAxayddXqVmQ+WQo1/ZRYOtT/GOSQkEKD05pepkNGr4FMmuQC4UfLqC4qldvACfFeMB1vj5s+wEMM0fUZsyi8kkWD1cGGACWqGizfuKDZhffowMQ1U+JKmRUFsYGw9kk+G77IeUWFprIXHUbdRAT5OlFYg16D7MJ3V5Q8qFuDj+qGMsyRBGbPZVo+2naqjz8a9RbszYvBgTByxOHLhdQh5g3AGNBuUIpPLfnh0ZTP6B35eXorc0SxymgD/mz7u+eAwwkaf697de2178Ql720qbjtKpLo/vq4owV/iJqhKxVGb4SQMKzC5Drj5x0zOuem9G2dWKz+X0/EJxuVoI/vTsMoqT45qN91SyyVtey0or2bLmHVOQgj2oZSIJdNaOSIb+YAP91WckZtN9Al2QiVEEvn1Nvzk8HnbJUHIzic9+6C5NTi3K9arhl3V6S4vXHG2+xTfYbM1a3WUPG1VqtRx89oCmT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 22 Feb 2024, Pasha Tatashin wrote: > Pasha Tatashin (11): > iommu/vt-d: add wrapper functions for page allocations > iommu/dma: use iommu_put_pages_list() to releae freelist > iommu/amd: use page allocation function provided by iommu-pages.h > iommu/io-pgtable-arm: use page allocation function provided by > iommu-pages.h > iommu/io-pgtable-dart: use page allocation function provided by > iommu-pages.h > iommu/exynos: use page allocation function provided by iommu-pages.h > iommu/rockchip: use page allocation function provided by iommu-pages.h > iommu/sun50i: use page allocation function provided by iommu-pages.h > iommu/tegra-smmu: use page allocation function provided by > iommu-pages.h > iommu: observability of the IOMMU allocations > iommu: account IOMMU allocated memory > > Documentation/admin-guide/cgroup-v2.rst | 2 +- > Documentation/filesystems/proc.rst | 4 +- > drivers/iommu/amd/amd_iommu.h | 8 - > drivers/iommu/amd/init.c | 91 ++++++------ > drivers/iommu/amd/io_pgtable.c | 13 +- > drivers/iommu/amd/io_pgtable_v2.c | 20 +-- > drivers/iommu/amd/iommu.c | 13 +- > drivers/iommu/dma-iommu.c | 7 +- > drivers/iommu/exynos-iommu.c | 14 +- > drivers/iommu/intel/dmar.c | 16 +- > drivers/iommu/intel/iommu.c | 47 ++---- > drivers/iommu/intel/iommu.h | 2 - > drivers/iommu/intel/irq_remapping.c | 16 +- > drivers/iommu/intel/pasid.c | 18 +-- > drivers/iommu/intel/svm.c | 11 +- > drivers/iommu/io-pgtable-arm.c | 15 +- > drivers/iommu/io-pgtable-dart.c | 37 ++--- > drivers/iommu/iommu-pages.h | 186 ++++++++++++++++++++++++ > drivers/iommu/rockchip-iommu.c | 14 +- > drivers/iommu/sun50i-iommu.c | 7 +- > drivers/iommu/tegra-smmu.c | 18 ++- > include/linux/mmzone.h | 5 +- > mm/vmstat.c | 3 + > 23 files changed, 361 insertions(+), 206 deletions(-) > create mode 100644 drivers/iommu/iommu-pages.h > Joerg, is this series anticipated to be queued up in the core branch of git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git so it gets into linux-next? This observability seems particularly useful so that we can monitor and alert on any unexpected increases (unbounded memory growth from this subsystem has in the past caused us issues before the memory is otherwise not observable by host software). Or are we still waiting on code reviews from some folks that we should ping? Thanks!