From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: 'Dmitry Vyukov' <dvyukov@google.com>,
akpm@linux-foundation.org, linux-mm@kvack.org
Cc: 'Kefeng Wang' <wangkefeng.wang@huawei.com>,
'James Morse' <james.morse@arm.com>,
'Alexander Popov' <alex.popov@linux.com>,
'Andrey Konovalov' <andreyknvl@google.com>,
linux-kernel@vger.kernel.org, syzkaller@googlegroups.com
Subject: Re: [PATCH] kcov: simplify interrupt check
Date: Tue, 21 Mar 2017 17:28:19 +0800 [thread overview]
Message-ID: <005501d2a225$7ab66870$70233950$@alibaba-inc.com> (raw)
In-Reply-To: <20170321091026.139655-1-dvyukov@google.com>
On March 21, 2017 5:10 PM Dmitry Vyukov wrote:
>
> @@ -60,15 +60,8 @@ void notrace __sanitizer_cov_trace_pc(void)
> /*
> * We are interested in code coverage as a function of a syscall inputs,
> * so we ignore code executed in interrupts.
> - * The checks for whether we are in an interrupt are open-coded, because
> - * 1. We can't use in_interrupt() here, since it also returns true
> - * when we are inside local_bh_disable() section.
> - * 2. We don't want to use (in_irq() | in_serving_softirq() | in_nmi()),
> - * since that leads to slower generated code (three separate tests,
> - * one for each of the flags).
> */
> - if (!t || (preempt_count() & (HARDIRQ_MASK | SOFTIRQ_OFFSET
> - | NMI_MASK)))
> + if (!t || !in_task())
> return;
Nit: can we get the current task check cut off?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-21 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 9:10 Dmitry Vyukov
2017-03-21 9:28 ` Hillf Danton [this message]
2017-03-21 9:58 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005501d2a225$7ab66870$70233950$@alibaba-inc.com' \
--to=hillf.zj@alibaba-inc.com \
--cc=akpm@linux-foundation.org \
--cc=alex.popov@linux.com \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=syzkaller@googlegroups.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox