From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8221FC636CD for ; Tue, 7 Feb 2023 05:36:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB9066B007E; Tue, 7 Feb 2023 00:36:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B693A6B0080; Tue, 7 Feb 2023 00:36:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BB0E6B0081; Tue, 7 Feb 2023 00:36:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8C8336B007E for ; Tue, 7 Feb 2023 00:36:00 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 53461A94EC for ; Tue, 7 Feb 2023 05:35:59 +0000 (UTC) X-FDA: 80439384438.04.730BD2E Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf27.hostedemail.com (Postfix) with ESMTP id 09FD940009 for ; Tue, 7 Feb 2023 05:35:53 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CI5ICKFh; spf=pass (imf27.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675748155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tSFedBcUm9y0uLVZtEb4Z6r2g2lfpCHHIRAu9e9zPQ0=; b=FFZAwNMGGs3K/399xAFZG/jUm0DXEDBMwdp8adHc6m6evu8MJ73YoTi1qRKFsumOoA8PPK +KZlync0rsMAlx+ypOkkpICtekTGI+81M57T8KYjajABt94xk7cwyjvNRyrutanItyEqEU 5CIuQoKZywEzpvG1HZKSxknk2tDz6+k= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CI5ICKFh; spf=pass (imf27.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1675748155; a=rsa-sha256; cv=fail; b=F5st7T5/xRjC5pXeH9HqsFicvWSDDOgHwDQGgXmgOqdnSkTCY/Q82H2u6nzUD4oW3pR4aV HxwL1ZRytTutEs5WGJU8Z1otwz2N55RMdzf0miwRvB2lrfWCZfsRVci88OBbk4Lf91EwqO asei9gIukGHh158laF7jjLq6VkQmmVg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675748154; x=1707284154; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=xiHmMKVcXcp9hE9UFcrwKToCfDiCJeB8tGqBDM5GNy4=; b=CI5ICKFhanxwKvr45LmQWK5EEnyK0UvwhPYdH8dXGCR7wjxZn6BENeWH ElSsKlhvf4XS+xMIegA5Slf2XFZN6PZUOn00HnR8Z6VH4GpyObLpVSUz1 JIdHfMsWgi9LHs1kOS5zQKtqEkOqszm9BTPf2Me7n2tLx9LVc6HLtOonx 6aTu1ikOBy9ARyfrgl+xaA4ooc2xLGMnHeg6Gim/GqPvK73sGAzHGemzB jNvEC0NG9iIHZxlVEnzgzCL+9wm87BhEVTFu6GZWYXxGhnIiBTk+m/Ehn cx7q9f4gp+JyGwpPy5Gj/i2r/ozgbTSzaTcWbUA0YrfWGVJ0m849kRrX6 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="394010336" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="394010336" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 21:35:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="660091132" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="660091132" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 06 Feb 2023 21:35:52 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 6 Feb 2023 21:35:51 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 6 Feb 2023 21:35:51 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 6 Feb 2023 21:35:51 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 6 Feb 2023 21:35:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=httnAgOTgouTUGF61q9EQI2bxAGwnUBdHaeErllke5o6Uz5ORY8ihWMANNKIjSjM4aItdakEyydchjwGskjokBPSf0+C/PFJerNrQu/jnsA0QMHw3iepMfzY/te0YEE0mKu8lA6mEdHzj5rF0ws0HkOQfQrRjqrrNtygBiqmxUb2Kq9+seyZDpLXiwaRmoHvHi6oO4MRh6y3XetPvPhDY+GuElsooCuK8Hv32l6QPPBHH3wH9Y9qwE+rCDKgqruPM/cFQeH4Rsi+qZZIx34eGCtunZ+NbL8OLglvh9Ybyx+ayvkVcWdz/0r+jx6oNp+JTnZ70RGv/1Q9xPNGEkEoEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tSFedBcUm9y0uLVZtEb4Z6r2g2lfpCHHIRAu9e9zPQ0=; b=SpJRcb8aWC9/lZvxVmNfDvIriNQgFbKW9cs3jXbUBB9fQdM2ObyzFl2PVeLqT/M6OaPQeD1ME44z0Tx+RSFgkq2Ni+xZ5NksCyU34ZWL9HcCsNmXr0XbDo/IqAGAnpAglG3ab6qSUnULrLdoLH+F+q1fdPO93I4tS36UijraKuui6N7oxh3VCwe+/+bEHknUf2qDRWxvgBsu+sWqzKlRRk7i1Xg6HBVz1f7S4jnudI+IlVHk3BV9uGc59Jan2/8J1WEx/ctopfXOXD+hxYWE9INbq53wFFykCBBEflELWfXhw2JFoKb+3Ld1QvLahVyv5IzHwu6AlRLuf/TWqHKnhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB4831.namprd11.prod.outlook.com (2603:10b6:a03:2d2::20) by BL1PR11MB5980.namprd11.prod.outlook.com (2603:10b6:208:387::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Tue, 7 Feb 2023 05:35:43 +0000 Received: from SJ0PR11MB4831.namprd11.prod.outlook.com ([fe80::639f:e273:46f2:88f]) by SJ0PR11MB4831.namprd11.prod.outlook.com ([fe80::639f:e273:46f2:88f%7]) with mapi id 15.20.6064.034; Tue, 7 Feb 2023 05:35:43 +0000 Message-ID: <004f551b-b253-0ab1-bdc5-ccc15a6b3610@intel.com> Date: Tue, 7 Feb 2023 13:35:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 2/2] rmap: remove parameter 'compound' from foeio_add_file_rmap_range() Content-Language: en-US To: Matthew Wilcox CC: , , , References: <20230206153049.770556-1-fengwei.yin@intel.com> <20230206153049.770556-3-fengwei.yin@intel.com> From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR04CA0184.apcprd04.prod.outlook.com (2603:1096:4:14::22) To SJ0PR11MB4831.namprd11.prod.outlook.com (2603:10b6:a03:2d2::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR11MB4831:EE_|BL1PR11MB5980:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d4c7757-3145-4902-7c53-08db08cd2795 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: emTTAAtqF2K+qQLhFWuz6B3IJGxvewXucks4KAKyLOfjUcfDp1xmk+kDw27VdQCniJkyMir+jD6Xq0VifB2PL5O20wbHu3XrdSa04Fyv7yjg+nPljBISxi8GVU2Ry83EbwWN6yngLla8JLVL/CTDXxFRTq3mG5qMPYn39qRdRrYKdIJxfLwW0lEdUlhjYEuGqlf/AfnO9MsW7kJaRmvG4ZjoAYJv7X03t8b5GTJc4VbDUs3F7ubvLl0Kb4YQ1U2LZO7DRJhzqnWRiOO0AdsWPH6+/gdgviuUcnQ0N50eFporaOe4CUnXMNOwEvTyEI5+X6HfvsVlvTi1sVQFUyh3HC4JjlmcUhXtmLapD9ygEtiODy8T2CRevJupsvFY0hB1Tz/LwEznZ9Rjf9DnkjWLtsLDE+EfXX7C83ly9NkYL1kfGDeUX0CMmlmWNcUE/451sE2RgQoaaob3hQ8VmDlO9zNSCi2pPsNc9+BSkvZDdvH737zSMmXMLr95IgNvr4lQSu8Ypx7lmiYCT/Yk0BmuUmOKABBTwRgiTxSxEJo2J0OjX08dbXvjsj6mQ7vAA9dvnCe2pL+5SdBCk5PtF/dyCm2TtpA4VFlAIdjot9TT8RdX9zcR35tq+eUGVCM9VUFvgTgZtCi5NJfibk8+JjiY23Jvr+xOl/kUQMTRaCDNUzP35HgRviFmy6zln16gvebvEFdPxsmsanjJyUOd9c4p4xJkQSXtHq+5bi9mVx2iGSY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB4831.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(39860400002)(396003)(346002)(136003)(451199018)(31686004)(478600001)(82960400001)(38100700002)(6666004)(186003)(6506007)(107886003)(6512007)(26005)(36756003)(53546011)(8676002)(6486002)(2616005)(4326008)(83380400001)(66946007)(6916009)(66556008)(31696002)(66476007)(86362001)(316002)(2906002)(5660300002)(41300700001)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXlJNU92cFo5QzRDM2R2cVJDZnVuWjVTcWI5MGdOdDF5L0FWUFJyTVVpWUFo?= =?utf-8?B?QjhMRG0zQzIxcG9MUHRURjI1Q1VsY1dHNFRpNVNKdjlLUTJhSko1ZU1PdSs1?= =?utf-8?B?cVovaWFXR1luQ2xXUG13Q0Y1djNPNEtwdll0citYYTZycDlpYXJoUDVEK2cr?= =?utf-8?B?UUxnUmlyZm5hdDNET3FNUVFWKzFnYVUrU2xOeXFiMWZFbU1NMjB1QTMwTmhR?= =?utf-8?B?S1FEaFRvK0oxeXZwT09Lc1hlSk9kV0wrKzJ2SW1oMWh2U1piOTIwanJGN2hJ?= =?utf-8?B?WC8xMWkreGgwSklNU0V4Uk5QL1hlZkdPTElFdktzOER5L2ZhM1FsVUxFbDZ2?= =?utf-8?B?SVIzTjdxZHZMNkV6bWZqdzkyc3NIQXBwem85NDNDY0FwRW9vQ3NmeE9UKzBS?= =?utf-8?B?YWljRm4zeHlhRGtGR2QwcGgyVzNCZ0RpYldEL1pHYVBTQWozRUt4bXNQSnUx?= =?utf-8?B?S1RVdU1MU2xJbEFrY1A3TTZZWUFzUkJOcGwwZzhoNUJ2akxXVkN0YU5MUXZC?= =?utf-8?B?Q09memNIN0lGeGhReWNqRlUxNFJGMGRUMWdERGU4K1Z5aHZmNm0wZU9DK3pN?= =?utf-8?B?QUhDdjVsd0kxTlQyQ3I5MEtZdm9JWk0wVlh4MmVpY283aDJheDFyNXcyam1G?= =?utf-8?B?N2hhRTQrS2FvQ1owWnVPY1EyMTlKUFRCcmltc0Exd2liWVFORFc4blJEcDFL?= =?utf-8?B?RVlBdzMwMStNTkY1MUM5UkxkaEltVDRaaGE1UUFGZk15TlJJTVNDd0hudkUw?= =?utf-8?B?Tm9neFdLZFEvejh6K2p2TGE1dVdzZnk5bWdibUJKekxPaGdQQXNlclhRa1NZ?= =?utf-8?B?bXBSdXAxa1IvK2htOVoveXBiN2xWZFNDQjZFSGdZTVp4eklVOGY2dy8xSlNL?= =?utf-8?B?SnNvKzQ4aWZBQnRUR01JZkVQbTRyOTRCY2tQTXlOQWVGODZ6TzNhSCtlOWU1?= =?utf-8?B?ZEtvU0hPMDJwTUtTVG9pZDZ6Vi84U3dhSFpnYlpQWW4zUWRoNi9IaTRsSGxt?= =?utf-8?B?UmY2b2tpeEFtNFhaUkN3dm1LaUtSMW44bjFnUE1zSzZOeVA5TGs0VUhvVDla?= =?utf-8?B?NzN4bWIvVHpIQzA3NUtIZ21jeVBrUll2Ti9yNVVubnFINGZrRDR6TXpabjh6?= =?utf-8?B?SlJRVlBuQ1Y3dHNQbnRHWTQ4SWR5Mno4a21ZY3RNTHMxUjBWYlk3clN1RmF0?= =?utf-8?B?N2VCdGE0YXROVEczQkhKak91L2hhbEhtT3dGUnZsazZPRnVkaHhySm1mbjFZ?= =?utf-8?B?aXhteG5NUFYwbm83TzI5QXVRQy95WFE1U3J1aEYvVWZwOEVlWTZESlBXaE9x?= =?utf-8?B?TjdaNUo4NHdwTUNJYm9RbXI4SzNDTU92bXVDVm9MUzRlbnhuVWtWSU5BN3ll?= =?utf-8?B?TVVPeHNHTHhlcHl1dWxYaUxyUTh0MFJDU1o2VS92TWF3WXlxbnlSL0xDamxh?= =?utf-8?B?dzJWUE5rMGdsK1VhRVNDUnpWdm5tY0ZJeEd3TytRNkIvOWs3emF5WHBhRVU1?= =?utf-8?B?eUJXeENHWTFON2tpQTduaENYL3RQRTdtTEw4d0libitOODVXdjVQV2ZPMXhP?= =?utf-8?B?L0V4eGxRSGZFeVJzYTI3U2tJa2o2Wk5jNGtlODVxNDNXd0VHYWUyWHVmblRt?= =?utf-8?B?cUpvYWNwMnN3akQvZGZCM0lkc3Rzb09YREJ3SkpVTG43Vmp2NC9BSGl0azJP?= =?utf-8?B?Ky94QXFvdzNoTXBUWXR4Z3JmS1J6cTkyZzFmYzRvdGhDbzhDOWVkcXQyYWoz?= =?utf-8?B?SWNZaUVac3RKRy84QXF1TUhkc3FCR2xBTzFibnorRVhKZU1IM09HOXpDY2t5?= =?utf-8?B?VWQ4b3Qxd1BUQ21XcTc3a3VweE9xbDJnMW52OTBYV1hvTDZRQXJnR3IrdEdz?= =?utf-8?B?aHA2K2xGbjRMZ3M5TE96Ly85WWx0Wms1M25DVXRDUWhGYm9JekVIQUNHUGFB?= =?utf-8?B?ekVyUEpEdlVHYWxyRWhlUDcyM2tmU3lJM1JHQVIrV09odkFwZjQ1b1BaMy9k?= =?utf-8?B?RXJwOENSZWV6Rm5rd29Vekc3NHI0b0Z0OTlreEZ2bUxJS2J1ZjhNNWNDSnpN?= =?utf-8?B?d3NJd1JWS1ZVeTBZMGJJTG9wOUkwbVY2eHFmdWt0WHU4bnFPM0JsTWJ0ZFVv?= =?utf-8?B?cUJycXgzYnlIMVg4cVU3OWZIRTdvTmxCK1NTczZNQ3ZNeUVUZG5pdlFwai8y?= =?utf-8?B?Tnc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4d4c7757-3145-4902-7c53-08db08cd2795 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB4831.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 05:35:42.9576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WXZihYk6gEL8hg3nYRRcdrUoQveTSWOXuZ6Rz9DpEEjG1aDCoNNQcQzlhgMIZoQ6SH9/fwJmw2QRoAvBNCWzcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5980 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 09FD940009 X-Stat-Signature: qskrb8c7361jt144sicpzsn99y7z7jc3 X-HE-Tag: 1675748153-56392 X-HE-Meta: U2FsdGVkX1/qMbdDn2tLE/82DxzOqE26+vPBBrzBUzVKpqTrhouuAtk5jR8KOJxklsa/mILL1LZj9RJKljbKLZVQEi61aulTo7uaNVuslwoMJBNHIOipxAr+aAy6SFuvmAlMx+olKOIiyydAfF3jihjqGqzKYjc5iQRaGGXxdspsfY54EgR1jM12SnQe6gsP/aaeqmRMMNbXWs72XzxnLIbIXDn88Y16Hx0wvbgCrMCU+iy7zQDuYrCi7MqEODxbrClLkWKc9IQOCNM3NLTxFSZKp8oogwJh+tdVubYWdFDHWdRtgHpItnYo0NnYngNJFoIjeCRiM4pbnaJKDzlKVZpodH3VDxAtmj38HCoyKDMDbO53c8OeH3CFPfqm5o8MwMvYRITALPP8TnOckzBIenfWynWcftTHCHmIanMtlcBC/Bs0gfV5oNt+gc0qVZFCwGzpNYJSFPRiytSvRyjH0fYRKCcMyq2k3NCtvYwztWwwo+ssSLs6JJugADvgvhNmr73LNpT8/i5d9aixNiPb6UFkOZ+uVmFxBC9QXPtcxNH7F/6I76HPTeDBGHapXg53l8Oog+JzZs5XeouNl6VE/eXm84SOcdOZTNmm16JW4+V9HlBl1rvIIZuBoGftvxUkkUWbqtzdGmAtWsF6dvPIbfWn7Gek/8fVQxl3FbzQWwGpbnCTZg63n/TI8HQE37kySxSn+TI1O6Z5620UDAQYaMThIza+AhtwNfhbsCqZk+QH2t92n36jBaBeqE/w5K3EAYQ6x4JvwO/Zj63tUo5Nvwq4ocg8PWch/vSdwdHcBKLUHq9CqsRJ/SCvnYtZhlPyFBdEiYnqnQ+1IyUWlMqQSYBvKpem+gfWLWomQ9yZ2h4neFZ67JQUMnfjvk07Iapi5OXtpeaNBajGbuz8E8+WXwRmtLgyNXPb6iHMPeNEI5uDv4S4Q2+FdWaveE+XdVYVnG+7EcKcdxhpjw3xWZv UlBAGzJV 8FqFFaQcwdWbHONRGjbx1wjZP9WUT8Um5CyiR5XObnEOToEXy9Z3ZTSFrJGdeauxk+vSV+699SicOKku9M5CNeTSgyhN1ZDXiEK/zcw6w8iSvXIK9jXvASqYGsfZCn17RPyK0Oo9J3ComjZPdn19Tkfmhh71xg/XQfa1liRzCGZB2TJWb2rsxJxmN4GgpTcYdE2rmrB5AgExw3eMPjemOc+SVX/XJyxBuz4eedX8BmieAByxyc+Rc+eq/FXu5vdLh3fyoXk5Lp6eCAFHy1g5CS1vRjXu++kkN1637jbzCE01orukzTSCNEAvpn6gI6XtNn9mVDgxe+9OG7iHomqyYWtxOnQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/7/2023 1:03 PM, Matthew Wilcox wrote: > On Tue, Feb 07, 2023 at 10:44:10AM +0800, Yin, Fengwei wrote: >> On 2/7/2023 12:50 AM, Matthew Wilcox wrote: >>> On Mon, Feb 06, 2023 at 11:30:49PM +0800, Yin Fengwei wrote: >>>> Remove parameter 'compound' from folio_add_file_rmap_range(). >>>> >>>> The parameter nr_pages is checked whether same as folio page >>>> numbers to know whether it's entire folio operation. >>> >>> We can't do this yet. Even if a folio is large enough to be PMD mapped, >>> it may have been mapped askew (or its PMD mapping may have been split). >>> We still need the caller to tell us whether it's been mapped with >>> a PMD or with PTEs. >> OK. My understand is that the info about PMD mapped is only for >> statistic update. Maybe move the PMD mapped statistic to caller. > > Alas, no. That 'compound' parameter really means "to be mapped by a > PMD". And we need to change all of add_file, add_anon and remove > at the same time, otherwise we don't know which counter to inc/dec > in page_remove_rmap(). OK. I thought that "compound" could mean "mapping the entire folio" when I worked on this patch. Thanks a lot for clarification. Regards Yin, Fengwei > >> Another thing I am not sure whether it's worthy: >> What about maintaining total mapcount for folio? So we don't need to >> query each page mapcount to know it. So we can use "total_mapoucnt > >> mapped" to know whether the folio has at least one page mapped more >> than once. >> >> The payback is that we need update total mapcount when map/unmap >> the folio. > > Right, there are lots of mapcounts we _could_ maintain. The important > thing to understand is who wants to know what. As I see it, there are > three important things we need to know: > > 1. Is any page in this folio mapped? > (everywhere that calls folio_mapped() or page_mapped()) > > 2. Is any page in this folio mapped more than once? > (some madvise calls, migration) > > 3. How many refcounts does the mapcount account for? > (splitting, compaction) > > Some of the things we use mapcount for today I consider to be unimportant. > For example, shrink_folio_list() checks to see if there are any PMD > mappings and will split it if there are not. This doesn't fit my vision > of how the VM should work; I believe we should swap the entire folio > out as a single unit. > > So I don't really want to think about maintaining total_mapcount, > I want the concept of total_mapcount to go away and just have a single > mapcount for each folio, instead of this complex mismash of > entire_mapcount, mapcount and total_mapcount.