From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 392F4C433F5 for ; Thu, 17 Mar 2022 09:03:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D9346B0071; Thu, 17 Mar 2022 05:02:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 788FF8D0002; Thu, 17 Mar 2022 05:02:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64F758D0001; Thu, 17 Mar 2022 05:02:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 54C8D6B0071 for ; Thu, 17 Mar 2022 05:02:59 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0DDD0618BC for ; Thu, 17 Mar 2022 09:02:59 +0000 (UTC) X-FDA: 79253288478.09.99F67FD Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id 1343C40011 for ; Thu, 17 Mar 2022 09:02:57 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 00D05CE22A6; Thu, 17 Mar 2022 09:02:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1538BC340E9; Thu, 17 Mar 2022 09:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647507772; bh=5jR6NS47b8GGwMvCf5w42CJoaz/VtwWXpGckhinaMDY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZGUB3zHsAJCDdlGvItS40VqC999vHVSPOTpEBSacfXOoJ1hMdQuATvxpdM0tNbyX+ yFSltpChn8LKVogoaIvO3NBfPg85ZV4Rju4Tbb+MwRrMdCp3OSfbml2sCTJxcLA8b3 RxCtP07lN0zXY+gU3aiYp99k+jBG20qy4kGIb4yGm/A84YGNS7+3miyTQL7lPh5CdQ 1Z29aur9G/a/1dayP24oIF47NM8YcNdqho8t1Vm/eAM1rWhT83d8lK+yw/jjJ/E3il NZxdVxVgpsg9dcl7nyQh5F3LsnTvKyjMI6yfzGsuENueUJsTIKPALgMhxKA8a2kfEQ slpLsCcC04bPA== Message-ID: <002a51dc-e17f-b712-ee15-ec05b647f399@kernel.org> Date: Thu, 17 Mar 2022 17:02:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [kbuild] [linux-next:master 11491/13209] fs/f2fs/file.c:2057 f2fs_ioc_start_atomic_write() warn: inconsistent returns '&inode->i_rwsem'. Content-Language: en-US To: Dan Carpenter , kbuild@lists.01.org, Fengnan Chang Cc: lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List , Jaegeuk Kim , Chao Yu References: <202203171137.0LDg0sYz-lkp@intel.com> From: Chao Yu In-Reply-To: <202203171137.0LDg0sYz-lkp@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 1343C40011 X-Stat-Signature: ictigzc4pf37qbr99oqewr4qaooc4ji4 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZGUB3zHs; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of chao@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chao@kernel.org X-Rspamd-Server: rspam03 X-HE-Tag: 1647507777-79748 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/3/17 16:44, Dan Carpenter wrote: > [ I never understand these emails which are about patch 11491/13209... > - dan ] > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 8a11187eb62b8b910d2c5484e1f5d160e8b11eb4 > commit: a6f748c35eca6eedf2dda8b2a30abd640f1249dc [11491/13209] f2fs: fix compressed file start atomic write may cause data corruption > config: parisc-randconfig-m031-20220317 (https://download.01.org/0day-ci/archive/20220317/202203171137.0LDg0sYz-lkp@intel.com/config ) > compiler: hppa-linux-gcc (GCC) 11.2.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > New smatch warnings: > fs/f2fs/file.c:2057 f2fs_ioc_start_atomic_write() warn: inconsistent returns '&inode->i_rwsem'. > > vim +2057 fs/f2fs/file.c > > 88b88a667971599 Jaegeuk Kim 2014-10-06 1989 static int f2fs_ioc_start_atomic_write(struct file *filp) > 88b88a667971599 Jaegeuk Kim 2014-10-06 1990 { > 88b88a667971599 Jaegeuk Kim 2014-10-06 1991 struct inode *inode = file_inode(filp); > 984fc4e76d63345 Chao Yu 2022-02-04 1992 struct user_namespace *mnt_userns = file_mnt_user_ns(filp); > 743b620cb0516f6 Jaegeuk Kim 2019-09-09 1993 struct f2fs_inode_info *fi = F2FS_I(inode); > 743b620cb0516f6 Jaegeuk Kim 2019-09-09 1994 struct f2fs_sb_info *sbi = F2FS_I_SB(inode); > f4c9c743acedc2f Chao Yu 2015-07-17 1995 int ret; > 88b88a667971599 Jaegeuk Kim 2014-10-06 1996 > 984fc4e76d63345 Chao Yu 2022-02-04 1997 if (!inode_owner_or_capable(mnt_userns, inode)) > 88b88a667971599 Jaegeuk Kim 2014-10-06 1998 return -EACCES; > 88b88a667971599 Jaegeuk Kim 2014-10-06 1999 > e811898c97f83ae Jaegeuk Kim 2017-03-17 2000 if (!S_ISREG(inode->i_mode)) > e811898c97f83ae Jaegeuk Kim 2017-03-17 2001 return -EINVAL; > e811898c97f83ae Jaegeuk Kim 2017-03-17 2002 > 038d06984f5c50a Chao Yu 2019-07-25 2003 if (filp->f_flags & O_DIRECT) > 038d06984f5c50a Chao Yu 2019-07-25 2004 return -EINVAL; > 038d06984f5c50a Chao Yu 2019-07-25 2005 > 7fb17fe44b70c85 Chao Yu 2016-05-09 2006 ret = mnt_want_write_file(filp); > 7fb17fe44b70c85 Chao Yu 2016-05-09 2007 if (ret) > 7fb17fe44b70c85 Chao Yu 2016-05-09 2008 return ret; > 7fb17fe44b70c85 Chao Yu 2016-05-09 2009 > 0fac558b9658479 Chao Yu 2016-05-09 2010 inode_lock(inode); > ^^^^^^^^^^^^^^^^^^ > > 0fac558b9658479 Chao Yu 2016-05-09 2011 > a6f748c35eca6ee Fengnan Chang 2022-03-10 2012 if (!f2fs_disable_compressed_file(inode)) > a6f748c35eca6ee Fengnan Chang 2022-03-10 2013 return -EINVAL; > ^^^^^^^^^^^^^^^ > goto out? Agreed, thanks for the report, Dan. Thanks,