From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A722CC77B72 for ; Thu, 20 Apr 2023 08:55:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2217900004; Thu, 20 Apr 2023 04:55:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD200900002; Thu, 20 Apr 2023 04:55:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C99BB900004; Thu, 20 Apr 2023 04:55:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B709F900002 for ; Thu, 20 Apr 2023 04:55:35 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7CC808056E for ; Thu, 20 Apr 2023 08:55:35 +0000 (UTC) X-FDA: 80701161030.29.18C62C1 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf07.hostedemail.com (Postfix) with ESMTP id 9B9F740018 for ; Thu, 20 Apr 2023 08:55:33 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf07.hostedemail.com: domain of morbidrsa@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=morbidrsa@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681980933; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3oaCtnRgdVnX+/49rnLNjwqRbR+N3XhGwT33lpTGps=; b=fA7VCpB7bUu5garP86RzDM30rhe7oubrawAiINlhuQ5Lbr82yJthuWZBQ92GtW4giwVJ2/ 20plBdjA2ckYiUXKDGtUYiw7wQVefCXeyIqbkxkj7QzJgbR0PHDsmjS5+9FGcIyrzc4hBl Hmui5+4rMkf3E/ivChNNYThtxRBVNOE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf07.hostedemail.com: domain of morbidrsa@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=morbidrsa@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681980933; a=rsa-sha256; cv=none; b=lZXf3ae4SCVxDu80G4141vkL+iJmC5q+R07HKOGb6P/NYJ5McPpuTMUUcytHUYGon88AHe 5hrzX1lWqPsVq7IK7PEYytGsTQU6VhacE6IZGelWh2Wvx8xC49viJZ5SsMVFm3glhlZN6a nt98F0Gfja4o6l5sh+aaS2vOgToqBqI= Received: by mail-wm1-f49.google.com with SMTP id n43-20020a05600c502b00b003f17466a9c1so2701294wmr.2 for ; Thu, 20 Apr 2023 01:55:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681980932; x=1684572932; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z3oaCtnRgdVnX+/49rnLNjwqRbR+N3XhGwT33lpTGps=; b=Ogg1qaQDl6NciGeUzien6orvW8z6njtTdpfupMdG3uhVfBVfb+38hryKAQZNKVgV9X vPZ3+NVb0Xz0UVthRAZJchfUHm509ail+yoJTJ8CnoaP/KUlbXlboHGT37j2Hs3MmCd2 JX6ykMS0C1j73NapUes1G4AH4gZyzzyGRdpUoY+En8I7zgk8kssvKXSbzSwB5GGarbmM FpsK2DWvF6Se6Mzx2WpZTSx1vASUVgQfcZmjOFYsZF2tJ/QvC2s6aSW7LI748yLNwCde RjHv8Airqb+m6IXMn5up4zpeaGFiNS3QAq1u1KK60tcb/ZW9vbtENaSy6R1KDiCG2WzZ oH8A== X-Gm-Message-State: AAQBX9fpzpwSFuOu+xJcF3KVgpv8YLyWLhfxSASaPkUIKWcF4NLdtQoH 0FGUnSPpHO2RqmvejsgguxU= X-Google-Smtp-Source: AKy350bKYLeXMzDzDJ6Y6qo/aThxWX/i4drIepoJR2AxRlr5KQ8S+fMnYJCtI7ItM3tNru7pKV43XQ== X-Received: by 2002:a05:600c:acf:b0:3f1:72e6:2a69 with SMTP id c15-20020a05600c0acf00b003f172e62a69mr740456wmr.4.1681980932068; Thu, 20 Apr 2023 01:55:32 -0700 (PDT) Received: from [192.168.32.129] (aftr-62-216-205-152.dynamic.mnet-online.de. [62.216.205.152]) by smtp.gmail.com with ESMTPSA id ip29-20020a05600ca69d00b003f1712b1402sm4669681wmb.30.2023.04.20.01.55.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Apr 2023 01:55:31 -0700 (PDT) Message-ID: <0028b1b9-980a-4b3b-b290-099368e44f9f@kernel.org> Date: Thu, 20 Apr 2023 10:55:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 11/19] gfs: use __bio_add_page for adding single page to bio To: Andreas Gruenbacher Cc: axboe@kernel.dk, johannes.thumshirn@wdc.com, cluster-devel@redhat.com, damien.lemoal@wdc.com, dm-devel@redhat.com, dsterba@suse.com, hare@suse.de, hch@lst.de, jfs-discussion@lists.sourceforge.net, kch@nvidia.com, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-raid@vger.kernel.org, ming.lei@redhat.com, rpeterso@redhat.com, shaggy@kernel.org, snitzer@kernel.org, song@kernel.org, willy@infradead.org, Damien Le Moal References: <20230419140929.5924-1-jth@kernel.org> <20230419140929.5924-12-jth@kernel.org> Content-Language: en-US From: Johannes Thumshirn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 9B9F740018 X-Stat-Signature: 5fjg5yj87dhn64ikw3o8qroy6bxhu9kw X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681980933-716870 X-HE-Meta: U2FsdGVkX18ZVlm6QCY+dzGeeONSYF+l/IJayZFNK6r23pbS07kE9NwuSbrM9FL9O3XPuZqhL1Lao/8nH3uV8zndqeGhKDy30d7Qvp1tc0hLHVQcNUQsDeIWLi3UAvZZl1xgUVWfQcRQL0eO9m5sEfH5L5lb+RmcDrJm73V/w1VpQkkSgTZO2MaqCfsFg9CxPcZSnjv0j5yrNOSTFD/Ub7jXndPpM6Zsy0+y44nNX5GOCW5+3gtTEfa8wWgEbZVpOXP8DTBKbwW6hma7C6td5zKykrzGaI7v+tdakalWWZSnhEvLv6z+3XnunLVC+Gq+NYksGKYK1p6+2qk5UxTtdxxf9EAzx5cP7H5CiXXE8LlA8017pTDegyKieksm1gCJPXSqO8XnbPSBeQ/4ssY8Dfr0LfkkAR33/cCEJfVVwxyBOdYMkXCasXAVHsm/DzUKR9byrZ39rx357aK7xLF/sQB8JmYSDVhicMqrczB+sNGEdk14Qx8gkvs2MiZkDdO32eFMIFaWGTb3UsbqzOSbXRgV5pR00gK0v1nvDfv65XAqZLoRL8uh+ye8rmZ/tflGoL30TFIqCcDLMqeInxHg7IIbpXZdfuMSKqRrV4qiArfcCDfNyGBYEr+iPbtLXdwz7eIoBvsaHrkNXOM1yrafOAM+J8Xh89rNTE9ihEpbi/dmAbX1I7/VJEW5xUo5JS4p8dq0NFaU9gmXVMckoFftqMzjv4Q1orVCVCpg+zSQlGGV6JwRvXw0t5YBtbEbHSCQ0n+nc3A9mKXe+w3boBJ+G0405JicEN1K6buWkKZffsShXbBFvDnXdZBoVn7OSuANZkmPPdz17WBY+MkUGe3GaKU0Ksi07vyGVX42q7786VrvUti67XyYJefY4XcLEMgAkfvBre3PiEqjyEPL1Eufa/cOZj0n3K6yreP7rhwtg67lX6yAY0hqmEuU0y/rfOhM/ntPhfj4YOMo8MEnqB+ Pe8sPyrH r7OAKDavz0/6O40z0h+Ve7OibyEZFiv1K/8+R2qIo7PrSYhSorl9TXhJa6jcdDmpArkkRy94y0RSrnSREa+AO+er2IArBpcJ9xyYSaRh3RqLIZBwJC4bUrwujp65/TS+92mgWG76LE/cdMmB9+9PMXx5U0LXYLVxy9rfNPMUK7UTPcWyHr6izUNPfZ6Z0W0vAEOsEZN/OhSTmDmu0l1Zwdq/b2Zz1ABq1KtkxhJ0uyEGLuK+s70+8EyBPNfszt63VFhkt6k2RElKmuKzmfmQzEqLVIvyHvxmwcXySHN67I0GNy6zlViN7/CY95VNkGzCdfWdRJ9nHy51lDLx+Q5Rxzz3n+XMpveLDpgKZKj3y75RbcPpAp+xj8U0paNpO/4Dxko5MQuu55++Ii7Ti4rLpxtmLdaLlUlr/T8iiTY9Ky3YNOkPo1d22JuZU35mDTgW1v/9zSkZ/gCfNBoSQYbD/2lgWBd921mTFavsJC52eKNk1rW1SOlpIUxOvuinW6Q52Gk4OR2XeAKTGFyuUXAWtcz5UkS728ixXO4I6xfier+L8tXIC8NZXBhrO9JE2BBl0gh50kdI+uBbRYhePfqAu5wcCuQejvFE+P7ifN+d4T0RtHGCOEWME9FVHUxPMwJlqbYNB3HaU4XuXHlQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19/04/2023 17:19, Andreas Gruenbacher wrote: > On Wed, Apr 19, 2023 at 4:10 PM Johannes Thumshirn wrote: >> >> From: Johannes Thumshirn >> >> The GFS superblock reading code uses bio_add_page() to add a page to a >> newly created bio. bio_add_page() can fail, but the return value is never >> checked. > > It's GFS2, not GFS, but otherwise this is obviously fine, thanks. > Oops fixed in v4