From: Johannes Thumshirn <jth@kernel.org>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: axboe@kernel.dk, johannes.thumshirn@wdc.com,
cluster-devel@redhat.com, damien.lemoal@wdc.com,
dm-devel@redhat.com, dsterba@suse.com, hare@suse.de, hch@lst.de,
jfs-discussion@lists.sourceforge.net, kch@nvidia.com,
linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-raid@vger.kernel.org, ming.lei@redhat.com,
rpeterso@redhat.com, shaggy@kernel.org, snitzer@kernel.org,
song@kernel.org, willy@infradead.org,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH v3 11/19] gfs: use __bio_add_page for adding single page to bio
Date: Thu, 20 Apr 2023 10:55:29 +0200 [thread overview]
Message-ID: <0028b1b9-980a-4b3b-b290-099368e44f9f@kernel.org> (raw)
In-Reply-To: <CAHc6FU6U1yZguZGeCc7BUqd1Qm4+SSRK8xbNZWBUSXTk_jjvVQ@mail.gmail.com>
On 19/04/2023 17:19, Andreas Gruenbacher wrote:
> On Wed, Apr 19, 2023 at 4:10 PM Johannes Thumshirn <jth@kernel.org> wrote:
>>
>> From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
>>
>> The GFS superblock reading code uses bio_add_page() to add a page to a
>> newly created bio. bio_add_page() can fail, but the return value is never
>> checked.
>
> It's GFS2, not GFS, but otherwise this is obviously fine, thanks.
>
Oops fixed in v4
next prev parent reply other threads:[~2023-04-20 8:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 14:09 [PATCH v3 00/19] bio: check return values of bio_add_page Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 01/19] swap: use __bio_add_page to add page to bio Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 02/19] drbd: " Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 03/19] dm: dm-zoned: use __bio_add_page for adding single metadata page Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 05/19] md: use __bio_add_page to add single page Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 06/19] md: raid5-log: " Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 07/19] md: raid5: use __bio_add_page to add single page to new bio Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 08/19] btrfs: repair: use __bio_add_page for adding single page Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 09/19] btrfs: raid56: use __bio_add_page to add " Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 10/19] jfs: logmgr: use __bio_add_page to add single page to bio Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 11/19] gfs: use __bio_add_page for adding " Johannes Thumshirn
2023-04-19 15:19 ` Andreas Gruenbacher
2023-04-20 8:55 ` Johannes Thumshirn [this message]
2023-04-19 14:09 ` [PATCH v3 12/19] zonefs: " Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 13/19] zram: " Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 14/19] floppy: " Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 15/19] md: check for failure when adding pages in alloc_behind_master_bio Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 16/19] md: raid1: use __bio_add_page for adding single page to bio Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 17/19] md: raid1: check if adding pages to resync bio fails Johannes Thumshirn
2023-04-20 4:39 ` Song Liu
2023-04-19 14:09 ` [PATCH v3 18/19] dm-crypt: check if adding pages to clone " Johannes Thumshirn
2023-04-19 14:09 ` [PATCH v3 19/19] block: mark bio_add_page as __must_check Johannes Thumshirn
2023-04-19 14:19 ` Matthew Wilcox
2023-04-19 15:49 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0028b1b9-980a-4b3b-b290-099368e44f9f@kernel.org \
--to=jth@kernel.org \
--cc=agruenba@redhat.com \
--cc=axboe@kernel.dk \
--cc=cluster-devel@redhat.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=dsterba@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=johannes.thumshirn@wdc.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-raid@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=rpeterso@redhat.com \
--cc=shaggy@kernel.org \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox