From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55ADBC6FD1F for ; Sun, 19 Mar 2023 12:07:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A8A26B0074; Sun, 19 Mar 2023 08:07:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95A856B0075; Sun, 19 Mar 2023 08:07:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 820246B0078; Sun, 19 Mar 2023 08:07:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7255B6B0074 for ; Sun, 19 Mar 2023 08:07:50 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3EA0D1C5C22 for ; Sun, 19 Mar 2023 12:07:50 +0000 (UTC) X-FDA: 80585523900.04.EA5F467 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf23.hostedemail.com (Postfix) with ESMTP id 6FD18140017 for ; Sun, 19 Mar 2023 12:07:48 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=odDNsKig; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679227668; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=23VPAup5yLjI/9do121HjMU7OWFbvJtP6xCL1xBAHA0=; b=DQQRVw0436eYEwRbszpRRFI1mQmTNxLP90Q29+me0RllNmwCCgBT3PuGFpvI3gKpXo93IX VNxkF/Tf7Ok57QVuIHOJyM/WQuhVOdGlzpvoHQUREvemY0tO+Ke4V3YT5ZXSgkWuLDQ34m X+/2V0oE3ps+HqMhG0y72cp97um+XfU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=odDNsKig; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679227668; a=rsa-sha256; cv=none; b=hEtGeSpMqCgFV0p9i221wBVxSDar/vM8DciMgC/dyvxBM3DOG38eysHLOVKOT3hQeQ81YN W746uBYiEED97d0x2zA3qbKXsXjf1SgK69bsOhV4jHLTbAdPgd/pREgNtWD2L2DUdnw6W7 WEcOISJ1h/woDX8T1Es1bUhV9ykVqQs= Received: by mail-ed1-f50.google.com with SMTP id h8so36761531ede.8 for ; Sun, 19 Mar 2023 05:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679227667; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=23VPAup5yLjI/9do121HjMU7OWFbvJtP6xCL1xBAHA0=; b=odDNsKigCA5xnnfue9ndJstTBppyRIWeCpYfGNZ68Gzpk1yvBkuTOMyn9+O8/+PHOz VAc4V84vUPCNf4b0d3yQoiZMGC0xUQIuGW4TudauejzRJnptOgNRAxykTxLo9m30K1pS WDPmDnWl+cXPk6UzKYrwoTWUbavntOFXnsGeOeHQy/jYTCvwcfEItKXXY3YTcJQnUrtH 11kefEj4C3+C/L5oPAgV1GmqxsZkhq92ox6IBqKH8Nyer7ydVNLeLIWEHA0GGIuAUnYP QVncHkYliK45AwhZgoKnwWCvx5Nx3K8mThc7lp6Le92ZCGtTgpOwhdF7kHNVVIxKAmC/ e7oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679227667; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=23VPAup5yLjI/9do121HjMU7OWFbvJtP6xCL1xBAHA0=; b=VjcZ5STxAUsjm8Xe6QT6j+O79ipWVXISzfiuUfhMhqvqQYxqfR20faVSxCW3M2ZGTg l0zBrHsaZwNX2lO/bLSyV3HNo3UY6t9CaCMHnIKDadbhR7wpuwzsAdwnoPn117XmdBhn z5nfqvExpV0uTJ3EOcC7Ee3oQGHFQoBrWsNRg6+7X+wyVOczHxR0Of9W/dsIFNtsz4xN mR5yIekbgV5uHaIwUR0fIBT5mNrYqQMgSSOQecM1pDdYFBXAto1lQ1z/OQ6bCbMumfDf D06zh41EQEA9spOXgEvXpKio3XFBUuNft8bzTnrU5PWOEhdg17F5uvM76/nhxNRpWMW/ D6xA== X-Gm-Message-State: AO0yUKXjpa3DnLqySGhK9TmwRyvXCzGm0f3e3vINOA5BjbnQPuTVQ28l OMOS113s8vCOkz/VoQgM/f0= X-Google-Smtp-Source: AK7set87vZgAzbm1Sp9wrmGlgUY+aL4G2jxaEbb04ckGqdMY01nDoDXlZMT8w37ZsN4MQ8+1MsQpgw== X-Received: by 2002:a17:906:ecf8:b0:931:4f2c:4e83 with SMTP id qt24-20020a170906ecf800b009314f2c4e83mr5573234ejb.63.1679227666740; Sun, 19 Mar 2023 05:07:46 -0700 (PDT) Received: from localhost ([2a00:23ee:1938:1bcd:c6e1:42ba:ae87:772e]) by smtp.gmail.com with ESMTPSA id t1-20020a170906178100b008d1dc5f5692sm3161172eje.76.2023.03.19.05.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Mar 2023 05:07:45 -0700 (PDT) Date: Sun, 19 Mar 2023 12:07:43 +0000 From: Lorenzo Stoakes To: Mike Rapoport Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: move get_page_from_free_area() to mm/page_alloc.c Message-ID: <0020b728-724d-4206-8768-ec94d5628b34@lucifer.local> References: <20230319114214.2133332-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230319114214.2133332-1-rppt@kernel.org> X-Rspamd-Queue-Id: 6FD18140017 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: mkhcuf5wch1bbcoimokpj5fgzwbtjgkc X-HE-Tag: 1679227668-263250 X-HE-Meta: U2FsdGVkX1/K2I2OaKbHM/ZPV+BXme9tMyYe83gcW5Box//GHb6e7gb93u433BRTuCgJCXlTddfWqpEnWcBxIksLDz7d/idmjj7kG6ahtcORYCwlOvUf8CH+Mv3SGZQu9krkSXYtbGkclIfB/FCQGBXbbPfrqR/cB4VHzbri2wPjcsVUmX70HBUljlIHVOZnAukEKzpUo5vfrrKZwvQVVFZmM3uKBRxYAVzed6dtqc/Nm6FXoszi2wgn9Cj6nOlypfQ1oU2+Vs2GJDPamnRMPNQ07CUc9bcfpZIZj34z0s0Ol8yRgulzWq20E+GSiexj8/MtECXMXA5yminWOumgTp1FK97RB2yZeDyeJg7Il2BmlVxyj9oz7P0xqITiwrZvqocM55icvcS3Kdqo46xZFvm1+RPBRSQxvVJ1hgpk3KME6mZHn3KoQVbaKGyqK1XpVQOlWcjThT1hWY1exu5gheut5j7dI8oeS5m3kCXxlaRMaL8o5Gdnwuk1QxzWfJ3Q5GNqhfgvVx6RIj73R9VlEIxGAoFKSzfYEPsQmpKHxS8ZjjXsSHslVZjpChkwlm/u+hjYkyxqeTIMiHUKV15Ms8w2/XfNm+c2IMhrsKSCUBphqRAIeMGRX604gXyMCDXm/gnYZLnNf/6PenFCD5FeMti6QDtIuO43RvPKm/GCm6U2j/8tJGfq40f9RWcZnTmKS3AZAviIaeie7gPu0LQJaRGS5SAgsuXx/ph/+ya7mIH5+fjUbByi1J4XB8vnDit8J4s7WH1DqK05vtiHJcJDR+3mx9mjcQfjOXCGu4i9guvFTbvXT4du9sv5jdNh8FdL5ulW3exgqKVVRshxYa1C4gmr2jGMpDo15lUnuMPwKcVJ6SN0p9z9vencu2JODe8TbFfd9TpJvHklcSpY7TTyo5BHYMoZqS0yJvzxS3t5sUTnvc+nIx4qo86TRvIR23qTjDCNYz9t6oIW2RMezq9 zPfgAq9y vX7y4Spm3drxkqxjLIl5AvekRMRQvLs6XluMmYT5T2/L4x85lBBDKASn4DiubcarCidMDdp+o+Yh9WNwni4WY7sfBJ0JbTkfD8ZscX4qnVAjPpJOjQV9klEEG+Lpn7gZguOEMioYw3QnerAiLg3S7D6Oux8u8eMsR0xwYJXeiadlodCa7TNbs8UjwOKMdSqxrnHupnnz60MxsW4lmrUpSrV6yh6LmE+Md8XFzI+sSlt0w/NIfzpKNNAQDVc4WZFztHkXD1/J+Fwpq5G9ANg7NyQeyQZjvrcY21cuWQ5V3y8N9GIBeP4Ihm50VjMH9vzaQcaj1F3d52i24lNCTa1qXCYRefhz80+qjl6tUbCQ8Itd0MC3ZJKgh7i1M5WVrNZAequYRBQQAOO5A6JDUz6Fc+0AiT/eWyxrGbYiGjn43gRnwXRb1SrO4xW9Exf0SXtaw6QmJGF92Dt5V5S/KwFmNc3xgGlVyGkQYw4CRCIotzXg5g7UtD+aCq7EUxG+pGwQP5FCBdzOowkrkjpYfLz6v4SvtLT50BEKPyGqw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 19, 2023 at 01:42:14PM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > The get_page_from_free_area() helper is only used in mm/page_alloc.c so > move it there to reduce noise in include/linux/mmzone.h > > Signed-off-by: Mike Rapoport (IBM) > --- > include/linux/mmzone.h | 7 ------- > mm/page_alloc.c | 7 +++++++ > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 96599cb9eb62..8f5a9e2c722a 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -108,13 +108,6 @@ struct free_area { > unsigned long nr_free; > }; > > -static inline struct page *get_page_from_free_area(struct free_area *area, > - int migratetype) > -{ > - return list_first_entry_or_null(&area->free_list[migratetype], > - struct page, lru); > -} > - > static inline bool free_area_empty(struct free_area *area, int migratetype) > { > return list_empty(&area->free_list[migratetype]); > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 87d760236dba..2e72fdbdd8db 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1048,6 +1048,13 @@ static inline void del_page_from_free_list(struct page *page, struct zone *zone, > zone->free_area[order].nr_free--; > } > > +static inline struct page *get_page_from_free_area(struct free_area *area, > + int migratetype) > +{ > + return list_first_entry_or_null(&area->free_list[migratetype], > + struct page, lru); > +} > + > /* > * If this is not the largest possible page, check if the buddy > * of the next-highest order is free. If it is, it's possible > > base-commit: 4018ab1f7cec061b8425737328edefebdc0ab832 > -- > 2.35.1 > Good catch, I wonder if there are more functions like this that can be dropped from headers? Reviewed-by: Lorenzo Stoakes