From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f70.google.com (mail-pg0-f70.google.com [74.125.83.70]) by kanga.kvack.org (Postfix) with ESMTP id 3F0AA4405CC for ; Thu, 16 Feb 2017 03:21:11 -0500 (EST) Received: by mail-pg0-f70.google.com with SMTP id z67so15773442pgb.0 for ; Thu, 16 Feb 2017 00:21:11 -0800 (PST) Received: from out0-157.mail.aliyun.com (out0-157.mail.aliyun.com. [140.205.0.157]) by mx.google.com with ESMTP id 34si6273644plm.193.2017.02.16.00.21.09 for ; Thu, 16 Feb 2017 00:21:10 -0800 (PST) Reply-To: "Hillf Danton" From: "Hillf Danton" References: <20170215092247.15989-1-mgorman@techsingularity.net> <20170215092247.15989-4-mgorman@techsingularity.net> <001501d2881d$242aa790$6c7ff6b0$@alibaba-inc.com> <20170216081039.ukbxl2b4khnwwbic@techsingularity.net> In-Reply-To: <20170216081039.ukbxl2b4khnwwbic@techsingularity.net> Subject: Re: [PATCH 3/3] mm, vmscan: Prevent kswapd sleeping prematurely due to mismatched classzone_idx Date: Thu, 16 Feb 2017 16:21:04 +0800 Message-ID: <001f01d2882d$9dd14850$d973d8f0$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Language: zh-cn Sender: owner-linux-mm@kvack.org List-ID: To: 'Mel Gorman' Cc: 'Andrew Morton' , 'Shantanu Goel' , 'Chris Mason' , 'Johannes Weiner' , 'Vlastimil Babka' , 'LKML' , 'Linux-MM' On February 16, 2017 4:11 PM Mel Gorman wrote: > On Thu, Feb 16, 2017 at 02:23:08PM +0800, Hillf Danton wrote: > > On February 15, 2017 5:23 PM Mel Gorman wrote: > > > */ > > > static int kswapd(void *p) > > > { > > > - unsigned int alloc_order, reclaim_order, classzone_idx; > > > + unsigned int alloc_order, reclaim_order; > > > + unsigned int classzone_idx = MAX_NR_ZONES - 1; > > > pg_data_t *pgdat = (pg_data_t*)p; > > > struct task_struct *tsk = current; > > > > > > @@ -3447,20 +3466,23 @@ static int kswapd(void *p) > > > tsk->flags |= PF_MEMALLOC | PF_SWAPWRITE | PF_KSWAPD; > > > set_freezable(); > > > > > > - pgdat->kswapd_order = alloc_order = reclaim_order = 0; > > > - pgdat->kswapd_classzone_idx = classzone_idx = 0; > > > + pgdat->kswapd_order = 0; > > > + pgdat->kswapd_classzone_idx = MAX_NR_ZONES; > > > for ( ; ; ) { > > > bool ret; > > > > > > + alloc_order = reclaim_order = pgdat->kswapd_order; > > > + classzone_idx = kswapd_classzone_idx(pgdat, classzone_idx); > > > + > > > kswapd_try_sleep: > > > kswapd_try_to_sleep(pgdat, alloc_order, reclaim_order, > > > classzone_idx); > > > > > > /* Read the new order and classzone_idx */ > > > alloc_order = reclaim_order = pgdat->kswapd_order; > > > - classzone_idx = pgdat->kswapd_classzone_idx; > > > + classzone_idx = kswapd_classzone_idx(pgdat, 0); > > > pgdat->kswapd_order = 0; > > > - pgdat->kswapd_classzone_idx = 0; > > > + pgdat->kswapd_classzone_idx = MAX_NR_ZONES; > > > > > > ret = try_to_freeze(); > > > if (kthread_should_stop()) > > > @@ -3486,9 +3508,6 @@ static int kswapd(void *p) > > > reclaim_order = balance_pgdat(pgdat, alloc_order, classzone_idx); > > > if (reclaim_order < alloc_order) > > > goto kswapd_try_sleep; > > > > If we fail order-5 request, can we then give up order-5, and > > try order-3 if requested, after napping? > > > > That has no bearing upon this patch. At this point, kswapd has stopped > reclaiming at the requested order and is preparing to sleep. If there is > a parallel request for order-3 while it's sleeping, it'll wake and start > reclaiming at order-3 as requested. > Right, but the order-3 request can also come up while kswapd is active and gives up order-5. thanks Hillf -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org