From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ACC5C001DF for ; Thu, 3 Aug 2023 07:13:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C620E280212; Thu, 3 Aug 2023 03:13:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEAF12801EB; Thu, 3 Aug 2023 03:13:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB443280212; Thu, 3 Aug 2023 03:13:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9C12B2801EB for ; Thu, 3 Aug 2023 03:13:32 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 675761A0FFD for ; Thu, 3 Aug 2023 07:13:32 +0000 (UTC) X-FDA: 81081927864.06.A6492A1 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf25.hostedemail.com (Postfix) with ESMTP id 07E32A0015 for ; Thu, 3 Aug 2023 07:13:28 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691046809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bfnWUmybOASh4SzI+B4XsNtzfSfxUE4WKjHgSW7oyKs=; b=qjPAZvy82O1kWFGHeXhBpm/LCpQBgRVSK1RwFBXD34QmGGJWUgqRAs9+O/3ifktMjJE3Dy MD/KP7FZjTVm41akhjAdzrySKrv+JoH4SCFi82UJlmxS14dXnjhqo0a+HOToc1me66xQii vfABjNVCKxjkzKeNaui+SveRqSNJ83U= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691046809; a=rsa-sha256; cv=none; b=qfM/4E1vxNGRAGI7W0Y6ogWIq4/8FBZ0XYhjmLb1IN6WOA0LKszB9BXP5fHeHtZL2Qv1nM sFSQW43V93huCQdqWhlnLeA8ofmoXGjd+PRnBukuvsIfCfTHrGee0ySZyOK7WtI6IlTNmF T3vXUwfOY5opZTLg1zva91Vl2+U4kW0= Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RGg5Z18SSzrSCD; Thu, 3 Aug 2023 15:12:18 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 15:13:21 +0800 Message-ID: <001ee9b0-ea25-a896-e3ae-9a9b05a46546@huawei.com> Date: Thu, 3 Aug 2023 15:13:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 From: Kefeng Wang Subject: Re: [PATCH 1/4] mm: migrate: use a folio in add_page_for_migration() To: Matthew Wilcox CC: Andrew Morton , , , Huang Ying , David Hildenbrand References: <20230802095346.87449-1-wangkefeng.wang@huawei.com> <20230802095346.87449-2-wangkefeng.wang@huawei.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 07E32A0015 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: izcen4h3t7a4uetot78jp6sjo6yms8k6 X-HE-Tag: 1691046808-910895 X-HE-Meta: U2FsdGVkX19/7SzwTQbsckZkw24bysiQ/ymVCx3oqY+CsnrXoaCK6B1KTzlwsZ9OAGngWFqEf2J3tQJw0+yF/JPpFsx4DbF6NMjzFsuIuIv2r2/8820HSKuxnXWg35kuY/7J7BD9f4oOEcbNoZtiKzP3FTzLnkxZDRoI2TcUmFwyrRt1OpEp9SHCusf+2kTMmp05C+3Vz9xuHsNwxmtevvFJY5AswsS7HD5A6bcUa1gnpK2BBD3DBbmKCeZviEEP2563FyHgLeAaEnc1Z7J7BO6EIls2NqzPv9132Z5Sr6A7pGSKu8NNNMtFRxs1JGC3j9eqd3LA+/rkq/WLmGsgtcrUjTeJqZ8I0sVn2YvOz/B2uuVZA/5TeiV0a/6LaPbTTXmInYjgtBQuuTqKvtwuqMcwO4UAzLZkwIKUzJQIToC/Y6xydGE5oK9v2CJKqg12Bmd0217FUldW2U7Ka0In3pCiwCnOZtY8rPK8ycbGSidIz8xVGWSKJuMasP9gv+oAsikthbi+C05SvdCeQqjQMbxxKVS/SNUCuZ5FWdrhfAEgi6pQAEpTula/iUm9NgRil7Er0I3V+sSPVNxu/dkHYHa61oYKDAgb7kVDo7QWm2e2Zb3y7qTukk1wmA0sKyslRJOJiZCABtvx6f34InCepqmGWeCX0zmIUhKkyrU6bh0wc2Vt/nbM5xpLT6+mxnb4p4VxoMOjYogBPxTqHredZ5L/GDC8h1TthVJrUZRKsWecio9M3gPwSh0zgiX1MF2Bo25apdAwnj13L6u4u05vAoQAX2qx6INZLyl6g10z6Sd3qu+c7vqK52SkO4Fy7vzw/3iyiOjQKrl8ohrmi4+gYgnKplSOasiYuwQDakXOY7IXBFwolwg27WEUVjCr20CysGcYC5aaLjo2GigsPLwjmgtCZepqpZJt6W3RSejJznSlHG0yG2LPjsprDsCbi0HAKRHrbRcrcIOJVH3tTTh qoifYZdd VR0Xhn749efiPA5OQDDcQEZz6TvWQ9pedSLubNhxv+yAuRybmlGbmF11QC1R51XfOvLCfNwqweGpFN1rRv06g47Re4NZY8RtMGpWKusavT6UfbqxMQV5eYXsoQ1pGts+Q75dvsNns4dkxJUIIiPyh+eizTGnReVZ52cR4y2OUUmVuCXormELbPWg83g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/8/2 20:21, Matthew Wilcox wrote: > On Wed, Aug 02, 2023 at 05:53:43PM +0800, Kefeng Wang wrote: >> err = -EACCES; >> - if (page_mapcount(page) > 1 && !migrate_all) >> - goto out_putpage; >> + if (folio_estimated_sharers(folio) > 1 && !migrate_all) >> + goto out_putfolio; > > I do not think this is the correct change. Maybe leave this line > alone. Ok, I am aware of the discussion about this in other mail, will not change it(also the next two patch about this function), or wait the new work of David. > >> - if (PageHuge(page)) { >> - if (PageHead(page)) { >> - isolated = isolate_hugetlb(page_folio(page), pagelist); >> + if (folio_test_hugetlb(folio)) { >> + if (folio_test_large(folio)) { > > This makes no sense when you read it. All hugetlb folios are large, > by definition. Think about what this code used to do, and what it > should be changed to. hugetlb folio is self large folio, will drop redundant check