From: Chao Yu <chao2.yu@samsung.com>
To: minchan@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
ngupta@vflare.org, 'Jerome Marchand' <jmarchan@redhat.com>,
'Sergey Senozhatsky' <sergey.senozhatsky@gmail.com>,
'Andrew Morton' <akpm@linux-foundation.org>
Subject: [PATCH] zram: add num_discards for discarded pages stat
Date: Fri, 15 Aug 2014 11:27:04 +0800 [thread overview]
Message-ID: <001201cfb838$fb0ac4a0$f1204de0$@samsung.com> (raw)
Now we have supported handling discard request which is sended by filesystem,
but no interface could be used to show information of discard.
This patch adds num_discards to stat discarded pages, then export it to sysfs
for displaying.
Signed-off-by: Chao Yu <chao2.yu@samsung.com>
---
Documentation/ABI/testing/sysfs-block-zram | 10 ++++++++++
drivers/block/zram/zram_drv.c | 3 +++
drivers/block/zram/zram_drv.h | 1 +
3 files changed, 14 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-block-zram b/Documentation/ABI/testing/sysfs-block-zram
index 70ec992..fa8936e 100644
--- a/Documentation/ABI/testing/sysfs-block-zram
+++ b/Documentation/ABI/testing/sysfs-block-zram
@@ -57,6 +57,16 @@ Description:
The failed_writes file is read-only and specifies the number of
failed writes happened on this device.
+
+What: /sys/block/zram<id>/num_discards
+Date: August 2014
+Contact: Chao Yu <chao2.yu@samsung.com>
+Description:
+ The num_discards file is read-only and specifies the number of
+ physical blocks which are discarded by this device. These blocks
+ are included in discard request which is sended by filesystem as
+ the blocks are no longer used.
+
What: /sys/block/zram<id>/max_comp_streams
Date: February 2014
Contact: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index d00831c..904e7a5 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -606,6 +606,7 @@ static void zram_bio_discard(struct zram *zram, u32 index,
bit_spin_lock(ZRAM_ACCESS, &meta->table[index].value);
zram_free_page(zram, index);
bit_spin_unlock(ZRAM_ACCESS, &meta->table[index].value);
+ atomic64_inc(&zram->stats.num_discards);
index++;
n -= PAGE_SIZE;
}
@@ -866,6 +867,7 @@ ZRAM_ATTR_RO(num_reads);
ZRAM_ATTR_RO(num_writes);
ZRAM_ATTR_RO(failed_reads);
ZRAM_ATTR_RO(failed_writes);
+ZRAM_ATTR_RO(num_discards);
ZRAM_ATTR_RO(invalid_io);
ZRAM_ATTR_RO(notify_free);
ZRAM_ATTR_RO(zero_pages);
@@ -879,6 +881,7 @@ static struct attribute *zram_disk_attrs[] = {
&dev_attr_num_writes.attr,
&dev_attr_failed_reads.attr,
&dev_attr_failed_writes.attr,
+ &dev_attr_num_discards.attr,
&dev_attr_invalid_io.attr,
&dev_attr_notify_free.attr,
&dev_attr_zero_pages.attr,
diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h
index e0f725c..2994aaf 100644
--- a/drivers/block/zram/zram_drv.h
+++ b/drivers/block/zram/zram_drv.h
@@ -86,6 +86,7 @@ struct zram_stats {
atomic64_t num_writes; /* --do-- */
atomic64_t failed_reads; /* can happen when memory is too low */
atomic64_t failed_writes; /* can happen when memory is too low */
+ atomic64_t num_discards; /* no. of discarded pages */
atomic64_t invalid_io; /* non-page-aligned I/O requests */
atomic64_t notify_free; /* no. of swap slot free notifications */
atomic64_t zero_pages; /* no. of zero filled pages */
--
2.0.1.474.g72c7794
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2014-08-15 3:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 3:27 Chao Yu [this message]
2014-08-15 6:11 ` Sergey Senozhatsky
2014-08-19 5:45 ` Chao Yu
2014-08-19 11:25 ` Sergey Senozhatsky
2014-08-20 2:09 ` Minchan Kim
2014-08-20 8:20 ` Chao Yu
2014-08-21 1:18 ` Minchan Kim
2014-08-21 9:09 ` Chao Yu
2014-08-21 13:05 ` Sergey Senozhatsky
2014-08-22 6:18 ` Minchan Kim
2014-08-26 2:43 ` Chao Yu
2014-08-26 12:44 ` Sergey Senozhatsky
2014-08-22 6:08 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001201cfb838$fb0ac4a0$f1204de0$@samsung.com' \
--to=chao2.yu@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox