linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Weijie Yang <weijie.yang@samsung.com>
To: hughd@google.com
Cc: 'Andrew Morton' <akpm@linux-foundation.org>,
	'Minchan Kim' <minchan@kernel.org>,
	shli@kernel.org, 'Bob Liu' <bob.liu@oracle.com>,
	weijie.yang.kh@gmail.com, 'Heesub Shin' <heesub.shin@samsung.com>,
	mquzik@redhat.com, 'Linux-MM' <linux-mm@kvack.org>,
	'linux-kernel' <linux-kernel@vger.kernel.org>,
	stable@vger.kernel.org
Subject: [PATCH 7/8] mm/swap: check swapfile blocksize greater than PAGE_SIZE
Date: Mon, 27 Jan 2014 18:03:04 +0800	[thread overview]
Message-ID: <000801cf1b47$3fcab170$bf601450$%yang@samsung.com> (raw)

If S_ISREG swapfile's blocksize > PAGE_SIZE, it is not suitable to be
a swapfile, because swap slot is fixed to PAGE_SIZE.

This patch check this situation and return -EINVAL if it happens.

Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
---
 mm/page_io.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/page_io.c b/mm/page_io.c
index 7247be6..3d9bd12 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -150,6 +150,8 @@ int generic_swapfile_activate(struct swap_info_struct *sis,
 	int ret;
 
 	blkbits = inode->i_blkbits;
+	if(blkbits > PAGE_SHIFT)
+		return -EINVAL;
 	blocks_per_page = PAGE_SIZE >> blkbits;
 
 	/*
-- 
1.7.10.4


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

                 reply	other threads:[~2014-01-27 10:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000801cf1b47$3fcab170$bf601450$%yang@samsung.com' \
    --to=weijie.yang@samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=bob.liu@oracle.com \
    --cc=heesub.shin@samsung.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=mquzik@redhat.com \
    --cc=shli@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=weijie.yang.kh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox