From: Weijie Yang <weijie.yang@samsung.com>
To: hughd@google.com
Cc: 'Andrew Morton' <akpm@linux-foundation.org>,
'Minchan Kim' <minchan@kernel.org>,
shli@kernel.org, 'Bob Liu' <bob.liu@oracle.com>,
weijie.yang.kh@gmail.com, 'Heesub Shin' <heesub.shin@samsung.com>,
mquzik@redhat.com, 'Linux-MM' <linux-mm@kvack.org>,
'linux-kernel' <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, xfishcoder@gmail.com
Subject: [PATCH 8/8] mm/frontswap: add missing handle on a dup-store failure
Date: Mon, 27 Jan 2014 18:03:04 +0800 [thread overview]
Message-ID: <000701cf1b47$19c56ab0$4d504010$%yang@samsung.com> (raw)
If a frontswap dup-store failed, it should invalidate the old page in
backend and return failure.
This patch add this missing handle. According to the comments of
__frontswap_store(), it should have been there.
Reported-by: changkun.li <xfishcoder@gmail.com>
Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
---
mm/frontswap.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/frontswap.c b/mm/frontswap.c
index df067f1..171c6c0 100644
--- a/mm/frontswap.c
+++ b/mm/frontswap.c
@@ -245,8 +245,10 @@ int __frontswap_store(struct page *page)
the (older) page from frontswap
*/
inc_frontswap_failed_stores();
- if (dup)
+ if (dup) {
__frontswap_clear(sis, offset);
+ frontswap_ops->invalidate_page(type, offset);
+ }
}
if (frontswap_writethrough_enabled)
/* report failure so swap also writes to swap device */
--
1.7.10.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
reply other threads:[~2014-01-27 10:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000701cf1b47$19c56ab0$4d504010$%yang@samsung.com' \
--to=weijie.yang@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=bob.liu@oracle.com \
--cc=heesub.shin@samsung.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=mquzik@redhat.com \
--cc=shli@kernel.org \
--cc=stable@vger.kernel.org \
--cc=weijie.yang.kh@gmail.com \
--cc=xfishcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox