* Re: [PATCH v2 10/18] lib/stackdepot: rename handle and pool constants [not found] <CGME20230412060558epcas2p254358bbd869eec9fb9907db6abac459a@epcas2p2.samsung.com> @ 2023-04-12 6:05 ` hoyoung seo 0 siblings, 0 replies; 2+ messages in thread From: hoyoung seo @ 2023-04-12 6:05 UTC (permalink / raw) To: andrey.konovalov Cc: akpm, andreyknvl, andreyknvl, elver, eugenis, glider, kasan-dev, linux-kernel, linux-mm, vbabka, bhoon95.kim, sc.suh +#define DEPOT_HANDLE_BITS (sizeof(depot_stack_handle_t) * 8) + +#define DEPOT_VALID_BITS 1 +#define DEPOT_POOL_ORDER 2 /* Pool size order, 4 pages */ +#define DEPOT_POOL_SIZE (1LL << (PAGE_SHIFT + DEPOT_POOL_ORDER)) +#define DEPOT_STACK_ALIGN 4 +#define DEPOT_OFFSET_BITS (DEPOT_POOL_ORDER + PAGE_SHIFT - DEPOT_STACK_ALIGN) +#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_VALID_BITS - \ + DEPOT_OFFSET_BITS - STACK_DEPOT_EXTRA_BITS) +#define DEPOT_POOLS_CAP 8192 Increase DEPOT_POOLS_CAP size to 32768 +#define DEPOT_MAX_POOLS \ + (((1LL << (DEPOT_POOL_INDEX_BITS)) < DEPOT_POOLS_CAP) ? \ + (1LL << (DEPOT_POOL_INDEX_BITS)) : DEPOT_POOLS_CAP) Hi Andrey. I have some question about DEPOT_MAX_POOLS. Actually I didn't know where to post my question, so here it is. I'm testing a feature of the UFS4.0 specification called MCQ, the call stack looks like this and __stack_depot_save keeps printing warning messages. [7: OST-Normal-13:17476] ------------[ cut here ]------------ [7: OST-Normal-13:17476] Stack depot reached limit capacity [7: OST-Normal-13:17476] pc : __stack_depot_save+0x464/0x46c [7: OST-Normal-13:17476] lr : __stack_depot_save+0x460/0x46c [7: OST-Normal-13:17476] sp : ffffffc008077730 [7: OST-Normal-13:17476] x29: ffffffc008077750 x28: ffffffd00b78a000 x27: 0000000000000000 [7: OST-Normal-13:17476] x26: 000000000009a7a4 x25: ffffff8914750000 x24: 000000004379a7a4 [7: OST-Normal-13:17476] x23: 00000000000001f8 x22: 0000000000000210 x21: 000000000000003f [7: OST-Normal-13:17476] x20: ffffffc0080777b0 x19: 0000000000000000 x18: 0000000000001000 [7: OST-Normal-13:17476] x17: 2065726568207475 x16: 00000000000000c3 x15: 2d2d2d2d2d2d2d20 [7: OST-Normal-13:17476] x14: 5d36373437313a33 x13: 000000000059a740 x12: 000000000059a6f8 [7: OST-Normal-13:17476] x11: 00000000ffffffff x10: ffffffb90aba9000 x9 : 008c3feffad60900 [7: OST-Normal-13:17476] x8 : 008c3feffad60900 x7 : 000000000059a740 x6 : 000000000059a6f8 [7: OST-Normal-13:17476] x5 : ffffffc008077438 x4 : ffffffd00b196970 x3 : ffffffd0092b313c [7: OST-Normal-13:17476] x2 : 0000000000000001 x1 : 0000000000000004 x0 : 0000000000000022 [7: OST-Normal-13:17476] Call trace: [7: OST-Normal-13:17476] __stack_depot_save+0x464/0x46c [7: OST-Normal-13:17476] kasan_save_stack+0x58/0x70 [7: OST-Normal-13:17476] save_stack_info+0x34/0x138 [7: OST-Normal-13:17476] kasan_save_free_info+0x18/0x24 [7: OST-Normal-13:17476] ____kasan_slab_free+0x16c/0x170 [7: OST-Normal-13:17476] __kasan_slab_free+0x10/0x20 [7: OST-Normal-13:17476] kmem_cache_free+0x238/0x53c [7: OST-Normal-13:17476] mempool_free_slab+0x1c/0x28 [7: OST-Normal-13:17476] mempool_free+0x7c/0x1a0 [7: OST-Normal-13:17476] sg_pool_free+0x6c/0x84 [7: OST-Normal-13:17476] __sg_free_table+0x88/0xbc [7: OST-Normal-13:17476] sg_free_table_chained+0x40/0x4c [7: OST-Normal-13:17476] scsi_free_sgtables+0x3c/0x7c [7: OST-Normal-13:17476] scsi_mq_uninit_cmd+0x20/0x7c [7: OST-Normal-13:17476] scsi_end_request+0xd8/0x304 [7: OST-Normal-13:17476] scsi_io_completion+0x88/0x160 [7: OST-Normal-13:17476] scsi_finish_command+0x17c/0x194 [7: OST-Normal-13:17476] scsi_complete+0xcc/0x158 [7: OST-Normal-13:17476] blk_mq_complete_request+0x4c/0x5c [7: OST-Normal-13:17476] scsi_done_internal+0xf4/0x1e0 [7: OST-Normal-13:17476] scsi_done+0x14/0x20 [7: OST-Normal-13:17476] ufshcd_compl_one_cqe+0x578/0x71c [7: OST-Normal-13:17476] ufshcd_mcq_poll_cqe_nolock+0xc8/0x150 [7: OST-Normal-13:17476] vendor_mcq_irq+0x74/0x88 [ufs-core] [7: OST-Normal-13:17476] __handle_irq_event_percpu+0xd0/0x348 [7: OST-Normal-13:17476] handle_irq_event_percpu+0x24/0x74 [7: OST-Normal-13:17476] handle_irq_event+0x74/0xe0 [7: OST-Normal-13:17476] handle_fasteoi_irq+0x174/0x240 [7: OST-Normal-13:17476] handle_irq_desc+0x7c/0x2c0 [7: OST-Normal-13:17476] generic_handle_domain_irq+0x1c/0x28 [7: OST-Normal-13:17476] gic_handle_irq+0x64/0x158 [7: OST-Normal-13:17476] call_on_irq_stack+0x2c/0x54 [7: OST-Normal-13:17476] do_interrupt_handler+0x70/0xa0 [7: OST-Normal-13:17476] el1_interrupt+0x34/0x68 [7: OST-Normal-13:17476] el1h_64_irq_handler+0x18/0x24 [7: OST-Normal-13:17476] el1h_64_irq+0x68/0x6c [7: OST-Normal-13:17476] __hwasan_check_x0_67043363+0xc/0x30 [7: OST-Normal-13:17476] ufshcd_queuecommand+0x5f8/0x7b4 [7: OST-Normal-13:17476] scsi_queue_rq+0xb88/0xea4 [7: OST-Normal-13:17476] blk_mq_dispatch_rq_list+0x640/0xe18 [7: OST-Normal-13:17476] blk_mq_do_dispatch_sched+0x47c/0x530 [7: OST-Normal-13:17476] __blk_mq_sched_dispatch_requests+0x158/0x1cc [7: OST-Normal-13:17476] blk_mq_sched_dispatch_requests+0x68/0x9c [7: OST-Normal-13:17476] __blk_mq_run_hw_queue+0x9c/0x11c [7: OST-Normal-13:17476] __blk_mq_delay_run_hw_queue+0xa4/0x234 [7: OST-Normal-13:17476] blk_mq_run_hw_queue+0x130/0x150 [7: OST-Normal-13:17476] blk_mq_sched_insert_requests+0x208/0x3a0 [7: OST-Normal-13:17476] blk_mq_flush_plug_list+0x21c/0x4f0 [7: OST-Normal-13:17476] __blk_flush_plug+0x180/0x1d8 [7: OST-Normal-13:17476] blk_finish_plug+0x40/0x5c [7: OST-Normal-13:17476] read_pages+0x420/0x4ac [7: OST-Normal-13:17476] page_cache_ra_unbounded+0xec/0x288 [7: OST-Normal-13:17476] do_page_cache_ra+0x60/0x6c [7: OST-Normal-13:17476] page_cache_ra_order+0x318/0x364 [7: OST-Normal-13:17476] do_sync_mmap_readahead+0x1a0/0x3c8 [7: OST-Normal-13:17476] filemap_fault+0x260/0x68c [7: OST-Normal-13:17476] __do_fault+0x80/0x1b4 [7: OST-Normal-13:17476] handle_mm_fault+0x6b4/0x1530 [7: OST-Normal-13:17476] do_page_fault+0x3ec/0x5d4 [7: OST-Normal-13:17476] do_translation_fault+0x44/0x5c [7: OST-Normal-13:17476] do_mem_abort+0x54/0xd8 [7: OST-Normal-13:17476] el0_ia+0x68/0xf4 [7: OST-Normal-13:17476] el0t_64_sync_handler+0xd0/0x114 [7: OST-Normal-13:17476] el0t_64_sync+0x190/0x194 After analyzing it, it seems that the stack buffer is running out of memory, so what do you think about increasing the size of DEPOT_POOLS_CAP to 32768? Tell us, your opinion Thanks. ^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2 00/18] lib/stackdepot: fixes and clean-ups @ 2023-02-10 21:15 andrey.konovalov 2023-02-10 21:15 ` [PATCH v2 10/18] lib/stackdepot: rename handle and pool constants andrey.konovalov 0 siblings, 1 reply; 2+ messages in thread From: andrey.konovalov @ 2023-02-10 21:15 UTC (permalink / raw) To: Marco Elver, Alexander Potapenko Cc: Andrey Konovalov, Vlastimil Babka, kasan-dev, Evgenii Stepanov, Andrew Morton, linux-mm, linux-kernel, Andrey Konovalov From: Andrey Konovalov <andreyknvl@google.com> A set of fixes, comments, and clean-ups I came up with while reading the stack depot code. Changes v1->v2: - Drop "lib/stackdepot: fix setting next_slab_inited in init_stack_slab", as there is no bug to fix. - Use "pool" instead of "slab" for memory regions that store stack traces. - Rename next_slab/pool_inited to next_slab/pool_required and annotate its uses with comments, see new patch #13. - Use STACK_HASH_TABLE_SCALE as a new name for STACK_HASH_SCALE. - Mark stack_depot_set_extra_bits as __must_check. - Only assign extra bits in stack_depot_set_extra_bits for non-empty handles. - Minor comment fixes. Andrey Konovalov (18): lib/stackdepot: put functions in logical order lib/stackdepot: use pr_fmt to define message format lib/stackdepot, mm: rename stack_depot_want_early_init lib/stackdepot: rename stack_depot_disable lib/stackdepot: annotate init and early init functions lib/stackdepot: lower the indentation in stack_depot_init lib/stackdepot: reorder and annotate global variables lib/stackdepot: rename hash table constants and variables lib/stackdepot: rename slab to pool lib/stackdepot: rename handle and pool constants lib/stackdepot: rename init_stack_pool lib/stacktrace: drop impossible WARN_ON for depot_init_pool lib/stackdepot: annotate depot_init_pool and depot_alloc_stack lib/stackdepot: rename next_pool_inited to next_pool_required lib/stacktrace, kasan, kmsan: rework extra_bits interface lib/stackdepot: annotate racy pool_index accesses lib/stackdepot: various comments clean-ups lib/stackdepot: move documentation comments to stackdepot.h include/linux/stackdepot.h | 152 +++++++-- lib/stackdepot.c | 654 ++++++++++++++++++------------------- mm/kasan/common.c | 2 +- mm/kmsan/core.c | 10 +- mm/page_owner.c | 2 +- mm/slub.c | 4 +- 6 files changed, 457 insertions(+), 367 deletions(-) -- 2.25.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2 10/18] lib/stackdepot: rename handle and pool constants 2023-02-10 21:15 [PATCH v2 00/18] lib/stackdepot: fixes and clean-ups andrey.konovalov @ 2023-02-10 21:15 ` andrey.konovalov 0 siblings, 0 replies; 2+ messages in thread From: andrey.konovalov @ 2023-02-10 21:15 UTC (permalink / raw) To: Marco Elver, Alexander Potapenko Cc: Andrey Konovalov, Vlastimil Babka, kasan-dev, Evgenii Stepanov, Andrew Morton, linux-mm, linux-kernel, Andrey Konovalov From: Andrey Konovalov <andreyknvl@google.com> Change the "STACK_ALLOC_" prefix to "DEPOT_" for the constants that define the number of bits in stack depot handles and the maximum number of pools. The old prefix is unclear and makes wonder about how these constants are related to stack allocations. The new prefix is also shorter. Also simplify the comment for DEPOT_POOL_ORDER. No functional changes. Reviewed-by: Alexander Potapenko <glider@google.com> Signed-off-by: Andrey Konovalov <andreyknvl@google.com> --- lib/stackdepot.c | 56 +++++++++++++++++++++++------------------------- 1 file changed, 27 insertions(+), 29 deletions(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 522e36cf449f..97bba462ee13 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -36,30 +36,28 @@ #include <linux/memblock.h> #include <linux/kasan-enabled.h> -#define DEPOT_STACK_BITS (sizeof(depot_stack_handle_t) * 8) - -#define STACK_ALLOC_NULL_PROTECTION_BITS 1 -#define STACK_ALLOC_ORDER 2 /* Pool size order for stack depot, 4 pages */ -#define STACK_ALLOC_SIZE (1LL << (PAGE_SHIFT + STACK_ALLOC_ORDER)) -#define STACK_ALLOC_ALIGN 4 -#define STACK_ALLOC_OFFSET_BITS (STACK_ALLOC_ORDER + PAGE_SHIFT - \ - STACK_ALLOC_ALIGN) -#define STACK_ALLOC_INDEX_BITS (DEPOT_STACK_BITS - \ - STACK_ALLOC_NULL_PROTECTION_BITS - \ - STACK_ALLOC_OFFSET_BITS - STACK_DEPOT_EXTRA_BITS) -#define STACK_ALLOC_POOLS_CAP 8192 -#define STACK_ALLOC_MAX_POOLS \ - (((1LL << (STACK_ALLOC_INDEX_BITS)) < STACK_ALLOC_POOLS_CAP) ? \ - (1LL << (STACK_ALLOC_INDEX_BITS)) : STACK_ALLOC_POOLS_CAP) +#define DEPOT_HANDLE_BITS (sizeof(depot_stack_handle_t) * 8) + +#define DEPOT_VALID_BITS 1 +#define DEPOT_POOL_ORDER 2 /* Pool size order, 4 pages */ +#define DEPOT_POOL_SIZE (1LL << (PAGE_SHIFT + DEPOT_POOL_ORDER)) +#define DEPOT_STACK_ALIGN 4 +#define DEPOT_OFFSET_BITS (DEPOT_POOL_ORDER + PAGE_SHIFT - DEPOT_STACK_ALIGN) +#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_VALID_BITS - \ + DEPOT_OFFSET_BITS - STACK_DEPOT_EXTRA_BITS) +#define DEPOT_POOLS_CAP 8192 +#define DEPOT_MAX_POOLS \ + (((1LL << (DEPOT_POOL_INDEX_BITS)) < DEPOT_POOLS_CAP) ? \ + (1LL << (DEPOT_POOL_INDEX_BITS)) : DEPOT_POOLS_CAP) /* The compact structure to store the reference to stacks. */ union handle_parts { depot_stack_handle_t handle; struct { - u32 pool_index : STACK_ALLOC_INDEX_BITS; - u32 offset : STACK_ALLOC_OFFSET_BITS; - u32 valid : STACK_ALLOC_NULL_PROTECTION_BITS; - u32 extra : STACK_DEPOT_EXTRA_BITS; + u32 pool_index : DEPOT_POOL_INDEX_BITS; + u32 offset : DEPOT_OFFSET_BITS; + u32 valid : DEPOT_VALID_BITS; + u32 extra : STACK_DEPOT_EXTRA_BITS; }; }; @@ -91,7 +89,7 @@ static unsigned int stack_bucket_number_order; static unsigned int stack_hash_mask; /* Array of memory regions that store stack traces. */ -static void *stack_pools[STACK_ALLOC_MAX_POOLS]; +static void *stack_pools[DEPOT_MAX_POOLS]; /* Currently used pool in stack_pools. */ static int pool_index; /* Offset to the unused space in the currently used pool. */ @@ -235,7 +233,7 @@ static bool init_stack_pool(void **prealloc) *prealloc = NULL; } else { /* If this is the last depot pool, do not touch the next one. */ - if (pool_index + 1 < STACK_ALLOC_MAX_POOLS) { + if (pool_index + 1 < DEPOT_MAX_POOLS) { stack_pools[pool_index + 1] = *prealloc; *prealloc = NULL; } @@ -255,10 +253,10 @@ depot_alloc_stack(unsigned long *entries, int size, u32 hash, void **prealloc) struct stack_record *stack; size_t required_size = struct_size(stack, entries, size); - required_size = ALIGN(required_size, 1 << STACK_ALLOC_ALIGN); + required_size = ALIGN(required_size, 1 << DEPOT_STACK_ALIGN); - if (unlikely(pool_offset + required_size > STACK_ALLOC_SIZE)) { - if (unlikely(pool_index + 1 >= STACK_ALLOC_MAX_POOLS)) { + if (unlikely(pool_offset + required_size > DEPOT_POOL_SIZE)) { + if (unlikely(pool_index + 1 >= DEPOT_MAX_POOLS)) { WARN_ONCE(1, "Stack depot reached limit capacity"); return NULL; } @@ -269,7 +267,7 @@ depot_alloc_stack(unsigned long *entries, int size, u32 hash, void **prealloc) * |next_pool_inited| in stack_depot_save() and * init_stack_pool(). */ - if (pool_index + 1 < STACK_ALLOC_MAX_POOLS) + if (pool_index + 1 < DEPOT_MAX_POOLS) smp_store_release(&next_pool_inited, 0); } init_stack_pool(prealloc); @@ -281,7 +279,7 @@ depot_alloc_stack(unsigned long *entries, int size, u32 hash, void **prealloc) stack->hash = hash; stack->size = size; stack->handle.pool_index = pool_index; - stack->handle.offset = pool_offset >> STACK_ALLOC_ALIGN; + stack->handle.offset = pool_offset >> DEPOT_STACK_ALIGN; stack->handle.valid = 1; stack->handle.extra = 0; memcpy(stack->entries, entries, flex_array_size(stack, entries, size)); @@ -412,7 +410,7 @@ depot_stack_handle_t __stack_depot_save(unsigned long *entries, alloc_flags &= ~GFP_ZONEMASK; alloc_flags &= (GFP_ATOMIC | GFP_KERNEL); alloc_flags |= __GFP_NOWARN; - page = alloc_pages(alloc_flags, STACK_ALLOC_ORDER); + page = alloc_pages(alloc_flags, DEPOT_POOL_ORDER); if (page) prealloc = page_address(page); } @@ -444,7 +442,7 @@ depot_stack_handle_t __stack_depot_save(unsigned long *entries, exit: if (prealloc) { /* Nobody used this memory, ok to free it. */ - free_pages((unsigned long)prealloc, STACK_ALLOC_ORDER); + free_pages((unsigned long)prealloc, DEPOT_POOL_ORDER); } if (found) retval.handle = found->handle.handle; @@ -489,7 +487,7 @@ unsigned int stack_depot_fetch(depot_stack_handle_t handle, { union handle_parts parts = { .handle = handle }; void *pool; - size_t offset = parts.offset << STACK_ALLOC_ALIGN; + size_t offset = parts.offset << DEPOT_STACK_ALIGN; struct stack_record *stack; *entries = NULL; -- 2.25.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-12 6:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20230412060558epcas2p254358bbd869eec9fb9907db6abac459a@epcas2p2.samsung.com>
2023-04-12 6:05 ` [PATCH v2 10/18] lib/stackdepot: rename handle and pool constants hoyoung seo
2023-02-10 21:15 [PATCH v2 00/18] lib/stackdepot: fixes and clean-ups andrey.konovalov
2023-02-10 21:15 ` [PATCH v2 10/18] lib/stackdepot: rename handle and pool constants andrey.konovalov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox