From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E6CC5AE59 for ; Tue, 3 Jun 2025 12:15:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F0E16B0423; Tue, 3 Jun 2025 08:15:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C8566B0424; Tue, 3 Jun 2025 08:15:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DDC86B0425; Tue, 3 Jun 2025 08:15:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1077F6B0423 for ; Tue, 3 Jun 2025 08:15:25 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 89A58C06E3 for ; Tue, 3 Jun 2025 12:15:24 +0000 (UTC) X-FDA: 83513984568.23.FDC26A7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 15DCC14000F for ; Tue, 3 Jun 2025 12:15:21 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NmbJup7d; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748952922; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TasztSvEy0KptHyXQjrgiaCFMzH0ysJYTfsnvkcKii8=; b=qOacXm2jSIXPg/0uVb0N6IH8iU/uAt4hFXL1g9W8Ybtj+TS1RJ4xJPqbn/adwCFNvWu5+Q DSFqIYnRjiyYG7UntdVwy3+RpMzqGxEw+yw6OwmjUghd97fbQt4p6ql5sTT8Mv3oVpzqgp T1wZ3SDygBlvlz/A/5ke5cJ/7Cn0Ij8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NmbJup7d; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748952922; a=rsa-sha256; cv=none; b=ElkFacUajkw3NR/wHYMklKd0Sku71iEz10VHhqZ8d+tWeNoqawZH9SzEEw0c0vQzlPGR0J Hyv1QpRnvsHQduqjtrTlST58bvXr6hzurs3qwiFa3JA44AFIaJRvGxMT3XwL9nqxSTrL4T +ijHJmnAJvhzO7oV2Rnb+7G457HxzkU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748952921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TasztSvEy0KptHyXQjrgiaCFMzH0ysJYTfsnvkcKii8=; b=NmbJup7dOi+VrivW3eTmAWEFFNVtuHJp4xpjI3TUNhc46cp2MuhiWQKjHM60iGtjEMCrMT /VBrXxkZ+giIugCNKr5CvIO1pDPejl1qPYx5jAG4fhXP4H1rWMj9EJf1orM1sBSYkED/of /54nn5FtC0+faFEMB/hJIlaQXUuGi4c= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-378-N2zKTqspMBa5k8xm-upKkw-1; Tue, 03 Jun 2025 08:15:20 -0400 X-MC-Unique: N2zKTqspMBa5k8xm-upKkw-1 X-Mimecast-MFC-AGG-ID: N2zKTqspMBa5k8xm-upKkw_1748952919 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-450d9f96f61so31237225e9.1 for ; Tue, 03 Jun 2025 05:15:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748952919; x=1749557719; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=TasztSvEy0KptHyXQjrgiaCFMzH0ysJYTfsnvkcKii8=; b=tUvKgx4jGNggTdt+aO6NluZWNPBeKVu44nehuUz9vUCqmbDo7/wDaDIwHsEU98E9k5 AegX6UALVbywwtgiSJqm14l82OuRPPmVi3Gvx61KsUdzEEiFAY0X49p+JQsVLO0Jag3E NxnptoZ5riyi71nMQP82tyULc5Mjvi0WyLhzymkKhruAJh7LNjs8ZrT+qjgRV5mlu8AF 2T7vmgIrv3tDIpU5xA47Zv5Zxq0pnMm9rBeAt4HXb5hRFaauUo9qq+yNfDoDZrV6OaM4 CiQRW22BQrKsJf9PY4UK6suQ5IJl1z+MBJ6JGgh5HmswMuK3b+9VpriyVQkAUQhAYTWP MgLg== X-Forwarded-Encrypted: i=1; AJvYcCWwqtsmhAjU/ebnub/EWb222fyiaUU11piB3AWYu8cNUj5nTgJCZAzxSZ7L9LFH4rfXfxkP/7KPbg==@kvack.org X-Gm-Message-State: AOJu0Ywj3hSnr50bL6y+RhA3Jin/+Ogtbd+kL8CcKbkbpEULNpIRXqgg 4pizrLhAL7sspoK44s6txfN9a5ibxNdhYk1quppHylhnYk+KEqMefxsLIWy6crVRji5+6g8sQes ynUl+9ik6fBPVCnAvh1xpHBCJxza710YOfLLACSSDdWPpxr9Ehijf X-Gm-Gg: ASbGnctNfFOVAIP7mt/DV1ei4xMqstXZB+sR8gVEepLqQWGVuDBF/6RgdHikYURtxNR CvH0U3uHz+SlhyV9ZoPi0IBAZedQ6r0uXj13eAEVGt1EdPWAMOUruKpj+MltXclsTVwp2s1T521 /txdSZN2nXl5zOSFaqGVh2Hp39kWqFo/gS5/9Nv71QTvVQTJMUPnoiqzfC547XfirG4muc/RAs7 5ESlTHODjzlDKrJL3ZLJH/TcU5XrZWQJbjdKI3GmAt89/xNXNYe32U6uZRethmjND0Br8cpjbJN +Gi2701Ef7O6I2KIIGnE/LvrfoVBKqetWMhhhXWgbahkorGAjru6yOrMUIyams7ggzTF2KnPyhr NW9k3Ct918BTfwp8jdG8u9U8loy7KHVORt0qKO+0= X-Received: by 2002:a05:600c:8b68:b0:440:6852:5b31 with SMTP id 5b1f17b1804b1-450d651182fmr193445085e9.10.1748952918984; Tue, 03 Jun 2025 05:15:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEiHaGOk8I+UeX8+pvGCa89rKh+KLPclMDESQfssTO2f3GKAiDIyMQLwhS6/fd1DVCtRLsNiA== X-Received: by 2002:a05:600c:8b68:b0:440:6852:5b31 with SMTP id 5b1f17b1804b1-450d651182fmr193444655e9.10.1748952918541; Tue, 03 Jun 2025 05:15:18 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0d:f000:eec9:2b8d:4913:f32a? (p200300d82f0df000eec92b8d4913f32a.dip0.t-ipconnect.de. [2003:d8:2f0d:f000:eec9:2b8d:4913:f32a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d8000d45sm159598675e9.25.2025.06.03.05.15.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 05:15:18 -0700 (PDT) Message-ID: <0003a78b-e66f-41a5-9244-89c2c430cfa4@redhat.com> Date: Tue, 3 Jun 2025 14:15:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC] mm: madvise: use walk_page_range_vma() for madvise_free_single_vma() To: Lorenzo Stoakes , Barry Song <21cnbao@gmail.com> Cc: Dev Jain , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Suren Baghdasaryan , Lokesh Gidra , Tangquan Zheng References: <20250603013154.5905-1-21cnbao@gmail.com> <7bd57eba-42a0-4bf3-8632-b91c401b7316@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DtOpH-DsPsZLVHTWA1QzkyeXrl2xgATX0X32VtDZpg0_1748952919 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 15DCC14000F X-Rspamd-Server: rspam09 X-Stat-Signature: mqtoo78q7dj9jkpk3b46s5qynkm4e8cg X-HE-Tag: 1748952921-595214 X-HE-Meta: U2FsdGVkX18oFnSXi6tYqM4K3c+KXqlXJgIcbidt+ZRddu2vYseDR0B5VG+gHcoSJ7eHbu6PpJPLM/me2neCKuKQxQPdl+e5qYliJQmFFH9EYgWeKcS2EmkCLSDMvIxcC24qLzEHY7AHzIimYdjj1dK8DAhltE4ll0stUQbtbUGpfA8jUug73vJqNcYrjV6cuFX5jrXITAxijLrjvvMOvqJ2DdhAwjV7e0H1Txr50iUnSe0CJLd4cL5moOicr7SK5amYW1mWzAJO/eJpDmfef18+LhxZMpCBac7R5ti0uSSvBMsZK6OMHqAIGds6fGkrPpaemW49uy0Kfsyfpbzjv3rOJMUb6+EK181MGFo8lOL/5Gz5uwkV5yxWBjv+aIAvksu9+OZdcd9ihT61bzzLgShdglCQ5ZKVi8eHawoRfaxgKNODFIe/8HDbola5fzo8l7kRsAnenpTDOMYD9/kJYnclEUtToTyx5KzSoGzIVq1scyDbr2croVQIKXEEjHwg2YRhlBgZ5MtWzN2aT0/23G3Nk0yEmkj8xDq0u2EtBH19lej/a0sZ/LV74jC3j+1haQIf0zWZPB9+AlpbvUqxh4sM7MxSYrNrRzlzsjI2UiubOzudjT00Ljsx8rxje0AWMpQMdN0gxhJwqWBdn3CXI0FxoKLXl4QSCKKnToLnyXOKWLWAfIGRTJusPbcwuD6HiVx4dNn/A4eufJ70rn4xk3IzZ95Oo76RpbUpthmAVAv3gf67PoL8uClhdYcAOkjvK1tVZi3ISJIZUkLZ6u/sVkNQj0UM2eAMh5zjZHOVUgYwhn5NrNN4iROsL+gs94ekGZJkLe8V2W+lpaAZOdKo1AXa8EuCKNeCZhykfCwa/uxYwokz8ZBL6Pbic0D68cZxmBLmM7er/qFJPCA8naj7bEIba9juV8kLk265DUVdJRgysrDvkw9GdssnQUeCxnQNxPrzUgYhXMlapVco0DA HmaqpAmF 3OB5inPDK/eg2JfnYEWAq/ieq+9l3WmKgVzr0TjnCqXnenqgtqzHZ6IJWnSHCYI6GCytTnMLeyyIG8lknMzKL5OkENbyJIjq1tbvT1OKobjNaHVY2j8iD6QLEZ8F6LcRjtrRM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.25 11:41, Lorenzo Stoakes wrote: > On Tue, Jun 03, 2025 at 08:47:04PM +1200, Barry Song wrote: >> On Tue, Jun 3, 2025 at 6:11 PM Dev Jain wrote: >>> >>> >>> On 03/06/25 7:01 am, Barry Song wrote: >>>> From: Barry Song >>>> >>>> We've already found the VMA before calling madvise_free_single_vma(), >>>> so calling walk_page_range() and doing find_vma() again seems >>>> unnecessary. It also prevents potential optimizations for MADV_FREE >>>> to use a per-VMA lock. >>>> >>>> Cc: "Liam R. Howlett" >>>> Cc: Lorenzo Stoakes >>>> Cc: David Hildenbrand >>>> Cc: Vlastimil Babka >>>> Cc: Jann Horn >>>> Cc: Suren Baghdasaryan >>>> Cc: Lokesh Gidra >>>> Cc: Tangquan Zheng >>>> Signed-off-by: Barry Song >>>> --- >>>> mm/madvise.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/mm/madvise.c b/mm/madvise.c >>>> index d408ffa404b3..c6a28a2d3ff8 100644 >>>> --- a/mm/madvise.c >>>> +++ b/mm/madvise.c >>>> @@ -826,7 +826,7 @@ static int madvise_free_single_vma(struct madvise_behavior *madv_behavior, >>>> >>>> mmu_notifier_invalidate_range_start(&range); >>>> tlb_start_vma(tlb, vma); >>>> - walk_page_range(vma->vm_mm, range.start, range.end, >>>> + walk_page_range_vma(vma, range.start, range.end, >>>> &madvise_free_walk_ops, tlb); >>>> tlb_end_vma(tlb, vma); >>>> mmu_notifier_invalidate_range_end(&range); >>> >>> Can similar optimizations be made in madvise_willneed(), madvise_cold_page_range(), etc? >> >> Yes, I think the same code flow applies to madvise_willneed, >> madvise_cold_page_range, and similar functions, though my current >> interest is more on madvise_free. >> >> Let me prepare a v2 that includes those as well. > > FWIW Dev makes a great point here and I agree wholeheartedly, let's fix all such > cases... > > As an aside, I wonder if we previously didn't do this because we hadn't > previously exposed the walk_page_range_vma() API or something? IIRC, yes: commit e07cda5f232fac4de0925d8a4c92e51e41fa2f6e Author: David Hildenbrand Date: Fri Oct 21 12:11:39 2022 +0200 mm/pagewalk: add walk_page_range_vma() Let's add walk_page_range_vma(), which is similar to walk_page_vma(), however, is only interested in a subset of the VMA range. To be used in KSM code to stop using follow_page() next. -- Cheers, David / dhildenb