From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: 'Andi Kleen' <ak@suse.de>
Cc: Dave McCracken <dmccr@us.ibm.com>,
'Hugh Dickins' <hugh@veritas.com>,
'Andrew Morton' <akpm@osdl.org>,
linux-mm@kvack.org
Subject: RE: [patch] shared page table for hugetlb page
Date: Wed, 7 Jun 2006 18:39:31 -0700 [thread overview]
Message-ID: <000201c68a9c$635ba700$d534030a@amr.corp.intel.com> (raw)
In-Reply-To: <200606080325.19994.ak@suse.de>
Andi Kleen wrote on Wednesday, June 07, 2006 6:25 PM
> > @@ -18,16 +18,102 @@
> > #include <asm/tlb.h>
> > #include <asm/tlbflush.h>
> >
> > +#ifdef CONFIG_X86_64
>
> Why is this done for x86-64 only?
Do you mean not for i386? I'm too chicken to do it for 32-bit PAE mode. There
are tons of other issue that application has to fight through with highmem and
playing with only limited 32-bit virtual address space, I thought this usage
might be very limited for 32-bit x86.
If you meant patch doesn't include ppc/sparc/ia64, it will be added soon.
> > pte_t *huge_pte_alloc(struct mm_struct *mm, unsigned long addr)
> > {
> > + /*
> > + * to be fixed: pass me the darn vma pointer.
> > + */
>
> Just fix it?
OK.
> Overall it looks nice&clean though.
Thanks for reviewing and your warm comments.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-06-08 1:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-07 20:51 Chen, Kenneth W
2006-06-08 1:25 ` Andi Kleen
2006-06-08 1:39 ` Chen, Kenneth W [this message]
2006-06-08 7:31 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000201c68a9c$635ba700$d534030a@amr.corp.intel.com' \
--to=kenneth.w.chen@intel.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=dmccr@us.ibm.com \
--cc=hugh@veritas.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox