* [PATCH 1/2] zram: make max_used_pages reset work correctly
@ 2014-10-25 9:25 Weijie Yang
2014-10-26 1:41 ` Minchan Kim
0 siblings, 1 reply; 3+ messages in thread
From: Weijie Yang @ 2014-10-25 9:25 UTC (permalink / raw)
To: 'Minchan Kim'
Cc: 'Andrew Morton', 'Dan Streetman',
'Sergey Senozhatsky', 'Nitin Gupta',
'Linux-MM', 'linux-kernel', 'Weijie Yang'
The commit 461a8eee6a ("zram: report maximum used memory") introduces a new
knob "mem_used_max" in zram.stats sysfs, and wants to reset it via write 0
to the sysfs interface.
However, the current code cann't reset it correctly, so let's fix it.
Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
---
drivers/block/zram/zram_drv.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 0e63e8a..64dd79a 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -173,7 +173,6 @@ static ssize_t mem_used_max_store(struct device *dev,
int err;
unsigned long val;
struct zram *zram = dev_to_zram(dev);
- struct zram_meta *meta = zram->meta;
err = kstrtoul(buf, 10, &val);
if (err || val != 0)
@@ -181,8 +180,7 @@ static ssize_t mem_used_max_store(struct device *dev,
down_read(&zram->init_lock);
if (init_done(zram))
- atomic_long_set(&zram->stats.max_used_pages,
- zs_get_total_pages(meta->mem_pool));
+ atomic_long_set(&zram->stats.max_used_pages, 0);
up_read(&zram->init_lock);
return len;
--
1.7.0.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] zram: make max_used_pages reset work correctly
2014-10-25 9:25 [PATCH 1/2] zram: make max_used_pages reset work correctly Weijie Yang
@ 2014-10-26 1:41 ` Minchan Kim
2014-10-27 1:23 ` Weijie Yang
0 siblings, 1 reply; 3+ messages in thread
From: Minchan Kim @ 2014-10-26 1:41 UTC (permalink / raw)
To: Weijie Yang
Cc: 'Andrew Morton', 'Dan Streetman',
'Sergey Senozhatsky', 'Nitin Gupta',
'Linux-MM', 'linux-kernel', 'Weijie Yang'
Hello,
On Sat, Oct 25, 2014 at 05:25:11PM +0800, Weijie Yang wrote:
> The commit 461a8eee6a ("zram: report maximum used memory") introduces a new
> knob "mem_used_max" in zram.stats sysfs, and wants to reset it via write 0
> to the sysfs interface.
>
> However, the current code cann't reset it correctly, so let's fix it.
We wanted to reset it to current used total memory, not 0.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] zram: make max_used_pages reset work correctly
2014-10-26 1:41 ` Minchan Kim
@ 2014-10-27 1:23 ` Weijie Yang
0 siblings, 0 replies; 3+ messages in thread
From: Weijie Yang @ 2014-10-27 1:23 UTC (permalink / raw)
To: Minchan Kim
Cc: Weijie Yang, Andrew Morton, Dan Streetman, Sergey Senozhatsky,
Nitin Gupta, Linux-MM, linux-kernel
On Sun, Oct 26, 2014 at 9:41 AM, Minchan Kim <minchan@kernel.org> wrote:
> Hello,
>
> On Sat, Oct 25, 2014 at 05:25:11PM +0800, Weijie Yang wrote:
>> The commit 461a8eee6a ("zram: report maximum used memory") introduces a new
>> knob "mem_used_max" in zram.stats sysfs, and wants to reset it via write 0
>> to the sysfs interface.
>>
>> However, the current code cann't reset it correctly, so let's fix it.
>
> We wanted to reset it to current used total memory, not 0.
I misread taht, I will resend the 2/2 patch
> --
> Kind regards,
> Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-27 1:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-25 9:25 [PATCH 1/2] zram: make max_used_pages reset work correctly Weijie Yang
2014-10-26 1:41 ` Minchan Kim
2014-10-27 1:23 ` Weijie Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox