From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id D75726B0012 for ; Mon, 20 Jun 2011 06:46:57 -0400 (EDT) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=utf-8 Received: from eu_spt1 ([210.118.77.13]) by mailout3.w1.samsung.com (Sun Java(tm) System Messaging Server 6.3-8.04 (built Jul 29 2009; 32bit)) with ESMTP id <0LN3008RY4M6YO00@mailout3.w1.samsung.com> for linux-mm@kvack.org; Mon, 20 Jun 2011 11:46:54 +0100 (BST) Received: from linux.samsung.com ([106.116.38.10]) by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LN3001QU4M5Z0@spt1.w1.samsung.com> for linux-mm@kvack.org; Mon, 20 Jun 2011 11:46:54 +0100 (BST) Date: Mon, 20 Jun 2011 12:46:50 +0200 From: Marek Szyprowski Subject: RE: [PATCH 1/8] ARM: dma-mapping: remove offset parameter to prepare for generic dma_ops In-reply-to: Message-id: <000001cc2f37$5c5605f0$150211d0$%szyprowski@samsung.com> Content-language: pl References: <1308556213-24970-1-git-send-email-m.szyprowski@samsung.com> <1308556213-24970-2-git-send-email-m.szyprowski@samsung.com> Sender: owner-linux-mm@kvack.org List-ID: To: 'Michal Nazarewicz' , linux-arm-kernel@lists.infradead.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, linux-arch@vger.kernel.org Cc: 'Kyungmin Park' , 'Arnd Bergmann' , 'Joerg Roedel' , 'Russell King - ARM Linux' , Marek Szyprowski Hello, On Monday, June 20, 2011 10:36 AM Michal Nazarewicz wrote: > On Mon, 20 Jun 2011 09:50:06 +0200, Marek Szyprowski > wrote: > > +static inline void dma_sync_single_for_cpu(struct device *dev, > > I wouldn't really put inline here or in the function below. > > > + dma_addr_t handle, size_t size, enum dma_data_direction dir) > > +{ > > + BUG_ON(!valid_dma_direction(dir)); > > + > > + debug_dma_sync_single_for_cpu(dev, handle, size, dir); > > + > > + if (!dmabounce_sync_for_cpu(dev, handle, size, dir)) > > + return; > > + > > + __dma_single_dev_to_cpu(dma_to_virt(dev, handle), size, dir); > > I know it is just copy'n'paste but how about: This patch is just about moving the code between the files and I wanted just to show what's being changed and how. There is a final cleanup anyway in the separate patch. All these patches are meant to start the discussion about the way the dma mapping can be redesigned for further extensions with generic iommu support. > > if (dmabounce_sync_for_cpu(dev, handle, size, dir)) > __dma_single_dev_to_cpu(dma_to_virt(dev, handle), size, dir); The above lines will be removed by the next patches in this series, so I really see no point in changing this. (snipped) Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org