From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qe0-f47.google.com (mail-qe0-f47.google.com [209.85.128.47]) by kanga.kvack.org (Postfix) with ESMTP id C81DC6B00BB for ; Mon, 9 Dec 2013 11:17:39 -0500 (EST) Received: by mail-qe0-f47.google.com with SMTP id t7so3055949qeb.34 for ; Mon, 09 Dec 2013 08:17:39 -0800 (PST) Received: from a9-50.smtp-out.amazonses.com (a9-50.smtp-out.amazonses.com. [54.240.9.50]) by mx.google.com with ESMTP id r5si8594612qat.160.2013.12.09.08.17.33 for ; Mon, 09 Dec 2013 08:17:38 -0800 (PST) Date: Mon, 9 Dec 2013 16:17:32 +0000 From: Christoph Lameter Subject: Re: [PATCH v2 2/7] mm/migrate: correct failure handling if !hugepage_migration_support() In-Reply-To: <1386580248-22431-3-git-send-email-iamjoonsoo.kim@lge.com> Message-ID: <00000142d8263858-5c29199b-77e5-47a5-9db6-2ea6ea7c7fc8-000000@email.amazonses.com> References: <1386580248-22431-1-git-send-email-iamjoonsoo.kim@lge.com> <1386580248-22431-3-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: Andrew Morton , Mel Gorman , Rik van Riel , Rafael Aquini , Naoya Horiguchi , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Zhang Yanfei On Mon, 9 Dec 2013, Joonsoo Kim wrote: > We should remove the page from the list if we fail without ENOSYS, > since migrate_pages() consider error cases except -ENOMEM and -EAGAIN > as permanent failure and it assumes that the page would be removed from > the list. Without this patch, we could overcount number of failure. Ok what does the patch do about this? I dont see any modifications. Remove this part of the description? > In addition, we should put back the new hugepage if > !hugepage_migration_support(). If not, we would leak hugepage memory. Ok looks like that is fixed by this patch. Acked-by: Christoph Lameter -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org