From: Christoph Lameter <cl@linux.com>
To: Andreas Herrmann <andreas.herrmann@calxeda.com>
Cc: Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/slub: Switch slub_debug kernel option to early_param to avoid boot panic
Date: Thu, 7 Nov 2013 16:29:15 +0000 [thread overview]
Message-ID: <000001423365730f-486d720c-11cd-4f7d-939b-8ff2860c60b7-000000@email.amazonses.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1311071008010.22533@gentwo.org>
There is still something not optimal with the patch since it would disable
debuggin on the kmalloc stack. Ccheck name for NULL only if
slub_debug_slabs.
Subject: slub: Handle NULL parameter in kmem_cache_flags V2
V1->V2
- flags need to be applied regardless if !slub_debug_slabs
kmem_cache_flags may be called with NULL parameter during early boot.
Skip the test in that case.
Signed-off-by: Christoph Lameter <cl@linux.com>
Index: linux/mm/slub.c
===================================================================
--- linux.orig/mm/slub.c 2013-11-07 10:25:49.669706521 -0600
+++ linux/mm/slub.c 2013-11-07 10:27:49.130394661 -0600
@@ -1217,8 +1217,8 @@ static unsigned long kmem_cache_flags(un
/*
* Enable debugging if selected on the kernel commandline.
*/
- if (slub_debug && (!slub_debug_slabs ||
- !strncmp(slub_debug_slabs, name, strlen(slub_debug_slabs))))
+ if (slub_debug && (!slub_debug_slabs || (name &&
+ !strncmp(slub_debug_slabs, name, strlen(slub_debug_slabs)))))
flags |= slub_debug;
return flags;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-11-07 16:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 18:45 Andreas Herrmann
2013-11-06 19:16 ` Christoph Lameter
2013-11-06 19:21 ` Andreas Herrmann
2013-11-06 19:54 ` Andreas Herrmann
2013-11-06 20:34 ` Andreas Herrmann
2013-11-06 21:16 ` Andreas Herrmann
2013-11-06 21:38 ` Christoph Lameter
2013-11-07 8:27 ` Andreas Herrmann
2013-11-07 8:41 ` Andreas Herrmann
2013-11-07 16:09 ` Christoph Lameter
[not found] ` <alpine.DEB.2.02.1311071008010.22533@gentwo.org>
2013-11-07 16:29 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=000001423365730f-486d720c-11cd-4f7d-939b-8ff2860c60b7-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=andreas.herrmann@calxeda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox