From: Christoph Lameter <cl@linux.com>
To: Andreas Herrmann <andreas.herrmann@calxeda.com>
Cc: Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/slub: Switch slub_debug kernel option to early_param to avoid boot panic
Date: Thu, 7 Nov 2013 16:09:15 +0000 [thread overview]
Message-ID: <0000014233531ff8-0f4331f9-5da3-4cc8-9c30-a40681228446-000000@email.amazonses.com> (raw)
In-Reply-To: <20131107084129.GP5661@alberich>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1568 bytes --]
On Thu, 7 Nov 2013, Andreas Herrmann wrote:
> And for sake of completeness. Here is some debug output with a kernel
> that had your "slub: Handle NULL parameter in kmem_cache_flags" patch
> applied. And of course there were a couple of unnamed slabs:
>
> ...
> .bss : 0xc089fd80 - 0xc094cc4c ( 692 kB)
> slub_debug_slabs (c2956a08): skbuff_fclone_cache, name (c06fc90c): kmem_cache_node
> slub_debug_slabs (c2956a08): skbuff_fclone_cache, name (c06fc91c): kmem_cache
> a?? slub_debug_slabs (c2956a08): skbuff_fclone_cache, name ( (null)): (null)
> slub_debug_slabs (c2956a08): skbuff_fclone_cache, name ( (null)): (null)
> slub_debug_slabs (c2956a08): skbuff_fclone_cache, name ( (null)): (null)
> slub_debug_slabs (c2956a08): skbuff_fclone_cache, name ( (null)): (null)
> slub_debug_slabs (c2956a08): skbuff_fclone_cache, name ( (null)): (null)
> slub_debug_slabs (c2956a08): skbuff_fclone_cache, name ( (null)): (null)
> slub_debug_slabs (c2956a08): skbuff_fclone_cache, name ( (null)): (null)
> slub_debug_slabs (c2956a08): skbuff_fclone_cache, name ( (null)): (null)
> slub_debug_slabs (c2956a08): skbuff_fclone_cache, name ( (null)): (null)
> SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=4, Nodes=1
> ...
Well yes on bootstrap the slabs are initially created without a name.
Later the name is provided. Before the introduction of the common kmalloc
code the kmalloc caches had a generic name instead of NULL. I was not sure
that this was a valid thing to do so I put NULL in there so that we can
catch the uses.
next prev parent reply other threads:[~2013-11-07 16:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 18:45 Andreas Herrmann
2013-11-06 19:16 ` Christoph Lameter
2013-11-06 19:21 ` Andreas Herrmann
2013-11-06 19:54 ` Andreas Herrmann
2013-11-06 20:34 ` Andreas Herrmann
2013-11-06 21:16 ` Andreas Herrmann
2013-11-06 21:38 ` Christoph Lameter
2013-11-07 8:27 ` Andreas Herrmann
2013-11-07 8:41 ` Andreas Herrmann
2013-11-07 16:09 ` Christoph Lameter [this message]
[not found] ` <alpine.DEB.2.02.1311071008010.22533@gentwo.org>
2013-11-07 16:29 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0000014233531ff8-0f4331f9-5da3-4cc8-9c30-a40681228446-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=andreas.herrmann@calxeda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox