From: Christoph Lameter <cl@linux.com>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH v2 1/2] mm: make vmstat_update periodic run conditional
Date: Wed, 28 Aug 2013 19:28:02 +0000 [thread overview]
Message-ID: <00000140c6659902-f76c4733-ff61-47d9-b0d2-69fd04253aa3-000000@email.amazonses.com> (raw)
In-Reply-To: <CAOtvUMdPswm3pHesXAzLYA4c7yzsXKoRoOt2T3LWBCjZ86ybpg@mail.gmail.com>
On Fri, 9 Aug 2013, Gilad Ben-Yossef wrote:
> If the code does not consider setting the vmstat_cpus bit in the mask
> unless we are running
> on a CPU in tickless state, than we will (almost) never set
> vmstat_cpus since we will (almost)
> never be tickless in a deferrable work -
Sorry never got around to answering this one. Not sure what to do about
it.
How about this: Disable the vmstats when there is no diff to handle
instead? This means that the OS was quiet during the earlier period. That
way you have an independent criteria for switching vmstat work off from
tickless. Would even work when there are multiple processes running on the
processor if none of them causes counter updates.
In the meantime there are additional patches for the vmstat function
pending for merge from me (not related to the conditional running of
vmstat but may make it easier to implement). So if you want to do any work
then please on top of the newer release available from Andrew's tree.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-28 19:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 15:23 vmstat kthreads Paul E. McKenney
2013-06-18 17:46 ` Christoph Lameter
2013-06-18 18:26 ` Paul E. McKenney
2013-06-19 14:23 ` Christoph Lameter
2013-06-19 14:50 ` Gilad Ben-Yossef
2013-06-19 14:57 ` Gilad Ben-Yossef
2013-06-20 5:06 ` Gilad Ben-Yossef
2013-06-19 14:59 ` Paul E. McKenney
2013-06-19 20:18 ` Christoph Lameter
2013-06-19 20:02 ` [PATCH v2 1/2] mm: make vmstat_update periodic run conditional Gilad Ben-Yossef
2013-06-20 14:05 ` Christoph Lameter
2013-08-07 18:16 ` Christoph Lameter
2013-08-08 6:28 ` Gilad Ben-Yossef
2013-08-08 6:54 ` Gilad Ben-Yossef
2013-08-08 14:59 ` Christoph Lameter
2013-08-09 18:56 ` Gilad Ben-Yossef
2013-08-28 19:28 ` Christoph Lameter [this message]
2013-06-19 20:02 ` [PATCH v2 2/2] mm: add sysctl to pick vmstat monitor cpu Gilad Ben-Yossef
2013-06-20 13:58 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00000140c6659902-f76c4733-ff61-47d9-b0d2-69fd04253aa3-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=fweisbec@gmail.com \
--cc=gilad@benyossef.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox