From: Christoph Lameter <cl@linux.com>
To: akpm@linuxfoundation.org
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Tejun Heo <tj@kernel.org>, Joonsoo Kim <js1304@gmail.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-mm@kvack.org
Subject: [3.12 2/3] vmstat: create fold_diff
Date: Wed, 31 Jul 2013 17:32:09 +0000 [thread overview]
Message-ID: <0000014035c972b2-8652a15f-f38d-4c39-aa97-a92d6868498a-000000@email.amazonses.com> (raw)
In-Reply-To: <20130731173202.150701040@linux.com>
Both functions that update global counters use the same mechanism.
Create a function that contains the common code.
Signed-off-by: Christoph Lameter <cl@linux.com>
Index: linux/mm/vmstat.c
===================================================================
--- linux.orig/mm/vmstat.c 2013-07-26 10:37:11.004503227 -0500
+++ linux/mm/vmstat.c 2013-07-26 10:37:11.000503146 -0500
@@ -414,6 +414,15 @@ void dec_zone_page_state(struct page *pa
EXPORT_SYMBOL(dec_zone_page_state);
#endif
+static inline void fold_diff(int *diff)
+{
+ int i;
+
+ for (i = 0; i < NR_VM_ZONE_STAT_ITEMS; i++)
+ if (diff[i])
+ atomic_long_add(diff[i], &vm_stat[i]);
+}
+
/*
* Update the zone counters for the current cpu.
*
@@ -483,10 +492,7 @@ static void refresh_cpu_vm_stats(int cpu
drain_zone_pages(zone, &p->pcp);
#endif
}
-
- for (i = 0; i < NR_VM_ZONE_STAT_ITEMS; i++)
- if (global_diff[i])
- atomic_long_add(global_diff[i], &vm_stat[i]);
+ fold_diff(global_diff);
}
/*
@@ -516,9 +522,7 @@ void cpu_vm_stats_fold(int cpu)
}
}
- for (i = 0; i < NR_VM_ZONE_STAT_ITEMS; i++)
- if (global_diff[i])
- atomic_long_add(global_diff[i], &vm_stat[i]);
+ fold_diff(global_diff);
}
/*
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next parent reply other threads:[~2013-07-31 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130731173202.150701040@linux.com>
2013-07-31 17:32 ` Christoph Lameter [this message]
2013-07-31 17:32 ` [3.12 1/3] vmstat: Create separate function to fold per cpu diffs into glocal counters Christoph Lameter
2013-07-31 17:42 ` [3.12 3/3] vmstat: Use this_cpu to avoid irqon/off sequence in refresh_cpu_vm_stats Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0000014035c972b2-8652a15f-f38d-4c39-aa97-a92d6868498a-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linuxfoundation.org \
--cc=js1304@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox