From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx174.postini.com [74.125.245.174]) by kanga.kvack.org (Postfix) with SMTP id 5CCE56B0036 for ; Thu, 18 Jul 2013 09:45:42 -0400 (EDT) Date: Thu, 18 Jul 2013 13:45:41 +0000 From: Christoph Lameter Subject: Re: [PATCH] mm/slub.c: add parameter length checking for alloc_loc_track() In-Reply-To: <51E73A16.8070406@asianux.com> Message-ID: <0000013ff2076fb0-b52e0245-8fb5-4842-b0dd-d812ce2c9f62-000000@email.amazonses.com> References: <51DA734B.4060608@asianux.com> <51DE549F.9070505@kernel.org> <51DE55C9.1060908@asianux.com> <0000013fce9f5b32-7d62f3c5-bb35-4dd9-ab19-d72bae4b5bdc-000000@email.amazonses.com> <51DEF935.4040804@kernel.org> <0000013fcf608df8-457e2029-51f9-4e49-9992-bf399a97d953-000000@email.amazonses.com> <51DF4540.8060700@asianux.com> <51DF4C94.3060103@asianux.com> <51DF5404.4060004@asianux.com> <0000013fd3250e40-1832fd38-ede3-41af-8fe3-5a0c10f5e5ce-000000@email.amazonses.com> <51E33F98.8060201@asianux.com> <0000013fe2e73e30-817f1bdb-8dc7-4f7b-9b60-b42d5d244fda-000000@email.amazonses.com> <51E49BDF.30008@asianux.com> <0000013fed280250-85b17e35-d4d4-468d-abed-5b2e29cedb94-000000@email.amazonses.com> <51E73A16.8070406@asianux.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Chen Gang Cc: Pekka Enberg , mpm@selenic.com, linux-mm@kvack.org, Andrew Morton On Thu, 18 Jul 2013, Chen Gang wrote: > Hmm... when anybody says "need respect original authors' willing and > opinions", I think it often means we have found the direct issue, but > none of us find the root issue. Is there an actual problem / failure being addressed by this patch? > e.g. for our this case: > the direct issue is: > "whether need check the length with 'max' parameter". > but maybe the root issue is: > "whether use 'size' as related parameter name instead of 'max'". > in alloc_loc_track(), 'max' just plays the 'size' role. "max" determines the size of the loc_track structure. So these can roughly mean the same thing. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org