From: Christoph Lameter <cl@linux.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: Pekka Enberg <penberg@kernel.org>, mpm@selenic.com, linux-mm@kvack.org
Subject: Re: [PATCH] mm/slub.c: use 'unsigned long' instead of 'int' for variable 'slub_debug'
Date: Fri, 12 Jul 2013 13:53:16 +0000 [thread overview]
Message-ID: <0000013fd3283b9c-b5fe217c-fff3-47fd-be0b-31b00faba1f3-000000@email.amazonses.com> (raw)
In-Reply-To: <51DF5F43.3080408@asianux.com>
On Fri, 12 Jul 2013, Chen Gang wrote:
> Since all values which can be assigned to 'slub_debug' are 'unsigned
> long', recommend also to define 'slub_debug' as 'unsigned long' to
> match the type precisely
The bit definitions in slab.h as well as slub.c all assume that these are
32 bit entities. See f.e. the defition of the internal slub flags:
/* Internal SLUB flags */
#define __OBJECT_POISON 0x80000000UL /* Poison object */
#define __CMPXCHG_DOUBLE 0x40000000UL /* Use cmpxchg_double */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-12 13:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 1:43 Chen Gang
2013-07-12 3:27 ` [PATCH] mm/slub.c: beautify code of this file Chen Gang
2013-07-12 13:58 ` Christoph Lameter
2013-07-15 0:31 ` Chen Gang
2013-07-15 1:04 ` [PATCH 0/2] " Chen Gang
2013-07-15 1:05 ` [PATCH 1/2] mm/slub.c: beautify code for 80 column limitation and tab alignment Chen Gang
2013-07-15 14:19 ` Christoph Lameter
2013-07-16 0:55 ` Chen Gang
2013-07-15 1:06 ` [PATCH 2/2] mm/slub.c: beautify code for removing redundancy 'break' statement Chen Gang
2013-07-17 7:08 ` Pekka Enberg
2013-07-17 14:47 ` Christoph Lameter
2013-07-18 0:02 ` Chen Gang
2013-07-12 13:53 ` Christoph Lameter [this message]
2013-07-15 0:19 ` [PATCH] mm/slub.c: use 'unsigned long' instead of 'int' for variable 'slub_debug' Chen Gang
2013-07-15 14:17 ` Christoph Lameter
2013-07-16 0:53 ` Chen Gang
2013-07-17 14:46 ` Christoph Lameter
2013-07-18 0:13 ` Chen Gang
2013-07-18 13:42 ` Christoph Lameter
2013-07-19 0:50 ` Chen Gang F T
2013-07-19 14:00 ` Christoph Lameter
2013-07-22 1:19 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0000013fd3283b9c-b5fe217c-fff3-47fd-be0b-31b00faba1f3-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=gang.chen@asianux.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox