From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx176.postini.com [74.125.245.176]) by kanga.kvack.org (Postfix) with SMTP id 61D646B0031 for ; Fri, 12 Jul 2013 09:49:50 -0400 (EDT) Date: Fri, 12 Jul 2013 13:49:49 +0000 From: Christoph Lameter Subject: Re: [PATCH] mm/slub.c: add parameter length checking for alloc_loc_track() In-Reply-To: <51DF5404.4060004@asianux.com> Message-ID: <0000013fd3250e40-1832fd38-ede3-41af-8fe3-5a0c10f5e5ce-000000@email.amazonses.com> References: <51DA734B.4060608@asianux.com> <51DE549F.9070505@kernel.org> <51DE55C9.1060908@asianux.com> <0000013fce9f5b32-7d62f3c5-bb35-4dd9-ab19-d72bae4b5bdc-000000@email.amazonses.com> <51DEF935.4040804@kernel.org> <0000013fcf608df8-457e2029-51f9-4e49-9992-bf399a97d953-000000@email.amazonses.com> <51DF4540.8060700@asianux.com> <51DF4C94.3060103@asianux.com> <51DF5404.4060004@asianux.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Chen Gang Cc: Pekka Enberg , mpm@selenic.com, linux-mm@kvack.org, Andrew Morton On Fri, 12 Jul 2013, Chen Gang wrote: > Since alloc_loc_track() will alloc additional space, and already knows > about 'max', so need be sure of 'max' must be larger than 't->count'. alloc_loc_track is only called if t->count > max from add_location: /* * Not found. Insert new tracking element. */ if (t->count >= t->max && !alloc_loc_track(t, 2 * t->max, GFP_ATOMIC)) return 0; > The caller may not notice about it, e.g. call from add_location() in > "mm/slub.c", which only let "max = 2 * max" when "t->count >= t->max" That call already has the condition checked before the call. The only other caller is list_locations which calls alloc_loc_track when t->count == 0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org