From: Christoph Lameter <cl@linux.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
Glauber Costa <glommer@parallels.com>,
Andrew Morton <akpm@linux-foundation.org>,
Joonsoo Kim <js1304@gmail.com>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm/slub: Fix slub calculate active slabs uncorrectly
Date: Mon, 1 Jul 2013 18:45:03 +0000 [thread overview]
Message-ID: <0000013f9b8d6897-d2399224-d203-4dc5-a700-90dea9be7536-000000@email.amazonses.com> (raw)
In-Reply-To: <1372291059-9880-1-git-send-email-liwanp@linux.vnet.ibm.com>
On Thu, 27 Jun 2013, Wanpeng Li wrote:
> Enough slabs are queued in partial list to avoid pounding the page allocator
> excessively. Entire free slabs are not discarded immediately if there are not
> enough slabs in partial list(n->partial < s->min_partial). The number of total
> slabs is composed by the number of active slabs and the number of entire free
> slabs, however, the current logic of slub implementation ignore this which lead
> to the number of active slabs and the number of total slabs in slabtop message
> is always equal. This patch fix it by substract the number of entire free slabs
> in partial list when caculate active slabs.
What do you mean by "active" slabs? If this excludes the small number of
empty slabs that could be present then indeed you will not have that
number. But why do you need that?
The number of total slabs is the number of partial slabs, plus the number
of full slabs plus the number of percpu slabs.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-01 18:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 23:57 Wanpeng Li
2013-06-26 23:57 ` [PATCH 2/3] mm/slub: remove nr_partials Wanpeng Li
2013-06-26 23:57 ` [PATCH 3/3] mm/slub: Use node_nr_slabs and node_nr_objs in get_slabinfo Wanpeng Li
2013-07-01 18:47 ` Christoph Lameter
2013-07-01 18:45 ` Christoph Lameter [this message]
2013-07-02 0:03 ` [PATCH 1/3] mm/slub: Fix slub calculate active slabs uncorrectly Wanpeng Li
2013-07-02 0:03 ` Wanpeng Li
[not found] ` <51d218df.a77d440a.3cfe.ffffe64aSMTPIN_ADDED_BROKEN@mx.google.com>
2013-07-02 14:15 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0000013f9b8d6897-d2399224-d203-4dc5-a700-90dea9be7536-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=glommer@parallels.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox