From: Christoph Lameter <cl@gentwo.org>
To: Nicolas Palix <nicolas.palix@imag.fr>
Cc: Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
linux-mm@kvack.org
Subject: Re: Handling of GFP_WAIT in the slub and slab allocators
Date: Mon, 10 Jun 2013 23:39:27 +0000 [thread overview]
Message-ID: <0000013f307566d3-94cbc8ed-e638-4f95-aa1a-9d32dbae2022-000000@email.amazonses.com> (raw)
In-Reply-To: <CAAxaTiOwqEzYO1QTae3HTAu2C-uQY1gvCXeC5rwzypRGV6d+BQ@mail.gmail.com>
On Mon, 10 Jun 2013, Nicolas Palix wrote:
> On Mon, Jun 10, 2013 at 5:18 PM, Christoph Lameter <cl@gentwo.org> wrote:
> > On Mon, 10 Jun 2013, Nicolas Palix wrote:
> >
> >> I notice that in the SLAB allocator, local_irq_save and
> >> local_irq_restore are called in slab_alloc_node and slab_alloc without
> >> checking the GFP_WAIT bit of the flags parameter.
> >
> > SLAB does the same as SLUB. Have a look at mm/slab.c:cache_grow()
>
> I agree and it is the same for mm/slab.c:fallback_alloc() but
> why is it not also required for mm/slab.c:slab_alloc_node()
> and mm/slab.c:slab_alloc() which both manipulate the local irqs?
Because cache_grow calls into the page allocator and we cannot do reclaim
with interrupts off.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-06-10 23:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 14:09 Nicolas Palix
2013-06-10 15:18 ` Christoph Lameter
2013-06-10 21:27 ` Nicolas Palix
2013-06-10 23:39 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0000013f307566d3-94cbc8ed-e638-4f95-aa1a-9d32dbae2022-000000@email.amazonses.com \
--to=cl@gentwo.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=nicolas.palix@imag.fr \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox