From: Christoph Lameter <cl@linux.com>
To: Hugh Dickins <hughd@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Lee Schermerhorn <lee.schermerhorn@hp.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
David Rientjes <rientjes@google.com>,
Mel Gorman <mgorman@suse.de>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/2] tmpfs mempolicy: fix /proc/mounts corrupting memory
Date: Wed, 2 Jan 2013 15:57:54 +0000 [thread overview]
Message-ID: <0000013bfbfbb293-ccc455ed-2db6-46e2-8362-dc418bae0def-000000@email.amazonses.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1301020153090.18049@eggly.anvils>
On Wed, 2 Jan 2013, Hugh Dickins wrote:
> @@ -2756,13 +2747,13 @@ out:
> * @buffer: to contain formatted mempolicy string
> * @maxlen: length of @buffer
> * @pol: pointer to mempolicy to be formatted
> - * @no_context: "context free" mempolicy - use nodemask in w.user_nodemask
> + * @unused: redundant argument, to be removed later.
> *
> * Convert a mempolicy into a string.
> * Returns the number of characters in buffer (if positive)
> * or an error (negative)
> */
> -int mpol_to_str(char *buffer, int maxlen, struct mempolicy *pol, int no_context)
> +int mpol_to_str(char *buffer, int maxlen, struct mempolicy *pol, int unused)
> {
> char *p = buffer;
> int l;
> @@ -2796,10 +2787,7 @@ int mpol_to_str(char *buffer, int maxlen
> case MPOL_BIND:
> /* Fall through */
> case MPOL_INTERLEAVE:
> - if (no_context)
> - nodes = pol->w.user_nodemask;
> - else
> - nodes = pol->v.nodes;
> + nodes = pol->v.nodes;
> break;
>
no_context was always true. Why is the code from the false branch kept?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-02 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 10:01 Hugh Dickins
2013-01-02 10:04 ` [PATCH 2/2] mempolicy: remove arg from mpol_parse_str, mpol_to_str Hugh Dickins
2013-01-02 20:39 ` KOSAKI Motohiro
2013-01-02 14:32 ` [PATCH 1/2] tmpfs mempolicy: fix /proc/mounts corrupting memory Christoph Lameter
2013-01-02 18:30 ` Hugh Dickins
2013-01-02 15:57 ` Christoph Lameter [this message]
2013-01-02 17:24 ` Linus Torvalds
2013-01-02 17:27 ` Linus Torvalds
2013-01-02 18:48 ` Hugh Dickins
2013-01-02 20:38 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0000013bfbfbb293-ccc455ed-2db6-46e2-8362-dc418bae0def-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kosaki.motohiro@gmail.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox