From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx115.postini.com [74.125.245.115]) by kanga.kvack.org (Postfix) with SMTP id A87F36B0071 for ; Thu, 25 Oct 2012 11:19:28 -0400 (EDT) Date: Thu, 25 Oct 2012 15:19:27 +0000 From: Christoph Lameter Subject: Re: [RFC] Support volatile range for anon vma In-Reply-To: <1351133820-14096-1-git-send-email-minchan@kernel.org> Message-ID: <0000013a9881a86c-c0fb5823-b6e7-4bea-8707-f6b8eddae14d-000000@email.amazonses.com> References: <1351133820-14096-1-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, John Stultz , Andrew Morton , Android Kernel Team , Robert Love , Mel Gorman , Hugh Dickins , Dave Hansen , Rik van Riel , Dave Chinner , Neil Brown , Mike Hommey , Taras Glek , KOSAKI Motohiro , KAMEZAWA Hiroyuki On Thu, 25 Oct 2012, Minchan Kim wrote: > #endif > + /* > + * True if page in this vma is reclaimed. What does that mean? All pages in the vma have been cleared out? > + TTU_IGNORE_VOLATILE = (1 << 11),/* ignore volatile */ > }; > #define TTU_ACTION(x) ((x) & TTU_ACTION_MASK) > > int try_to_unmap(struct page *, enum ttu_flags flags); > int try_to_unmap_one(struct page *, struct vm_area_struct *, > - unsigned long address, enum ttu_flags flags); > + unsigned long address, enum ttu_flags flags, > + bool *is_volatile); You already pass a vma pointer in. Why do you need to pass a volatile flag in? Looks like unecessary churn. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org