From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx184.postini.com [74.125.245.184]) by kanga.kvack.org (Postfix) with SMTP id 131A16B0082 for ; Fri, 19 Oct 2012 15:50:39 -0400 (EDT) Date: Fri, 19 Oct 2012 19:50:37 +0000 From: Christoph Lameter Subject: Re: [PATCH v5 15/18] Aggregate memcg cache values in slabinfo In-Reply-To: <1350656442-1523-16-git-send-email-glommer@parallels.com> Message-ID: <0000013a7a93cb72-588b2a69-ebb0-4b5f-9040-102800d3bef4-000000@email.amazonses.com> References: <1350656442-1523-1-git-send-email-glommer@parallels.com> <1350656442-1523-16-git-send-email-glommer@parallels.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Mel Gorman , Tejun Heo , Andrew Morton , Michal Hocko , Johannes Weiner , kamezawa.hiroyu@jp.fujitsu.com, David Rientjes , Pekka Enberg , devel@openvz.org, Pekka Enberg , Suleiman Souhlal On Fri, 19 Oct 2012, Glauber Costa wrote: > + > +/* > + * We use suffixes to the name in memcg because we can't have caches > + * created in the system with the same name. But when we print them > + * locally, better refer to them with the base name > + */ > +static inline const char *cache_name(struct kmem_cache *s) > +{ > + if (!is_root_cache(s)) > + return s->memcg_params->root_cache->name; > + return s->name; > +} Could we avoid this uglyness? You can ID a slab cache by combining a memcg pointer and a slabname. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org